Clone
 

rodrigo b. de oliveira <rodrigo@gradle.com> in Gradle

Get `--scan` to work with instant execution again

By making the `Settings` object initialization in instant execution more similar

to how it works in classic execution:

- instantiate `Settings` object during `SettingsPreparer` execution

- move `SettingsProcessor` execution to happen in the context of `SettingsPreparer`

- create a separate ClassLoaderScope for `Settings` so it can receive plugins

- always apply auto-applied plugin requests during `SettingsProcess` execution

This commit also removes the system property propagation hack as it's no longer

needed.

Remove no longer used method `BuildReceipt.readBuildReceipt`

Refine `BuildVersionPlugin`

- Extract `BuildTimestampFromBuildReceipt`

- Improve names

Add note about the relevance of the CI env var to the ie smoke test

Reduce visibility of extension methods

Remove `CI` environment var from instant execution smoke test environment

So the test is not affected by `buildTimestamp` differences and better

reproduces what happens in developer machine.

Don't bother checking if the build is running on CI when running an install task

One less build logic input to capture.

Compute `buildTimestamp` using a value source to capture the relevant build logic inputs

Replace `baseVersion` and `isSnapshot` extra properties by `BuildVersion` project extension

    • -0
    • +1
    /buildSrc/subprojects/docs/docs.gradle.kts
Remove warning from `BuildEnvironment.kt`

By introducing non-null assertion.

Remove warning from `BuildEnvironment.kt`

By introducing non-null assertion.

Simplify `DefaultInstantExecution`

- Reuse `service<T>()`

Simplify `DefaultInstantExecution`

- Reuse `service<T>()`

Move remaining bits of `versioning.gradle` to `BuildVersionPlugin`

And move `BuildVersionPlugin` to the `plugins` project in the process so it has

access to the `buildTypes` extension.

Move remaining bits of `versioning.gradle` to `BuildVersionPlugin`

And move `BuildVersionPlugin` to the `plugins` project in the process so it has

access to the `buildTypes` extension.

Adjust `KotlinScriptCompilerTest` to work with the latest Kotlin 1.3.70 eap

By moving the script template class to the top level.

Move registration of tasks from `build-receipt.gradle` to `BuildVersionPlugin`

So the required property values don't have to be shared via extra properties.

Move registration of tasks from `build-receipt.gradle` to `BuildVersionPlugin`

So the required property values don't have to be shared via extra properties.

Move registration of tasks from `build-receipt.gradle` to `BuildVersionPlugin`

So the required property values don't have to be shared via extra properties.

Set exemplar flags on the `snippets/plugins/pluginManagement` sample

So it actually evaluates the init script.

Set exemplar flags on the `snippets/plugins/pluginManagement` sample

So it actually evaluates the init script.

Fix Gradle Kotlin DSL init script sample snippet

See #11885

Fix Gradle Kotlin DSL init script sample snippet

See #11885

Remove unused build version extra properties

Polish `DefaultInstantExecution`

- Make code readable under 96 columns

Dedupe references to `BuildReceipt.BUILD_RECEIPT_FILE_NAME`

Organize `buildSrc` project dependencies

    • -0
    • +1
    /buildSrc/subprojects/build/build.gradle.kts
    • -1
    • +2
    /buildSrc/subprojects/docs/docs.gradle.kts
    • -1
    • +2
    /buildSrc/subprojects/ide/ide.gradle.kts
Polish `ProjectScopeServices`

- Replace anonymous class by lambda

Treat `version.txt` as a build logic input

By reading it via `providers.fileContents`.

Polish `UnitTestAndCompilePlugin`

- Silence unused variable warning