Clone
Tools

 

michael barnathan <michael@gradle.com> in Gradle

About

81 commits
  • Committer is not mapped to a user
  • First commit: 12 April 2016
  • Last commit: 27 July 2016
Last Week All Time
Commits: 0 81

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 27 Jul 2016
11:38 am

Michael Barnathan <michael@gradle.com>

Revert "Create reusable classloader!"

This reverts commit 99e45db07b78a4b5c9783ddf2e2e4e17deeb07d0.

Options
    • -87
    • +0
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/ReusableClassLoader.java
    • -3
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/ClassLoaderScope.java
    • -16
    • +2
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/DefaultClassLoaderScope.java
    • -7
    • +0
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/RootClassLoaderScope.java
    • -9
    • +2
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
11:37 am

Michael Barnathan <michael@gradle.com>

Revert "Remove ReusableClassLoader as it wasn't necessary."

This reverts commit 3d74f0626cfd3de695a4d1cd0b66cdcfdfd237a9.

Options
    • -0
    • +87
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/ReusableClassLoader.java
11:25 am

Michael Barnathan <michael@gradle.com>

Revert "Close the project classloader at end of build."

This reverts commit af366ca162d0a60857d02d099c83cd0dbcf14021.

Options
    • -1
    • +0
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/ClassLoaderScope.java
    • -45
    • +23
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/DefaultClassLoaderScope.java
    • -6
    • +3
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/RootClassLoaderScope.java
    • -1
    • +0
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/ClassLoaderCache.java
    • -11
    • +0
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/DefaultClassLoaderCache.java
    • -1
    • +0
    /subprojects/core/src/main/java/org/gradle/api/internal/project/DefaultProject.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/project/antbuilder/FinalizerThread.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultInitScriptProcessor.java
    • -0
    • +7
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
    • -12
    • +1
    /subprojects/core/src/main/java/org/gradle/initialization/DefaultGradleLauncher.java
    • -7
    • +5
    /subprojects/core/src/main/java/org/gradle/initialization/InstantiatingBuildLoader.java
    • -3
    • +1
    /subprojects/core/src/main/java/org/gradle/internal/service/scopes/ProjectScopeServices.java
    • -4
    • +22
    /subprojects/core/src/test/groovy/org/gradle/api/internal/initialization/DefaultClassLoaderScopeTest.groovy
    • -5
    • +0
    /subprojects/core/src/test/groovy/org/gradle/api/internal/initialization/loadercache/DummyClassLoaderCache.java
    • -2
    • +2
    /subprojects/integ-test/src/integTest/groovy/org/gradle/integtests/BuildScriptClasspathIntegrationSpec.groovy
  16. … 3 more files in changeset.
Tuesday 19 Jul 2016
10:45 pm

Michael Barnathan <michael@gradle.com>

Close the project classloader at end of build.

Also restore all six cases of Lari's test as the jarfile lock

is released at the end of build rather than beginning of the next now.

Options
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/ClassLoaderScope.java
    • -23
    • +45
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/DefaultClassLoaderScope.java
    • -3
    • +6
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/RootClassLoaderScope.java
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/ClassLoaderCache.java
    • -0
    • +11
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/DefaultClassLoaderCache.java
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/project/DefaultProject.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/project/antbuilder/FinalizerThread.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultInitScriptProcessor.java
    • -7
    • +0
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
    • -1
    • +12
    /subprojects/core/src/main/java/org/gradle/initialization/DefaultGradleLauncher.java
    • -5
    • +7
    /subprojects/core/src/main/java/org/gradle/initialization/InstantiatingBuildLoader.java
    • -1
    • +3
    /subprojects/core/src/main/java/org/gradle/internal/service/scopes/ProjectScopeServices.java
    • -22
    • +4
    /subprojects/core/src/test/groovy/org/gradle/api/internal/initialization/DefaultClassLoaderScopeTest.groovy
    • -0
    • +5
    /subprojects/core/src/test/groovy/org/gradle/api/internal/initialization/loadercache/DummyClassLoaderCache.java
    • -2
    • +2
    /subprojects/integ-test/src/integTest/groovy/org/gradle/integtests/BuildScriptClasspathIntegrationSpec.groovy
  16. … 3 more files in changeset.
10:44 pm

Michael Barnathan <michael@gradle.com>

Remove ReusableClassLoader as it wasn't necessary.

Options
    • -87
    • +0
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/ReusableClassLoader.java
8:37 pm

Michael Barnathan <michael@gradle.com>

Create reusable classloader!

This ClassLoader will lazily reinstantiate and replay loadClass operations

if a loadClass is called following a call to close().

Options
    • -0
    • +87
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/ReusableClassLoader.java
    • -1
    • +3
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/ClassLoaderScope.java
    • -2
    • +16
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/DefaultClassLoaderScope.java
    • -0
    • +7
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/RootClassLoaderScope.java
    • -2
    • +9
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
1:35 pm

Michael Barnathan <michael@gradle.com>

Handle enums w/diff ClassLoaders in DiffUtil.

+ Lots of unit tests for DiffUtil.

This was causing builds to falsely identify as out of date.

Options
    • -2
    • +25
    /subprojects/core/src/main/java/org/gradle/util/DiffUtil.java
    • -8
    • +313
    /subprojects/core/src/test/groovy/org/gradle/util/DiffUtilTest.groovy
Sunday 17 Jul 2016
7:23 pm

Michael Barnathan <michael@gradle.com>

Merge branch 'master' into mb-close-classloaders

Options
7:13 pm

Michael Barnathan <michael@gradle.com>

Disable the "delete file true" tests for now.

The ClassLoader which holds these (the project base classloader for

exports) is the same one that BuildComparison relies on.

Options
    • -2
    • +2
    /subprojects/integ-test/src/integTest/groovy/org/gradle/integtests/BuildScriptClasspathIntegrationSpec.groovy
7:05 pm

Michael Barnathan <michael@gradle.com>

Revert "Clean up Groovy script classloader cache between builds so we can"

I chased this classloader all over the codebase and it isn't possible to

unload at any point in the build lifecycle without breaking the comparison plugin.

This reverts commit 40a25e697d53f1608e4f7f9d6025b7e9da91cb65.

Options
    • -13
    • +11
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
    • -5
    • +0
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/ScriptRunner.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/CrossBuildInMemoryCachingScriptClassCache.java
    • -1
    • +0
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
    • -9
    • +0
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptRunnerFactory.java
    • -6
    • +0
    /subprojects/core/src/test/groovy/org/gradle/configuration/DefaultScriptPluginFactoryTest.groovy
Friday 15 Jul 2016
10:39 pm

Michael Barnathan <michael@gradle.com>

Keep DefaultToolingImplementationLoader classloader open after change was clobbered by merge.

Options
    • -3
    • +0
    /subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/loader/DefaultToolingImplementationLoader.java
2:53 pm

Michael Barnathan <michael@gradle.com>

Clean up Groovy script classloader cache between builds so we can delete plugin jar files after a build completes.

Options
    • -11
    • +13
    /subprojects/core/src/main/java/org/gradle/configuration/DefaultScriptPluginFactory.java
    • -0
    • +5
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/ScriptRunner.java
    • -1
    • +1
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/CrossBuildInMemoryCachingScriptClassCache.java
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
    • -0
    • +9
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptRunnerFactory.java
    • -0
    • +6
    /subprojects/core/src/test/groovy/org/gradle/configuration/DefaultScriptPluginFactoryTest.groovy
2:52 pm

Michael Barnathan <michael@gradle.com>

Merge remote-tracking branch 'origin/mb-close-classloaders' into mb-close-classloaders

Options
    • -0
    • +3
    /subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/loader/DefaultToolingImplementationLoader.java
9:24 am

Michael Barnathan <michael@gradle.com>

Revert "Disable some Native tests for Java 7"

This reverts commit 885433ea97cf5da3453314909cbdef47f0d9deb3.

Options
    • -4
    • +0
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/platform/BinaryNativePlatformIntegrationTest.groovy
9:24 am

Michael Barnathan <michael@gradle.com>

Use argument-free waitFor for Java 6 compatibility.

Options
    • -2
    • +2
    /subprojects/platform-native/src/testFixtures/groovy/org/gradle/nativeplatform/fixtures/binaryinfo/ReadelfBinaryInfo.groovy
Thursday 14 Jul 2016
10:47 pm

Michael Barnathan <michael@gradle.com>

Remove available from DefaultVisualStudioLocatorTest.

Options
    • -1
    • +0
    /subprojects/platform-native/src/test/groovy/org/gradle/nativeplatform/toolchain/internal/msvcpp/DefaultVisualStudioLocatorTest.groovy
10:35 pm

Michael Barnathan <michael@gradle.com>

Fix the native integration tests on gcc cygwin.

+review REVIEW-6103

Options
    • -4
    • +13
    /subprojects/language-native/src/integTest/groovy/org/gradle/language/AbstractNativeLanguageIncrementalBuildIntegrationTest.groovy
    • -2
    • +6
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/LibraryDependenciesIntegrationTest.groovy
    • -5
    • +5
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/NativePlatformSamplesIntegrationTest.groovy
    • -10
    • +16
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/platform/BinaryNativePlatformIntegrationTest.groovy
    • -2
    • +2
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/toolchain/GccToolChainCustomisationIntegrationTest.groovy
    • -0
    • +4
    /subprojects/platform-native/src/integTest/groovy/org/gradle/nativeplatform/toolchain/MultipleNativeToolChainIntegrationTest.groovy
    • -1
    • +2
    /subprojects/platform-native/src/main/java/org/gradle/nativeplatform/toolchain/internal/msvcpp/DefaultVisualStudioLocator.java
    • -2
    • +3
    /subprojects/platform-native/src/main/java/org/gradle/nativeplatform/toolchain/internal/msvcpp/VisualStudioInstall.java
    • -0
    • +1
    /subprojects/platform-native/src/test/groovy/org/gradle/nativeplatform/toolchain/internal/msvcpp/DefaultVisualStudioLocatorTest.groovy
    • -0
    • +13
    /subprojects/platform-native/src/testFixtures/groovy/org/gradle/nativeplatform/fixtures/NativeBinaryFixture.groovy
    • -1
    • +6
    /subprojects/platform-native/src/testFixtures/groovy/org/gradle/nativeplatform/fixtures/binaryinfo/DumpbinBinaryInfo.groovy
    • -0
    • +62
    /subprojects/platform-native/src/testFixtures/groovy/org/gradle/nativeplatform/fixtures/binaryinfo/FileArchOnlyBinaryInfo.groovy
    • -0
    • +6
    /subprojects/platform-native/src/testFixtures/groovy/org/gradle/nativeplatform/fixtures/binaryinfo/ReadelfBinaryInfo.groovy
3:01 pm

Michael Barnathan <michael@gradle.com>

Leave Service classloader open between builds; we expect it.

Options
    • -5
    • +2
    /subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/loader/DefaultToolingImplementationLoader.java
Wednesday 13 Jul 2016
11:40 pm

Michael Barnathan <michael@gradle.com>

Close the ClassLoader in ValidateTaskProperties.

Options
    • -2
    • +11
    /subprojects/plugin-development/src/main/java/org/gradle/plugin/devel/tasks/ValidateTaskProperties.java
11:40 pm

Michael Barnathan <michael@gradle.com>

Close the ClassLoader in ValidateTaskProperties.

Options
    • -2
    • +11
    /subprojects/plugin-development/src/main/java/org/gradle/plugin/devel/tasks/ValidateTaskProperties.java
Tuesday 12 Jul 2016
1:47 pm

Michael Barnathan <michael@gradle.com>

Use the version of ClassLoaderUtils already in the branch.

Options
    • -3
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/DefaultClassLoaderCache.java
    • -3
    • +8
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
1:47 pm

Michael Barnathan <michael@gradle.com>

Use the version of ClassLoaderUtils already in the branch.

Options
    • -3
    • +1
    /subprojects/core/src/main/java/org/gradle/api/internal/initialization/loadercache/DefaultClassLoaderCache.java
    • -3
    • +8
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
11:59 am

Michael Barnathan <michael@gradle.com>

Close the bootstrap classloader after the build finishes.

Options
    • -0
    • +4
    /subprojects/wrapper/src/main/java/org/gradle/wrapper/BootstrapMainStarter.java
11:59 am

Michael Barnathan <michael@gradle.com>

Close the bootstrap classloader after the build finishes.

Options
    • -0
    • +4
    /subprojects/wrapper/src/main/java/org/gradle/wrapper/BootstrapMainStarter.java
10:10 am

Michael Barnathan <michael@gradle.com>

Don't close classloaders following deserialize() just yet - we have unit tests that expect these to persist.

Options
    • -2
    • +1
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/PayloadSerializer.java
10:10 am

Michael Barnathan <michael@gradle.com>

Don't close classloaders following deserialize() just yet - we have unit tests that expect these to persist.

Options
    • -2
    • +1
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/PayloadSerializer.java
Sunday 10 Jul 2016
11:55 pm

Michael Barnathan <michael@gradle.com>

Comment classloaders which are safe, close ones which leak.

Options
    • -0
    • +2
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/DefaultClassLoaderFactory.java
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
    • -10
    • +11
    /subprojects/jetty/src/main/java/org/gradle/api/plugins/jetty/internal/JettyConfiguration.java
    • -4
    • +15
    /subprojects/launcher/src/main/java/org/gradle/launcher/bootstrap/ProcessBootstrap.java
    • -0
    • +15
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/ClassLoaderCache.java
    • -5
    • +27
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/ClientSidePayloadClassLoaderRegistry.java
    • -0
    • +4
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/DefaultPayloadClassLoaderRegistry.java
    • -1
    • +8
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/DeserializeMap.java
    • -0
    • +2
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/PayloadSerializer.java
    • -0
    • +3
    /subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/loader/DefaultToolingImplementationLoader.java
11:55 pm

Michael Barnathan <michael@gradle.com>

Comment classloaders which are safe, close ones which leak.

Options
    • -0
    • +2
    /subprojects/base-services/src/main/java/org/gradle/internal/classloader/DefaultClassLoaderFactory.java
    • -0
    • +1
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptCompilationHandler.java
    • -10
    • +11
    /subprojects/jetty/src/main/java/org/gradle/api/plugins/jetty/internal/JettyConfiguration.java
    • -4
    • +15
    /subprojects/launcher/src/main/java/org/gradle/launcher/bootstrap/ProcessBootstrap.java
    • -0
    • +15
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/ClassLoaderCache.java
    • -5
    • +27
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/ClientSidePayloadClassLoaderRegistry.java
    • -0
    • +4
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/DefaultPayloadClassLoaderRegistry.java
    • -1
    • +8
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/DeserializeMap.java
    • -0
    • +2
    /subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/PayloadSerializer.java
    • -0
    • +3
    /subprojects/tooling-api/src/main/java/org/gradle/tooling/internal/consumer/loader/DefaultToolingImplementationLoader.java
11:53 pm

Michael Barnathan <michael@gradle.com>

Clean up flow in DefaultScriptRunnerFactory.

Options
    • -7
    • +4
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptRunnerFactory.java
11:53 pm

Michael Barnathan <michael@gradle.com>

Clean up flow in DefaultScriptRunnerFactory.

Options
    • -7
    • +4
    /subprojects/core/src/main/java/org/gradle/groovy/scripts/internal/DefaultScriptRunnerFactory.java