Clone
 

andrew nessin <andrewnessinjim@yahoo.com> in Gradle

Correct grammar in docs (#8209)

It's plenty of coverage. It caught several issues already.

It's plenty of coverage. It caught several issues already.

  • I deliberately avoided doing this because it's going to be confusing if you're unfortunate enough to run a build while a…
  • Why do we need a HTTP server here? Why not just use a file:// URL?
  • This doesn't feel like quite enough coverage to me. It's possible that WrapperConcurrentDownloadTest may not even test c…
  • I deliberately avoided doing this because it's going to be confusing if you're unfortunate enough to run a build while another process is downloading the wrapper. You're not going to get any feedback about what's happening and it will look like something has hung.

  • Why do we need a HTTP server here? Why not just use a file:// URL?

  • This doesn't feel like quite enough coverage to me. It's possible that WrapperConcurrentDownloadTest may not even test concurrent behaviour if the download is quick enough.

    Seems like we should have some unit test coverage for the locking and such.