internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Do not use collected attributes from file system walk

They are not reliable on Windows, and are probably not needed in most cases anyway. We can get the same data by querying the file system directly instead.

    • -3
    • +1
    ./vfs/impl/AbstractVirtualFileSystemTest.groovy
  1. … 3 more files in changeset.
Rename PathSuffix -> VfsRelativePath

    • -227
    • +0
    ./snapshot/AbstractCasePathSuffixTest.groovy
    • -0
    • +227
    ./snapshot/AbstractCaseVfsRelativePathTest.groovy
    • -2
    • +2
    ./snapshot/AbstractCompleteSnapshotWithoutChildrenTest.groovy
    • -2
    • +2
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -79
    • +0
    ./snapshot/CaseInsensitivePathSuffixTest.groovy
    • -0
    • +79
    ./snapshot/CaseInsensitiveVfsRelativePathTest.groovy
    • -88
    • +0
    ./snapshot/CaseSensitivePathSuffixTest.groovy
    • -0
    • +88
    ./snapshot/CaseSensitiveVfsRelativePathTest.groovy
    • -0
    • +50
    ./snapshot/VfsRelativePathTest.groovy
    • -2
    • +2
    ./snapshot/VirtualFileSystemTestSpec.groovy
  1. … 10 more files in changeset.
Address some review feedback

    • -3
    • +7
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -10
    • +13
    ./snapshot/CompleteDirectorySnapshotTest.groovy
  1. … 2 more files in changeset.
Move routing file system to :core

    • -135
    • +0
    ./vfs/impl/RoutingVirtualFileSystemTest.groovy
  1. … 5 more files in changeset.
Rename FileHierarchySet to SnapshotHierarchy

    • -705
    • +0
    ./vfs/impl/DefaultFileHierarchySetTest.groovy
    • -0
    • +705
    ./vfs/impl/DefaultSnapshotHierarchyTest.groovy
  1. … 5 more files in changeset.
Rename relativePath to searchedPath

    • -19
    • +19
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -7
    • +7
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -11
    • +11
    ./snapshot/CompleteDirectorySnapshotTest.groovy
    • -3
    • +3
    ./snapshot/PartialDirectorySnapshotTest.groovy
Remove unnecessary whitespace

    • -20
    • +20
    ./snapshot/SnapshotUtilTest.groovy
Use actual PathSuffix for VFSTestSpec

    • -2
    • +4
    ./snapshot/VirtualFileSystemTestSpec.groovy
Add tests for PathSuffix

Rename `CasePath{Util -> Suffix}Test`

    • -0
    • +227
    ./snapshot/AbstractCasePathSuffixTest.groovy
    • -231
    • +0
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -0
    • +79
    ./snapshot/CaseInsensitivePathSuffixTest.groovy
    • -79
    • +0
    ./snapshot/CaseInsensitivePathUtilTest.groovy
    • -0
    • +88
    ./snapshot/CaseSensitivePathSuffixTest.groovy
    • -88
    • +0
    ./snapshot/CaseSensitivePathUtilTest.groovy
Use `PathSuffix` in VirtualFileSystemTestSpec

    • -8
    • +8
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -8
    • +8
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -3
    • +3
    ./snapshot/PartialDirectorySnapshotTest.groovy
    • -8
    • +6
    ./snapshot/VirtualFileSystemTestSpec.groovy
Use more `of` in tests

    • -8
    • +8
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -15
    • +16
    ./snapshot/SnapshotUtilTest.groovy
  1. … 1 more file in changeset.
Move more logic into PathSuffix

    • -5
    • +5
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -1
    • +1
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -3
    • +3
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
  1. … 4 more files in changeset.
Rename OffsetRelativePath -> PathSuffix

    • -6
    • +6
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -2
    • +2
    ./snapshot/AbstractCompleteSnapshotWithoutChildrenTest.groovy
    • -4
    • +4
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -2
    • +2
    ./snapshot/CaseSensitivePathUtilTest.groovy
  1. … 10 more files in changeset.
Remove methods dealing with prefixes from PathUtil

The methods have already been copied to OffsetRelativePath

    • -14
    • +17
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -1
    • +1
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -3
    • +2
    ./snapshot/CaseSensitivePathUtilTest.groovy
  1. … 1 more file in changeset.
Test empty children as well

    • -3
    • +5
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -0
    • +5
    ./snapshot/PartialDirectorySnapshotTest.groovy
Add remaining test coverage for SnapshotUtil

    • -2
    • +3
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -0
    • +100
    ./snapshot/SnapshotUtilTest.groovy
  1. … 5 more files in changeset.
Add Javadoc for FileSystemNode.getSnapshot()

    • -1
    • +0
    ./snapshot/AbstractCompleteSnapshotWithoutChildrenTest.groovy
  1. … 1 more file in changeset.
Add tests for CompleteDirectorySnapshot

    • -0
    • +180
    ./snapshot/CompleteDirectorySnapshotTest.groovy
Extract superclass AbstractSnapshotWithChildrenTest

    • -193
    • +10
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -0
    • +207
    ./snapshot/AbstractSnapshotWithChildrenTest.groovy
    • -1
    • +1
    ./snapshot/PartialDirectorySnapshotTest.groovy
Add tests for complete snapshots without children

    • -0
    • +65
    ./snapshot/AbstractCompleteSnapshotWithoutChildrenTest.groovy
    • -0
    • +24
    ./snapshot/MissingFileSnapshotTest.groovy
    • -0
    • +26
    ./snapshot/RegularFileSnapshotTest.groovy
Inline getSelectedChildSnapshot

The method is now so easy that it is not necessary any more.

    • -13
    • +7
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
Rename test fixtures

    • -11
    • +57
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -3
    • +3
    ./snapshot/PartialDirectorySnapshotTest.groovy
Merge branch 'master'

    • -22
    • +24
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -3
    • +5
    ./snapshot/PartialDirectorySnapshotTest.groovy
    • -12
    • +16
    ./vfs/impl/DefaultFileHierarchySetTest.groovy
  1. … 5 more files in changeset.
Rename compare{WithCommonPrefix -> FirstSegment}

since that is what the method does: comparing the first segment of two

paths.

    • -10
    • +10
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -3
    • +3
    ./snapshot/CaseSensitivePathUtilTest.groovy
  1. … 2 more files in changeset.
Address more review comments

    • -1
    • +1
    ./snapshot/AbstractCasePathUtilTest.groovy
  1. … 1 more file in changeset.
Separate MetadataSnapshot from FileSystemNode

A `FileSystemNode` has a `MetadataSnapshot`, though it normally isn't an

`MetadataSnapshot`. Currently, `CompleteFileSystemSnapshot`s are both

`MetadataSnapshot`s and `FileSystemNode`s.

At some point in the future we should separate the child structure

(aka `FileSystemNode`) from the stored values (aka `MetadataSnapshot`)

for `CompleteFileSystemSnapshot`s as well, which means also removing the

children from `CompleteDirectorySnapshot`.

    • -63
    • +59
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -7
    • +4
    ./snapshot/PartialDirectorySnapshotTest.groovy
    • -22
    • +26
    ./vfs/impl/DefaultFileHierarchySetTest.groovy
  1. … 10 more files in changeset.
Inline VirtualFileSystemTestFixture

    • -28
    • +61
    ./snapshot/AbstractIncompleteSnapshotWithChildrenTest.groovy
    • -2
    • +2
    ./snapshot/PartialDirectorySnapshotTest.groovy
    • -66
    • +0
    ./snapshot/VirtualFileSystemTestFixture.groovy
Use Comparable in SearchUtil

This requires to turn around the compareWithCommonPrefix function to

make it consistent with they way it is used in `binarySearch`

    • -20
    • +20
    ./snapshot/AbstractCasePathUtilTest.groovy
    • -2
    • +2
    ./snapshot/CaseSensitivePathUtilTest.groovy
  1. … 3 more files in changeset.
Address more review feedback

    • -7
    • +7
    ./snapshot/AbstractCasePathUtilTest.groovy
  1. … 3 more files in changeset.