Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -2
    • +2
    ./compile/IncrementalGroovyCompileIntegrationTest.groovy
  1. … 871 more files in changeset.
Annotate integ tests failing with instant execution in :plugins

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -0
    • +2
    ./compile/IncrementalGroovyCompileIntegrationTest.groovy
  1. … 24 more files in changeset.
Do not use deprecated configurations in tests

    • -4
    • +4
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 6 more files in changeset.
Fail on problems with incremental Groovy compilation

    • -10
    • +4
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 2 more files in changeset.
Full recompilation with annotation processor (#9917)

This fixes #9871

We don't want to support annotation processing with incremental Groovy compilation because there're too many complicated corner cases - we simply disable Groovy incremental compilation if any Java annotation processors detected.

    • -28
    • +47
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 3 more files in changeset.
Fix missing Groovy/Scala classes in runtime variant

By using the infrastructure built in `JvmPluginsHelper` we

can now make sure that the languages we support expose their

classes on the "classes" variant.

    • -8
    • +12
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 4 more files in changeset.
Add test showing consuming a Groovy library may be broken

The Java library, as well as the Java library plugins define

a "classes" variant, that is "for runtime" use. There is, currently,

no code that would explicitly require this variant. However, if, and

only if, a configuration is wired to do so, then Groovy classes

become "invisible" to the consumer.

This is similar to #7398 and #8788 but for "runtime" use. This didn't

surface as a problem because for runtime we always ask for jars, so

the test is here to prove that if we ask for a more specific variant

then we have the problem.

    • -9
    • +88
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
Fix compilation of Groovy projects depending on a library

This commit introduces a new "library elements" type corresponding

to the classes AND resources of a library. Groovy projects now tell

that they needs both the classes and resources (because the Groovy

compiler requires some descriptors).

Currently the implementation is basic as it will fallback to a jar

thanks to the attribute compatibility rules. However, it would be

better to provide a variant which actually packages only the classes

and resources as directories instead of within a jar.

Fixes #9872

    • -27
    • +12
    ./GroovyLibraryIntegrationTest.groovy
  1. … 3 more files in changeset.
Add test case for #9872

    • -0
    • +107
    ./GroovyLibraryIntegrationTest.groovy
Rename format attribute and clean up values

Attribute is now org.gradle.libraryelements and only applied

to variants having the org.gradle.category at library.

This means that values related to platforms or document in the

former format attribute are removed.

    • -1
    • +1
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 46 more files in changeset.
Extend Java library tests to cover classpath packaging mode

    • -13
    • +30
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 6 more files in changeset.
Fix problem when using the embedded ASM classes in Groovy AST transformations

The ASM classes are embedded with Groovy but relocated under the groovyjarjarasm top level package name. These classes were not explicitly allowed in the Groovy compiler class loader, where the rest of the compiler classes would be loaded, which would lead to loader constraint violations.

Issue: #5908

Signed-off-by: Bjørn Vester <bmv@netcompany.com>

    • -0
    • +13
    ./compile/GroovyCompilerIntegrationSpec.groovy
  1. … 5 more files in changeset.
Adjust tests to use 'implementation' instead of 'compile'

    • -2
    • +2
    ./environment/JreJavaHomeGroovyIntegrationTest.groovy
  1. … 5 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./compile/CachedGroovyCompileIntegrationTest.groovy
  1. … 98 more files in changeset.
Remove utilisation of *-jars usage values

    • -1
    • +2
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 55 more files in changeset.
Accept deprecation warnings in tests for compile/runtime configurations

    • -36
    • +44
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
  1. … 8 more files in changeset.
Let plugins tests not use deprecated configurations

    • -3
    • +3
    ./GroovyBasePluginIntegrationTest.groovy
    • -2
    • +2
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -3
    • +3
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -3
    • +3
    ./compile/CachedGroovyCompileIntegrationTest.groovy
    • -1
    • +1
    ./compile/daemon/GroovyCompilerDaemonReuseIntegrationTest.groovy
  1. … 32 more files in changeset.
Clean up test code

Issue #7398

    • -23
    • +0
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
Fix Groovy/Java library compatibility

This commit fixes the Groovy + Java Library compatibility,

by making sure that if, and only if, the Java Library is

applied on a project that also applies the Java Library

plugin, then the correct variants is selected.

    • -0
    • +135
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
    • -99
    • +0
    ./GroovyPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Issue 7398: groovy + java-library plugin compatibility.

Signed-off-by: James X. Nelson <James@WeTheInter.net>

    • -0
    • +99
    ./GroovyPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Polishing

    • -1
    • +0
    ./GroovyCrossCompilationIntegrationTest.groovy
  1. … 1 more file in changeset.
Only decorate compilation of JavaCompile task

Makes names clearer and reduces potential confusion.

    • -4
    • +0
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -24
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 18 more files in changeset.
Report annotation processor type in build operation result

Instead of just reporting whether an annotation processor was

incremental, we now report its type, i.e. aggregating, isolating, or

unknown.

    • -1
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 10 more files in changeset.
Report whether annotation processor is incremental

This commit adds an `incremental` property to the result of the build

operation and checks that it’s reported correctly for the different

annotation processor types.

    • -0
    • +1
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 23 more files in changeset.
Report List<AnnotationProcessorDetails> instead of Map<String, Long>

    • -1
    • +1
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -16
    • +16
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 3 more files in changeset.
Allow to detect when annotation processor info is missing

- Remove redundant task path from build operation details as it's

enclosed in an ExecuteTaskBuildOperationType operation already.

- Add coverage for forking compilation where annotation processors are

neither instrumented nor tracked.

- Use `null` to signal that no annotation processor execution times are

available.

- Extract lookup code for build operation into separate fixture class

and reuse it in all tests.

    • -0
    • +5
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -14
    • +7
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 5 more files in changeset.
Remove duplicate assertions from BasicGroovyCompilerIntegrationSpec

    • -5
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
Report annotation processor execution time

In order to track time spent by annotation processors, invocations of

compilers in `JavaCompile` and `GroovyCompile` are now wrapped in build

operations that report the execution time per fully-qualified annotation

processor class name in their result.

    • -1
    • +37
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 22 more files in changeset.
Set default value to annotationProcessorGeneratedSourcesDirectory

This also fixes the documentation for the options.annotationProcessorPath

default value.

Fixes #4956

Signed-off-by: Thomas Broyer <t.broyer@ltgt.net>

    • -14
    • +14
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 10 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

    • -0
    • +1
    ./GroovyBasePluginIntegrationTest.groovy
  1. … 61 more files in changeset.