Clone Tools
  • last updated a few seconds ago
Constraints: committers
Constraints: files
Constraints: dates
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

  1. … 407 more files in changeset.
Use the `DomainObjectCollectionFactory` everywhere

  1. … 39 more files in changeset.
Remove some direct usages of `ClassGenerator` and `DirectInstantiator` from outside of the `Instantiator` infrastructure.

  1. … 2 more files in changeset.
Decorate all domain collection container for emitting build ops (#7876)

* Update all domain object container with decorator for tracing executed callback actions

* Add decorator to a ll required occurances of DefaultDomainObjectSet

* Keep ctor for DefaultPolymorphicDomainObjectContainer as its used in gradle-idea-ext plugin

* Bring back DefaultDomainObjectSet constructor used by the android plugin

* keep backwards compatibility

  1. … 122 more files in changeset.
Separate `ITaskFactory` from `NamedEntityInstantiator<Task>` so that the instantiator is applied as a decoration over the factory.

  1. … 37 more files in changeset.
Replace internal `SourceDirectorySetFactory` with a method on public `ObjectFactory` service, to allow plugins to create instances of this type without resorting to using internal types.

  1. … 44 more files in changeset.
Revert "Flag a bunch of tests that @LeaksFileHandlers"

Now that the NativeServices initialization is fixed, these tests should

no longer leak file handles on Windows. Let's see.

This reverts commit af9d437b589adbe6688c2c7ec82eb3ba31fa5336.

  1. … 14 more files in changeset.
Flag a bunch of tests that @LeaksFileHandlers

- Now that we're correctly registering the cleanup rules, these

leaks are causing build failures on windows.

  1. … 14 more files in changeset.
Fix `PlatformBaseSpecification` so that test files are cleaned up

Fixed test fixtures to construct binary spec with correct id.

Removed concept of 'parent' for an `AbstractLanguageSourceSet`, this information is now carried in the id for the source set.

  1. … 20 more files in changeset.
Fix AbstractLanguagePluginSpec

LanguageSourceSets are now instances created by BaseInstanceFactory.

LanguageSourceSetFactory is no more.

Changed `BaseLanguageSourceSet.create()` and `BaseBinarySpec.create()` to look more like `BaseComponentSpec.create()`.

  1. … 9 more files in changeset.
Moved `ComponentSpecIdentifier` into an internal package.

  1. … 6 more files in changeset.
Moved some logic up from `BaseComponentSpec` to its super class.

  1. … 2 more files in changeset.
Replaced `ComponentSpecInternal` with a more specific internal interface that represents a component that is built into some intermediate format before its final outputs are produced.

This new interface is internal as it is essentially just a rename of `ComponentSpecInternal`, and will probably be replaced by something instead based on the target platform(s) of the component.

  1. … 17 more files in changeset.
Removed unused lvar.

Removed the notion of a language registration, as it is not required.

This was previously implied by a language source set type registration, but the definition of the language is no longer used anywhere.

This will allow the language name to be removed from the language source set type registration. It is still present, but now unused.

  1. … 4 more files in changeset.
Fixed broken unit test.

Use types in StructBindingsStore API

+review REVIEW-5761

  1. … 8 more files in changeset.
Pass struct bindings all the way

Instead of passing the delegate type in raw format, pass the struct

bindings from node initializer down to proxy generator.

+review REVIEW-5761

  1. … 25 more files in changeset.
LanguageRegistry is not needed anymore, remove it

LanguageSourceSetFactory now holds all the LanguageRegistrations.

+review REVIEW-5734

  1. … 3 more files in changeset.
Moved registration of `BinarySpec.tasks` from `BinaryBasePlugin` to `BaseBinarySpec`.

Also use the descriptor of a `BinarySpec` or `ComponentSpec` as the descriptor for its children, consistent with the approach used for the children of a struct.

  1. … 15 more files in changeset.
Fixed broken unit tests that expect the tasks for a binary to be defined.

Moved some rules from `ComponentBasePlugin` to `BinaryBasePlugin` so that it can be applied without error.

Added some unit test coverage for `BinaryBasePlugin`.

  1. … 4 more files in changeset.
Split `BinaryBasePlugin` out of `LanguageBasePlugin`.

  1. … 7 more files in changeset.
Extracted a base specification which can be used for writing software model plugin unit tests, from various existing unit tests.

  1. … 4 more files in changeset.
Manage creation of most PatternSet instances

- use managed CachingPatternSpecFactory instance for

these PatternSet instances

+review REVIEW-5627

  1. … 37 more files in changeset.
Moved a bunch of singletons off several prod classes to live on `ProjectRegistrySpec`.

+review REVIEW-5756

  1. … 30 more files in changeset.
Merge LanguageRegistry into LanguageSourceSetFactory

Introduce `LanguageRegistry getRegistrations()` in


Get rid of `languages` node and rules that used to propagate

language registrations to `LanguageSourceSetFactory`.

Along the way, `LanguageRegistration` used in `LanguageRegistry` has

been reduced to only contains necessary data.

It no longer needs the data used for factory registration.

Other changes are impacts, mostly in tests.

+review REVIEW-5734

  1. … 10 more files in changeset.