Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Correctly report everything

    • -11
    • +13
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 20 more files in changeset.
Consolidate type validation

Use ValidateContext with a few standard implementations instead of the many different interfaces and implementations we used to collect valdiation problems before. This fixes issues with types being displayed inconsistently.

The implementation is not fully correct yet: we now fail to display the correct type for problems that are bound to a type instead of a property.

    • -11
    • +1
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -9
    • +7
    ./impl/DefaultTypeAnnotationMetadata.java
    • -55
    • +45
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 42 more files in changeset.
Explicitly return no annotation metadata for primitive types, arrays and annotations

    • -0
    • +4
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Guard against null package

    • -3
    • +6
    ./impl/DefaultTypeAnnotationMetadataStore.java
Ignore supported script language base packages for property inspection

We don't want to inspect any of the types from java.*, groovy.* or kotlin.*.

    • -0
    • +17
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Rename ParameterValidationContext to WorkValidationContext

    • -2
    • +2
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -2
    • +2
    ./impl/DefaultTypeAnnotationMetadata.java
    • -2
    • +2
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 36 more files in changeset.
Merge branch 'master' into lptr/model/interface-annotations-take-precedence-over-superclass

    • -31
    • +39
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Revert "Make it a strict error if a method is both replaced and declares a type"

This reverts commit ae4f4169cb1130345dcdf78d52a0ebc3747a299c.

    • -10
    • +4
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -13
    • +5
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Make annotations inherited from interface take precedence over superclass

    • -22
    • +48
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Make it a strict error if a method is both replaced and declares a type

    • -4
    • +10
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -5
    • +13
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Do not check for conflicting annotations when there's only one

    • -9
    • +9
    ./impl/DefaultTypeAnnotationMetadataStore.java
Ignore methods annotated with ReplacedBy

    • -35
    • +44
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 11 more files in changeset.
Some more Java 8 changes

    • -1
    • +1
    ./impl/DefaultTypeAnnotationMetadata.java
  1. … 1 more file in changeset.
Rename visit{Error -> Warning} and visit{ErrorStrict -> Error}

    • -1
    • +1
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -1
    • +1
    ./impl/DefaultTypeAnnotationMetadata.java
  1. … 14 more files in changeset.
Add integration tests for validating non-getter methods

These were left off somehow.

    • -2
    • +1
    ./impl/DefaultTypeAnnotationMetadata.java
  1. … 1 more file in changeset.
Improve warning message for mutable properties

    • -1
    • +1
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Address review comments

    • -8
    • +8
    ./impl/DefaultTypeAnnotationMetadataStore.java
Document how the type annotation metadata store works

    • -11
    • +22
    ./impl/DefaultTypeAnnotationMetadataStore.java
Make the detection of Groovy-generated getters generic

We don't want DefaultTypeAnnotationMetadataStore to depend directly on Groovy. Instead, we can inject code that detects Groovy generated 'is'-getters.

    • -3
    • +6
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Make PropertyMetadata API nicer and safer to work with

    • -11
    • +14
    ./impl/DefaultPropertyAnnotationMetadata.java
  1. … 9 more files in changeset.
Handle cases when we have both 'is'-getters and 'get'-getters

Groovy generates both an 'is' and a 'get'-getter for boolean properties, and we shouldn't warn in this case. However, if the user defines both getter methods, we should require at least one of them to be explicitly ignored.

We need to figure out which method we need to call to get the value of the property. In the Groovy-generated case we can safely pick the 'get'-getter, because they both do exactly the same. In the user-specified case we need to be told which (if any) to use, as we have no means to make this decision on our own.

    • -8
    • +37
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Remove unnecessary newline

    • -1
    • +0
    ./impl/DefaultTypeAnnotationMetadataStore.java
Test warning when ignored property has other annotations

    • -1
    • +0
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Test warnings for annotated non-getter methods

    • -3
    • +0
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Handle Inject annotation on fields

Unlike other property type annotations, we allow `@Inject` to be present on fields without a getter.

    • -2
    • +6
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Make Checkstyle happy

    • -1
    • +1
    ./impl/DefaultTypeAnnotationMetadataStore.java
Fix tests

Also report type validation problems in a nicer way.

    • -48
    • +54
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Scan methods first

    • -1
    • +1
    ./impl/DefaultPropertyAnnotationMetadata.java
    • -100
    • +174
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 22 more files in changeset.