Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Capture the plugin or script where an undeclared system property read happens and include this in the problem description.

    • -2
    • +2
    ./ModelRuleValidationIntegrationTest.groovy
    • -3
    • +3
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
  1. … 39 more files in changeset.
Standardize modelRules snippet

    • -4
    • +2
    ./ModelRuleSamplesIntegrationTest.groovy
  1. … 41 more files in changeset.
Remove always-true JDK8_OR_LATER test precondition

    • -4
    • +0
    ./managed/InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 41 more files in changeset.
Software Model @UnsupportedWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./ConfigurationCycleIntegrationTest.groovy
    • -7
    • +2
    ./ModelRuleBindingFailureIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleBindingValidationIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleCachingIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleSamplesIntegrationTest.groovy
    • -0
    • +2
    ./ModelRuleValidationIntegrationTest.groovy
    • -0
    • +2
    ./MutationRuleApplicationOrderIntegrationTest.groovy
    • -2
    • +2
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
    • -4
    • +2
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -3
    • +2
    ./RuleSourceAppliedToModelMapElementIntegrationTest.groovy
    • -2
    • +2
    ./ScalarCollectionIntegrationTest.groovy
    • -2
    • +3
    ./UnmanagedElementIntegrationTest.groovy
    • -5
    • +2
    ./managed/AbstractClassBackedManagedTypeIntegrationTest.groovy
  1. … 62 more files in changeset.
Improve documented deprecation warning assertions

Allow using /current/ in the documentation path in the assertion. This will make it easier to read/verify the documentation linked to, while actually asserting against the current version behind the scenes.

    • -3
    • +4
    ./ModelRuleCachingIntegrationTest.groovy
  1. … 62 more files in changeset.
Expect deprecation warnings in tests

    • -0
    • +8
    ./ModelRuleCachingIntegrationTest.groovy
  1. … 55 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -7
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleBindingValidationIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleCachingIntegrationTest.groovy
    • -2
    • +2
    ./ModelRuleSamplesIntegrationTest.groovy
    • -2
    • +2
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
    • -4
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -3
    • +3
    ./RuleSourceAppliedToModelMapElementIntegrationTest.groovy
    • -2
    • +2
    ./ScalarCollectionIntegrationTest.groovy
    • -2
    • +2
    ./UnmanagedElementIntegrationTest.groovy
    • -5
    • +5
    ./managed/AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -3
    • +3
    ./managed/CyclicalManagedTypeIntegrationTest.groovy
    • -2
    • +2
    ./managed/EnumsInManagedModelIntegrationTest.groovy
    • -6
    • +6
    ./managed/InterfaceBackedManagedTypeIntegrationTest.groovy
    • -3
    • +3
    ./managed/InvalidManagedModelRuleIntegrationTest.groovy
  1. … 858 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after second round of CI feedback

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./managed/InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 32 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
    • -0
    • +2
    ./ModelRuleBindingValidationIntegrationTest.groovy
    • -0
    • +2
    ./ModelRuleCachingIntegrationTest.groovy
    • -0
    • +2
    ./ModelRuleSamplesIntegrationTest.groovy
    • -0
    • +2
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
    • -0
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -0
    • +3
    ./RuleSourceAppliedToModelMapElementIntegrationTest.groovy
    • -0
    • +2
    ./ScalarCollectionIntegrationTest.groovy
    • -0
    • +2
    ./UnmanagedElementIntegrationTest.groovy
    • -0
    • +5
    ./managed/AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -0
    • +3
    ./managed/CyclicalManagedTypeIntegrationTest.groovy
    • -0
    • +2
    ./managed/EnumsInManagedModelIntegrationTest.groovy
    • -0
    • +3
    ./managed/InvalidManagedModelRuleIntegrationTest.groovy
    • -0
    • +8
    ./managed/ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 12 more files in changeset.
Fix RuleSourceAppliedToModelMapElementIntegrationTest

    • -0
    • +1
    ./RuleSourceAppliedToModelMapElementIntegrationTest.groovy
Fix MutationRuleApplicationOrderIntegrationTest

    • -0
    • +1
    ./MutationRuleApplicationOrderIntegrationTest.groovy
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./managed/ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 162 more files in changeset.
Remove excluded-tests.kt

Tests excluded in excluded-tests.kt can easily be neglected. This commit moves

them to @Requires annotation on test classes.

    • -0
    • +5
    ./managed/InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 4 more files in changeset.
Make software model tasks accessible using abbreviated names again

This was broken by a refactoring towards lazy task configuration,

because we had no test coverage for this case.

    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -1
    • +1
    ./managed/ManagedModelMapIntegrationTest.groovy
  1. … 3 more files in changeset.
Change `DefaultNamedDomainObjectCollection` to better handle elements added using a provider, in particular when locating elements by name.

Change `DefaultTaskContainer` to use this to implement `createLater()` rather than the existing placeholder actions, to make deferred task creation less of a special case.

    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -1
    • +1
    ./managed/ManagedModelMapIntegrationTest.groovy
  1. … 8 more files in changeset.
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

    • -2
    • +2
    ./ModelRuleValidationIntegrationTest.groovy
    • -1
    • +1
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
  1. … 23 more files in changeset.
Fixed package cycle in integration test fixtures

    • -1
    • +1
    ./ModelRuleCachingIntegrationTest.groovy
  1. … 3 more files in changeset.
Use the correct, immutable, view for @RuleInput properties attached to a RuleSource when running a rule method from the RuleSourec.

    • -0
    • +66
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -0
    • +32
    ./managed/ModelSetIntegrationTest.groovy
  1. … 1 more file in changeset.
Added some move test coverage for mutation of subject of `@Validate` rules.

    • -0
    • +35
    ./managed/InvalidManagedModelMutationIntegrationTest.groovy
    • -1
    • +38
    ./managed/ManagedScalarCollectionsIntegrationTest.groovy
Pass an immutable (and readable) view of the subject to `@Validate` rules.

Also added a new exception type to distinguish between mutating a read only view and mutating a closed view.

    • -6
    • +6
    ./managed/InvalidManagedModelMutationIntegrationTest.groovy
    • -3
    • +75
    ./managed/ManagedModelMapIntegrationTest.groovy
    • -6
    • +6
    ./managed/ManagedScalarCollectionsIntegrationTest.groovy
    • -5
    • +5
    ./managed/ModelSetIntegrationTest.groovy
    • -2
    • +2
    ./managed/ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 11 more files in changeset.
Allow scalar collections and bridged tasks to be viewed as `ModelElement`.

    • -0
    • +90
    ./ScalarCollectionIntegrationTest.groovy
    • -0
    • +43
    ./managed/ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 6 more files in changeset.
Allow managed and unmanaged model elements to be viewed as `ModelElement`.

    • -0
    • +56
    ./UnmanagedElementIntegrationTest.groovy
    • -0
    • +38
    ./managed/InterfaceBackedManagedTypeIntegrationTest.groovy
    • -0
    • +43
    ./managed/ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
  1. … 6 more files in changeset.
Reworked display name for views of `ModelMap` and `ModelSet` (and subtypes) elements so that the same display name for a given element is used regardless of the view type.

Added some test coverage for viewing these elements as various types.

    • -1
    • +37
    ./managed/ModelSetIntegrationTest.groovy
  1. … 10 more files in changeset.
Added `ModelElement` interface, which is a view that provides some basic meta-data for a particular model element. Currently supported by `ModelMap` and `ModelSet` elements.

Also changed the generated display name for `ModelSet` views to be consistent with that provided for `ModelMap` views.

    • -3
    • +39
    ./managed/ModelSetIntegrationTest.groovy
  1. … 13 more files in changeset.
Use parameter types in method descriptor

+review REVIEW-5921

    • -6
    • +6
    ./ConfigurationCycleIntegrationTest.groovy
    • -13
    • +13
    ./ModelRuleBindingFailureIntegrationTest.groovy
    • -1
    • +1
    ./ModelRuleBindingValidationIntegrationTest.groovy
    • -3
    • +3
    ./RuleSourceAppliedAsProjectPluginIntegrationTest.groovy
    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
    • -1
    • +1
    ./RuleSourceAppliedToModelMapElementIntegrationTest.groovy
    • -8
    • +8
    ./managed/InvalidManagedModelMutationIntegrationTest.groovy
    • -5
    • +5
    ./managed/InvalidManagedModelRuleIntegrationTest.groovy
    • -5
    • +5
    ./managed/ManagedModelMapIntegrationTest.groovy
    • -2
    • +2
    ./managed/ManagedScalarCollectionsIntegrationTest.groovy
    • -8
    • +8
    ./managed/ModelSetIntegrationTest.groovy
    • -2
    • +2
    ./managed/ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 16 more files in changeset.
Fix integration test

+review REVIEW-5921

    • -2
    • +2
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Format test sources for readability

    • -378
    • +380
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Split up `ComponentModelBasePlugin` to 2 separate plugins: one which deals with the very base `ComponentSpec` type and infrastructure, and one which deals with the higher level component types such as `LibrarySpec` and `ApplicationSpec`.

  1. … 14 more files in changeset.
Ensure that the various core component types can be used to create model elements.

  1. … 4 more files in changeset.
Changed the `ModelMap` 'cannot add element of unknown type' error message to list only those known types for which it is actually possible to use to create an element.

In particular, filters those types that don't satisfy all the type constraints for the map.

This change allows a more general hierarchy to be handled by particular registry, while providing somewhat useful error messages when a more specific hierarchy is required.

    • -2
    • +131
    ./ModelMapIntegrationTest.groovy
  1. … 23 more files in changeset.