Clone Tools
  • last updated a few seconds ago
Constraints: committers
Constraints: files
Constraints: dates
Remove deprecated Jetty plugin

Issue: #735

  1. … 24 more files in changeset.
Upgrade Jetty to 6.1.26 to fix file handle leaks

Tests using both HttpServer and TestKeyStore fixtures to setup a TLS

enabled HTTP server leak file handles because Jetty is not releasing

the keystore files.

This minor Jetty version includes the proper fix:



  1. … 8 more files in changeset.
Mark classpaths as `@Classpath`

Instead of annotating with `@InputFiles` and `@OrderSensitive`, we now have only `@Classpath`.

This also enables relative path normalization for every classpath property.

+review REVIEW-6241

  1. … 31 more files in changeset.
Revert "Update Jetty version to 6.1.26"

This reverts commit 5033da1b83c4b29592f042283b0cf74dbfc8620d.

It looks like our file locking issues are still present

with Jetty 6.1.26

  1. … 4 more files in changeset.
  1. … 4 more files in changeset.
Merge branch 'release'

  1. … 2 more files in changeset.
Deprecate Jetty plugin API classes

+review REVIEW-6139

  1. … 2 more files in changeset.
Hard code Gradle version in deprecation test

Also use softer language in warning people what they should be doing.

+review REVIEW-6139

  1. … 1 more file in changeset.
Deprecate Jetty plugin

+review REVIEW-6139

  1. … 1 more file in changeset.
Mark all classpath task properties order-sensitive

All classpaths should respect file order.

+review REVIEW-6114

  1. … 25 more files in changeset.
Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

  1. … 97 more files in changeset.
Comment classloaders which are safe, close ones which leak.

  1. … 9 more files in changeset.
Comment classloaders which are safe, close ones which leak.

  1. … 9 more files in changeset.
Workaround for non-existing webXml file

+review REVIEW-5932

Fix annotations for `JettyRun.webXml`

+review REVIEW-5932

Some diagnostics to assist with flaky test analysis

Mark any un-annotated task properties with `@Internal`

+review REVIEW-5932

  1. … 32 more files in changeset.
Stop Jetty via the monitor instead of aborting the build process

+review REVIEW-5979

DefaultExecHandle propagates InterruptedException to make it abortable Do not wait for GradleProcess to end in JettyIntegrationSpec

+review REVIEW-5979

  1. … 1 more file in changeset.
Remove now unused workaround in JettyIntegrationSpec Include Contributor in release notes

Pull-request #643

Jira GRADLE-2263

+review REVIEW-5983

  1. … 1 more file in changeset.
GRADLE-2263 allow daemon instances to be shutdown. (#643)

This is a proposed fix for the issue described in:

In GRADLE-2263, a workaround is described that added to a projects build.gradle

script. This commit is a simple reordering of two statements that are described in that Jira. This

reordering of code effectively implements, for all users, the workaround described in

that Jira.

This commit simply reorders these two operations so that a monitor port is created prior to performing

the exit if daemon check.

  1. … 1 more file in changeset.
Jetty integration tests - New shot at fixing test for Daemon

+review REVIEW-5979

Jetty integration tests - Ignore test for today

+review REVIEW-5979

Jetty integration tests - Add workaround for Monitor to fix daemonIntegTest

+review REVIEW-5979

Jetty integration tests - address changes from review

+review REVIEW-5979

Integration test coverage for the jetty plugin

Replace usage of `String#format` with good old string concatenation

The rationale behind this change is that while `String#format` is usually admitted as good for readability (this is arguable),

in practice it is very bad for performance. Since Java 6, the JVM (the JIT, to be correct) does a pretty good job at optimizing

string concatenation. However, it is only capable to do so if we're using "dirty" string concatenations (using `+`), or `StringBuilder`.

However, usage of `StringBuilder` is not recommended either for 2 reasons:

1. it significantly decreases code readability

2. in Java 9, String concatenation is even more optimized thanks to `invokedynamic`, and code using `StringBuilder` will *not* benefit

from this optimization.

There are sill leftover `String#format` calls in the code, in the following cases:

- the call is used to generate an exception message. That's 90% of the remaining calls.

- the call is obviously a debug message, often used in `toString` (because as we all know, `toString` should only be used for debugging)

- the format includes specific number formatting patterns

- I missed it

  1. … 226 more files in changeset.
Fixed static fields that should be final.

This commit fixes a number of static fields that were not declared final, although never updated.

  1. … 18 more files in changeset.
Moved progress logging and styled text logging interfaces to live in their own packages.

  1. … 154 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

  1. … 417 more files in changeset.