Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add unit tests

Signed-off-by: Robert Stupp <snazy@snazy.de>

    • -0
    • +39
    ./pattern/PatternMatcherFactoryTest.java
Add unit tests

Signed-off-by: Robert Stupp <snazy@snazy.de>

    • -0
    • +39
    ./pattern/PatternMatcherFactoryTest.java
Make :files available to test workers

This means reverting to Java 6 source compatibility unfortunately.

    • -1
    • +1
    ./pattern/PatternMatcherFactoryTest.java
  1. … 4 more files in changeset.
Separated walker and snapshotter behavior for broken symlinks

    • -0
    • +27
    ./collections/DirectoryWalkerTest.groovy
  1. … 1 more file in changeset.
Do not move org.gradle.api.internal.file.pattern out of "api" package

It is used by our own build.

    • -0
    • +42
    ./pattern/FixedPatternStepTest.groovy
    • -0
    • +106
    ./pattern/FixedStepPathMatcherTest.groovy
    • -0
    • +69
    ./pattern/GreedyPathMatcherTest.groovy
    • -0
    • +70
    ./pattern/HasPrefixAndSuffixPatternStepTest.groovy
    • -0
    • +53
    ./pattern/HasPrefixPatternStepTest.groovy
    • -0
    • +49
    ./pattern/HasSuffixPatternStepTest.groovy
    • -0
    • +375
    ./pattern/PatternMatcherFactoryTest.java
    • -0
    • +182
    ./pattern/PatternStepFactoryTest.groovy
    • -0
    • +94
    ./pattern/RegExpPatternStepTest.java
  1. … 49 more files in changeset.
Revert "Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers""

This reverts commit 669ec8c0211ad7e36ec4a91921e2da5da8619bef.

    • -127
    • +0
    ./AbstractFileTreeElementTest.groovy
    • -39
    • +0
    ./DefaultFileTreeElementTest.groovy
    • -74
    • +0
    ./collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -902
    • +0
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
    • -319
    • +0
    ./collections/DefaultConfigurableFileTreeTest.groovy
    • -234
    • +0
    ./collections/DefaultFileCollectionResolveContextTest.groovy
    • -96
    • +0
    ./collections/DefaultSingletonFileTreeTest.groovy
    • -75
    • +0
    ./collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -266
    • +0
    ./collections/DirectoryFileTreeTest.groovy
    • -130
    • +0
    ./collections/DirectoryWalkerTest.groovy
    • -66
    • +0
    ./collections/FileCollectionAdapterTest.groovy
  1. … 310 more files in changeset.
Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers"

This reverts commit 72dc39d9784910196e7840ac35317bc46ef4c4a1, reversing

changes made to 69ffd7ea87b343cb6f0f03b947b7605a5bea02b1.

    • -0
    • +127
    ./AbstractFileTreeElementTest.groovy
    • -0
    • +39
    ./DefaultFileTreeElementTest.groovy
    • -0
    • +58
    ./DirectoryPropertyTest.groovy
    • -0
    • +58
    ./FilePropertyTest.groovy
    • -0
    • +72
    ./FileSystemPropertySpec.groovy
    • -0
    • +138
    ./FileSystemSubsetTest.groovy
    • -0
    • +74
    ./collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -0
    • +902
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
    • -0
    • +319
    ./collections/DefaultConfigurableFileTreeTest.groovy
    • -0
    • +234
    ./collections/DefaultFileCollectionResolveContextTest.groovy
    • -0
    • +96
    ./collections/DefaultSingletonFileTreeTest.groovy
    • -0
    • +75
    ./collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -0
    • +266
    ./collections/DirectoryFileTreeTest.groovy
    • -0
    • +130
    ./collections/DirectoryWalkerTest.groovy
    • -0
    • +66
    ./collections/FileCollectionAdapterTest.groovy
  1. … 310 more files in changeset.
Move file pattern matching to internal package without api

    • -42
    • +0
    ./pattern/FixedPatternStepTest.groovy
    • -106
    • +0
    ./pattern/FixedStepPathMatcherTest.groovy
    • -69
    • +0
    ./pattern/GreedyPathMatcherTest.groovy
    • -70
    • +0
    ./pattern/HasPrefixAndSuffixPatternStepTest.groovy
    • -53
    • +0
    ./pattern/HasPrefixPatternStepTest.groovy
    • -49
    • +0
    ./pattern/HasSuffixPatternStepTest.groovy
    • -375
    • +0
    ./pattern/PatternMatcherFactoryTest.java
    • -182
    • +0
    ./pattern/PatternStepFactoryTest.groovy
  1. … 50 more files in changeset.
Test ignoring duplicate separators

    • -0
    • +14
    ./pattern/PatternMatcherFactoryTest.java
Move PathMatcherFactoryTest to :files

    • -0
    • +361
    ./pattern/PatternMatcherFactoryTest.java
  1. … 1 more file in changeset.
Move pattern matching to :files

    • -0
    • +42
    ./pattern/FixedPatternStepTest.groovy
    • -0
    • +106
    ./pattern/FixedStepPathMatcherTest.groovy
    • -0
    • +69
    ./pattern/GreedyPathMatcherTest.groovy
    • -0
    • +70
    ./pattern/HasPrefixAndSuffixPatternStepTest.groovy
    • -0
    • +53
    ./pattern/HasPrefixPatternStepTest.groovy
    • -0
    • +49
    ./pattern/HasSuffixPatternStepTest.groovy
    • -0
    • +182
    ./pattern/PatternStepFactoryTest.groovy
  1. … 41 more files in changeset.
Rename :files project to :file-collections

    • -127
    • +0
    ./AbstractFileTreeElementTest.groovy
    • -39
    • +0
    ./DefaultFileTreeElementTest.groovy
    • -74
    • +0
    ./collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -902
    • +0
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
    • -319
    • +0
    ./collections/DefaultConfigurableFileTreeTest.groovy
    • -234
    • +0
    ./collections/DefaultFileCollectionResolveContextTest.groovy
    • -96
    • +0
    ./collections/DefaultSingletonFileTreeTest.groovy
    • -75
    • +0
    ./collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -266
    • +0
    ./collections/DirectoryFileTreeTest.groovy
    • -130
    • +0
    ./collections/DirectoryWalkerTest.groovy
    • -66
    • +0
    ./collections/FileCollectionAdapterTest.groovy
  1. … 229 more files in changeset.
Extended DirectoryFileTreeTest to exercise reproducible walker as well

    • -55
    • +65
    ./collections/DirectoryFileTreeTest.groovy
Remove some unused stuff.

    • -65
    • +0
    ./collections/DefaultFileCollectionResolveContextTest.groovy
  1. … 1 more file in changeset.
Consolidated some `FileSystemLocation` implementations and added some unit test coverage.

    • -0
    • +58
    ./DirectoryPropertyTest.groovy
    • -0
    • +58
    ./FilePropertyTest.groovy
    • -0
    • +72
    ./FileSystemPropertySpec.groovy
    • -0
    • +33
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 9 more files in changeset.
Add `FileCollection.getElements()`, which returns a view of the collection elements as a `Provider<Set<FileSystemLocation>>`. This can then be used, for example, as an input to a `Property`.

    • -6
    • +8
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 7 more files in changeset.
Add `HasConfigurableValue.disallowChanges()` which disallows changes to a `Property` or `ConfigurableFileCollection` without finalizing the value.

    • -0
    • +120
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 8 more files in changeset.
Implicitly finalize the value of task properties with type `ConfigurableFileCollection` when task execution commences, as is done for `Property` types.

    • -19
    • +266
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 14 more files in changeset.
Test fixes

    • -265
    • +0
    ./collections/DefaultDirectoryWalkerTest.groovy
    • -0
    • +75
    ./collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -0
    • +256
    ./collections/DirectoryFileTreeTest.groovy
    • -39
    • +15
    ./collections/DirectoryWalkerTest.groovy
    • -79
    • +0
    ./collections/jdk7/Jdk7UnauthorizedDirectoryWalkerTest.groovy
  1. … 2 more files in changeset.
Add missing test filesystem parameters to walkers

    • -2
    • +2
    ./collections/DirectoryWalkerTest.groovy
    • -1
    • +1
    ./collections/jdk7/Jdk7UnauthorizedDirectoryWalkerTest.groovy
  1. … 1 more file in changeset.
Rename Jdk7DirectoryWalker to DefaultDirectoryWalker

    • -14
    • +14
    ./collections/DirectoryWalkerTest.groovy
    • -2
    • +3
    ./collections/jdk7/Jdk7UnauthorizedDirectoryWalkerTest.groovy
  1. … 5 more files in changeset.
Change the implementation of `ConfigurableFileCollection.finalizeValue()` so that only the locations are finalized, not the set of files.

For example, when a collection contains a `FileTree` that is backed by a directory, then changes to the directory are reflected in the contents of the collection. In this way, a finalized file collection is basically a finalized set of file system roots, not a finalized set of files.

    • -12
    • +9
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 4 more files in changeset.
Separate out some shared behaviour from the `FileCollectionResolveContext` implementations.

Apply this shared behaviour only to those file collections that need to resolve arbitrary user provided paths, and simplify the contract for `FileCollectionResolveContext`.

    • -99
    • +0
    ./collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -6
    • +5
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
    • -173
    • +8
    ./collections/DefaultFileCollectionResolveContextTest.groovy
    • -0
    • +205
    ./collections/UnpackingVisitorTest.groovy
  1. … 16 more files in changeset.
Add `ConfigurableFileCollection.finalizeValue()` to allow the value of the file collection to be finalized.

The initial implementation is too eager, in that it calculates all of the files of the collection. Instead, it should calculate and finalize all of the roots of the collection. Later commits will improve this.

    • -45
    • +217
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 12 more files in changeset.
Inline org.gradle.testing.internal.util.Specification

    • -1
    • +1
    ./collections/DefaultConfigurableFileCollectionSpec.groovy
    • -1
    • +1
    ./collections/jdk7/Jdk7UnauthorizedDirectoryWalkerTest.groovy
  1. … 52 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./collections/GeneratedSingletonFileTreeTest.java
  1. … 162 more files in changeset.
Address review feedback

    • -4
    • +20
    ./collections/DefaultSingletonFileTreeTest.groovy
Address review feedback

    • -4
    • +20
    ./collections/DefaultSingletonFileTreeTest.groovy
Change some `FileCollection` construction in various core services to delegate to `FileCollectionFactory`. Also merge some `FileCollection` implementations that do the same thing.

    • -156
    • +1
    ./collections/ImmutableFileCollectionTest.groovy
  1. … 14 more files in changeset.
Allow converting singleton file tree to directory trees

    • -2
    • +34
    ./collections/DefaultSingletonFileTreeTest.groovy
  1. … 1 more file in changeset.