Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make checkstyle happy

Use linked list instead of array list for potentially empty and/or pattern parts

Prevent StackOverflowException caused by excessive 'or' via PatternMatcher

Signed-off-by: Robert Stupp <snazy@snazy.de>

Add missing static modifier

Make :files available to test workers

This means reverting to Java 6 source compatibility unfortunately.

    • -2
    • +5
    ./internal/file/pattern/PatternMatcherFactory.java
  1. … 3 more files in changeset.
Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'"

This reverts commit 2f79026f5e127a8175e25844522237615b19ed52 because of a performance regression,

reversing changes made to 7f1e66079ce629ecde3e09e549e9796ab85761dc.

    • -6
    • +0
    ./internal/file/FileOrUriNotationConverter.java
  1. … 90 more files in changeset.
Do not move org.gradle.api.internal.file.pattern out of "api" package

It is used by our own build.

    • -0
    • +75
    ./internal/file/pattern/FixedStepPathMatcher.java
    • -0
    • +42
    ./internal/file/pattern/HasPrefixPatternStep.java
    • -0
    • +54
    ./internal/file/pattern/HasSuffixPatternStep.java
    • -0
    • +39
    ./internal/file/pattern/PathMatcher.java
    • -0
    • +96
    ./internal/file/pattern/PatternMatcherFactory.java
    • -0
    • +20
    ./internal/file/pattern/PatternStep.java
    • -0
    • +106
    ./internal/file/pattern/PatternStepFactory.java
  1. … 43 more files in changeset.
Revert "Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers""

This reverts commit 669ec8c0211ad7e36ec4a91921e2da5da8619bef.

    • -91
    • +0
    ./internal/file/AbstractBaseDirFileResolver.java
    • -271
    • +0
    ./internal/file/AbstractFileCollection.java
    • -167
    • +0
    ./internal/file/AbstractFileResolver.java
    • -229
    • +0
    ./internal/file/AbstractFileTree.java
    • -121
    • +0
    ./internal/file/AbstractFileTreeElement.java
    • -49
    • +0
    ./internal/file/AntFileCollectionBuilder.java
    • -75
    • +0
    ./internal/file/AntFileCollectionMatchingTaskBuilder.java
    • -51
    • +0
    ./internal/file/AntFileSetBuilder.java
    • -54
    • +0
    ./internal/file/AntFileTreeBuilder.java
    • -37
    • +0
    ./internal/file/BaseDirFileResolver.java
    • -208
    • +0
    ./internal/file/CompositeFileCollection.java
    • -131
    • +0
    ./internal/file/CompositeFileTree.java
    • -39
    • +0
    ./internal/file/DefaultCompositeFileTree.java
    • -380
    • +0
    ./internal/file/DefaultFilePropertyFactory.java
    • -56
    • +0
    ./internal/file/DefaultFileSystemLocation.java
  1. … 310 more files in changeset.
Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers"

This reverts commit 72dc39d9784910196e7840ac35317bc46ef4c4a1, reversing

changes made to 69ffd7ea87b343cb6f0f03b947b7605a5bea02b1.

    • -0
    • +91
    ./internal/file/AbstractBaseDirFileResolver.java
    • -0
    • +271
    ./internal/file/AbstractFileCollection.java
    • -0
    • +167
    ./internal/file/AbstractFileResolver.java
    • -0
    • +229
    ./internal/file/AbstractFileTree.java
    • -0
    • +121
    ./internal/file/AbstractFileTreeElement.java
    • -0
    • +49
    ./internal/file/AntFileCollectionBuilder.java
    • -0
    • +75
    ./internal/file/AntFileCollectionMatchingTaskBuilder.java
    • -0
    • +51
    ./internal/file/AntFileSetBuilder.java
    • -0
    • +54
    ./internal/file/AntFileTreeBuilder.java
    • -0
    • +37
    ./internal/file/BaseDirFileResolver.java
    • -0
    • +208
    ./internal/file/CompositeFileCollection.java
    • -0
    • +131
    ./internal/file/CompositeFileTree.java
    • -0
    • +39
    ./internal/file/DefaultCompositeFileTree.java
    • -0
    • +380
    ./internal/file/DefaultFilePropertyFactory.java
    • -0
    • +56
    ./internal/file/DefaultFileSystemLocation.java
  1. … 310 more files in changeset.
Move file pattern matching to internal package without api

    • -75
    • +0
    ./internal/file/pattern/FixedStepPathMatcher.java
    • -42
    • +0
    ./internal/file/pattern/HasPrefixPatternStep.java
    • -54
    • +0
    ./internal/file/pattern/HasSuffixPatternStep.java
    • -39
    • +0
    ./internal/file/pattern/PathMatcher.java
    • -96
    • +0
    ./internal/file/pattern/PatternMatcherFactory.java
    • -20
    • +0
    ./internal/file/pattern/PatternStep.java
    • -106
    • +0
    ./internal/file/pattern/PatternStepFactory.java
  1. … 43 more files in changeset.
Move validation closer to the site of use

    • -0
    • +6
    ./internal/file/FileOrUriNotationConverter.java
  1. … 9 more files in changeset.
Omit empty strings when splitting patterns

    • -1
    • +1
    ./internal/file/pattern/PatternMatcherFactory.java
Rename isAllowed to shouldVisit in DefaultDirectoryWalker and DirectorySnapshotter

  1. … 1 more file in changeset.
Move pattern matching to :files

    • -0
    • +29
    ./internal/file/pattern/AnyWildcardPatternStep.java
    • -0
    • +44
    ./internal/file/pattern/AnythingMatcher.java
    • -0
    • +44
    ./internal/file/pattern/EndOfPathMatcher.java
    • -0
    • +40
    ./internal/file/pattern/FixedPatternStep.java
    • -0
    • +75
    ./internal/file/pattern/FixedStepPathMatcher.java
    • -0
    • +57
    ./internal/file/pattern/GreedyPathMatcher.java
    • -0
    • +37
    ./internal/file/pattern/HasPrefixAndSuffixPatternStep.java
    • -0
    • +42
    ./internal/file/pattern/HasPrefixPatternStep.java
    • -0
    • +54
    ./internal/file/pattern/HasSuffixPatternStep.java
    • -0
    • +39
    ./internal/file/pattern/PathMatcher.java
    • -0
    • +51
    ./internal/file/pattern/PatternMatcher.java
    • -0
    • +96
    ./internal/file/pattern/PatternMatcherFactory.java
    • -0
    • +20
    ./internal/file/pattern/PatternStep.java
    • -0
    • +106
    ./internal/file/pattern/PatternStepFactory.java
    • -0
    • +59
    ./internal/file/pattern/RegExpPatternStep.java
  1. … 33 more files in changeset.
Rename :files project to :file-collections

    • -91
    • +0
    ./internal/file/AbstractBaseDirFileResolver.java
    • -271
    • +0
    ./internal/file/AbstractFileCollection.java
    • -167
    • +0
    ./internal/file/AbstractFileResolver.java
    • -229
    • +0
    ./internal/file/AbstractFileTree.java
    • -121
    • +0
    ./internal/file/AbstractFileTreeElement.java
    • -49
    • +0
    ./internal/file/AntFileCollectionBuilder.java
    • -75
    • +0
    ./internal/file/AntFileCollectionMatchingTaskBuilder.java
    • -51
    • +0
    ./internal/file/AntFileSetBuilder.java
    • -54
    • +0
    ./internal/file/AntFileTreeBuilder.java
    • -37
    • +0
    ./internal/file/BaseDirFileResolver.java
    • -208
    • +0
    ./internal/file/CompositeFileCollection.java
    • -131
    • +0
    ./internal/file/CompositeFileTree.java
    • -39
    • +0
    ./internal/file/DefaultCompositeFileTree.java
    • -380
    • +0
    ./internal/file/DefaultFilePropertyFactory.java
    • -56
    • +0
    ./internal/file/DefaultFileSystemLocation.java
  1. … 229 more files in changeset.
Remove some unused stuff.

  1. … 1 more file in changeset.
Consolidated some `FileSystemLocation` implementations and added some unit test coverage.

    • -11
    • +1
    ./internal/file/AbstractFileCollection.java
    • -64
    • +7
    ./internal/file/DefaultFilePropertyFactory.java
    • -0
    • +56
    ./internal/file/DefaultFileSystemLocation.java
  1. … 10 more files in changeset.
Move some classes from `core` to `files` project.

    • -0
    • +437
    ./internal/file/DefaultFilePropertyFactory.java
    • -0
    • +26
    ./internal/file/FilePropertyFactory.java
    • -0
    • +124
    ./internal/file/ManagedFactories.java
  1. … 3 more files in changeset.
Add `Provider.orElse()` methods, to use the value of the provider or some alternative if not present.

    • -3
    • +3
    ./internal/file/AbstractFileCollection.java
  1. … 6 more files in changeset.
Inline AbstractDirectoryWalker

Make DefaultDirectoryWalker#PathVisitor static

Add `FileCollection.getElements()`, which returns a view of the collection elements as a `Provider<Set<FileSystemLocation>>`. This can then be used, for example, as an input to a `Property`.

    • -0
    • +39
    ./internal/file/AbstractFileCollection.java
  1. … 7 more files in changeset.
Javadocs.

Javadoc updates.

    • -2
    • +1
    ./internal/file/FileCollectionFactory.java
  1. … 4 more files in changeset.
Minor tweak to error message.

  1. … 1 more file in changeset.
Add `HasConfigurableValue.disallowChanges()` which disallows changes to a `Property` or `ConfigurableFileCollection` without finalizing the value.

  1. … 8 more files in changeset.
Implicitly finalize the value of task properties with type `ConfigurableFileCollection` when task execution commences, as is done for `Property` types.

  1. … 14 more files in changeset.
Provide context when a file couldn't be copied

Instead of packing everything into an exception message, use a

@Contextual exception that carries both the "can't copy" message

and the reason.

    • -5
    • +14
    ./internal/file/AbstractFileTreeElement.java
  1. … 2 more files in changeset.
Use impl type for all managed factories

  1. … 3 more files in changeset.
Use a factory id rather than the public class for identifying managed factories

  1. … 19 more files in changeset.