BaseDirFileResolverSpec.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

  1. … 407 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

  1. … 51 more files in changeset.
Merge branch 'master' into feature/JLL/depricate_http_download_dependencies

* master: (77 commits)

Realized component variants need to provide all attributes

Fix TeamCity Hygiene failures

New performance process (#10361)

Publish 5.6.1-20190825230025+0000

Publish 5.6.1-20190824230038+0000

Update .com userguide links

Update .com footer links

Update .com header links

Publish 5.6.1-20190823234015+0000

Rebase to latest 6.0 nightly

Revert "Recognize contributor"

Remove use of Java 11 API from instant execution

Recognize contributor

enhanced test source folder detection for eclipse task. (#10320)

Publish 5.6.1-20190823130927+0000

Rebase performance tests with 5.7-20190812122716+0000 baseline

Upgrade wrapper to 6.0 nightly

Rebase performance tests with 5.7-20190722220035+0000 baseline

Rebaseline to lock performance improvements

Temporarily use 5.6 as the baseline for Santa Tracker `assembleDebug` case.

...

  1. … 17 more files in changeset.
Replace `FileResolver.resolveFilesAsTree()` and `compositeFileTree()` with `FileCollectionFactory`.

  1. … 44 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

  1. … 39 more files in changeset.
Revert "Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'""

This reverts commit 0625bc7420e55e87730673231af6ad45dd04f47a.

  1. … 90 more files in changeset.
Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'"

This reverts commit 2f79026f5e127a8175e25844522237615b19ed52 because of a performance regression,

reversing changes made to 7f1e66079ce629ecde3e09e549e9796ab85761dc.

  1. … 90 more files in changeset.
Add integration tests for TextResources and remote script plugins

  1. … 6 more files in changeset.
Remove FileSystem from FileResolver

It is not used anywhere.

  1. … 14 more files in changeset.
Avoid calling File.listRoots()

This is now incredibly expensive on Windows 10,

taking up to several seconds per call.

Instead we simply check whether the scheme is an

existing folder, e.g. `C:`

  1. … 1 more file in changeset.
Ignore test if platform is incompatible

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>

Fix failing test on Windows

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>

Use immutable file collections whenever possible (#5797)

- Stop DefaultProject implementing FileOperations/ProcessOperations

- Stop BasicScript implementing FileOperations/ProcessOperations

- FileResovler.resolveUri() is not nullable

  1. … 38 more files in changeset.
Make file normalization cheaper

On case-insensitive file systems we were trying to

normalize the case of files passed to the file resolver.

The exact reasons for this are lost to history, but it

can't have been correctness, since for correctness one

would have to look at canonical files.

This significantly reduces configuration time on case

insensitive file systems, since we no longer hit the file

system, but only work on the path string. This is in line

with `java.nio.Path.normalize`, which we should use instead

once we drop Java 6 support.

  1. … 7 more files in changeset.
Changed `Directory` and `RegularFile` so that they do not extend `Provider<File>` as these types represent some immutable location, rather than some calculated value.

Also added `FileSystemLocation` as a common supertype for these types to allow a consumer to declare that they accept a directory or a file or any file system element.

  1. … 14 more files in changeset.
Fixed `Project.file()` and `Project.files()` to properly handle `Directory` and `RegularFile`. Also fixed `Project.files()` when presented a `Path` instance. Added some test coverage and updated the Javadocs on `Project`.

  1. … 6 more files in changeset.
Added methods to `Directory` to resolve String and calculated paths to regular files and directories, relative to the directory.

  1. … 12 more files in changeset.
Project.file now supports java.nio.file.Path instances.

  1. … 3 more files in changeset.
Fix review items for handling @Optional outputs

- Use isOptional vs getOptional

- Use a common implementation of unpack()

+review REVIEW-6326

  1. … 9 more files in changeset.
Support @Optional @OutputFile properties with task caching

- improve logging messages with task validators

+review REVIEW-6326

  1. … 10 more files in changeset.
Cache optional task output files correctly

Previously we didn't handle `@Optional` task outputs when it came to task output caching. There were two problems:

* we threw a NPE when trying to pack or unpack such a property

* we ignored whether or not a property was actually specified or not when generating the cache key

Now the NPE is fixed, and the cache key includes the sorted list of the names of every output property that has a file or directory associated with it.

+review REVIEW-6326

  1. … 9 more files in changeset.
Manage creation of most PatternSet instances

- use managed CachingPatternSpecFactory instance for

these PatternSet instances

+review REVIEW-5627

  1. … 37 more files in changeset.
Merge pull request #430 from LarryNorth/master

BaseDirFileResolverSpec Incorrectly Assumes That File System Root Q:\ Is Non-Existent

Changing NativeServicesTestFixture to use test directory instead of tmp

+review REVIEW-5378

  1. … 9 more files in changeset.
Revert "Changing NativeServicesTestFixture to use test directory instead of tmp"

This reverts commit af97d6bb0d18cb329a9b7c79406d48d3ffe6e9cb.

+review REVIEW-5378

  1. … 8 more files in changeset.
Changing NativeServicesTestFixture to use test directory instead of tmp

+review REVIEW-5378

  1. … 8 more files in changeset.
In BaseDirFileResolverSpec, eliminate the assumption in test "normalizes non-existent file system root" that file system root Q:\ is non-existent.

Attach some examples to various notation format descriptions.

  1. … 19 more files in changeset.
Changed FileOrUriNotationParser so that it uses the standard error handling.

  1. … 8 more files in changeset.
Fixed unit tests on windows.

  1. … 1 more file in changeset.