Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix mapping the contents of a `FileTree` that contains a file (rather than a directory) as a root to an Ant `FileSet`.

This fixes the Checkstyle task when source files are added directly to the task sources.

    • -392
    • +0
    ./AbstractFileCollectionTest.groovy
    • -338
    • +0
    ./CompositeFileCollectionSpec.groovy
    • -203
    • +0
    ./CompositeFileCollectionTest.groovy
  1. … 12 more files in changeset.
Do not write the source paths for a `CopySpec` multiple times to the instant execution cache.

Previously, these were written once when the `CopySpec` was serialized and once when the associated input property spec was serialized.

This commit adds some special case handling for this case. It also preserves the identity of each `FileTree` and `FileCollection` instance for each task to enable short circuiting when the same file collections are referenced via multiple paths, such as in the `CopySpec` case.

    • -1
    • +2
    ./DefaultSourceDirectorySetTest.groovy
  1. … 41 more files in changeset.
Track the source paths for a `CopySpec` in a `ConfigurableFileCollection` rather than a `Set<Object>`.

This will allow instant execution serialization to better deal with serializing these paths.

  1. … 2 more files in changeset.
Report the chain of properties from which a mapped `Provider` has come from, when the value is missing.

    • -34
    • +13
    ./DefaultProjectLayoutTest.groovy
  1. … 31 more files in changeset.
Fix the `jar` task with instant execution when the classes output directory does not exist when writing the instant execution cache.

More generally, do not ignore input directories for archive tasks which did not exist when the instant execution cache was written.

    • -5
    • +16
    ./CompositeFileCollectionTest.groovy
  1. … 8 more files in changeset.
Allow SourceDirectorySet.compiledBy() to be called multiple times

    • -0
    • +31
    ./DefaultSourceDirectorySetTest.groovy
  1. … 1 more file in changeset.
Add properties on `Report` and subtypes to allow wiring using `Providers`. Specifically, add `Report.activated` to replace `enabled` and `outputLocation` to replace destination.

Change the Java base plugin to use these properties instead of convention mapping to attach conventions for the test report locations.

  1. … 25 more files in changeset.
Avoid deprecated APIs

    • -0
    • +12
    ./copy/PathNotationConverterTest.groovy
  1. … 3 more files in changeset.
Add configDirectory to Checkstyle

- Deprecate configDir

- Replace configDir with configDirectory

  1. … 9 more files in changeset.
Fix failing tests from insecure HTTP deprecation changes

  1. … 15 more files in changeset.
Merge branch 'master' into feature/JLL/depricate_http_download_dependencies

* master: (77 commits)

Realized component variants need to provide all attributes

Fix TeamCity Hygiene failures

New performance process (#10361)

Publish 5.6.1-20190825230025+0000

Publish 5.6.1-20190824230038+0000

Update .com userguide links

Update .com footer links

Update .com header links

Publish 5.6.1-20190823234015+0000

Rebase to latest 6.0 nightly

Revert "Recognize contributor"

Remove use of Java 11 API from instant execution

Recognize contributor

enhanced test source folder detection for eclipse task. (#10320)

Publish 5.6.1-20190823130927+0000

Rebase performance tests with 5.7-20190812122716+0000 baseline

Upgrade wrapper to 6.0 nightly

Rebase performance tests with 5.7-20190722220035+0000 baseline

Rebaseline to lock performance improvements

Temporarily use 5.6 as the baseline for Santa Tracker `assembleDebug` case.

...

    • -24
    • +16
    ./DefaultFileOperationsTest.groovy
  1. … 16 more files in changeset.
Generate a basic display name for `Property` instances created as the value for a read-only managed property. Use the display name in 'this property has no value' error messages to help with problem diagnosis.

The display name could include some more context, could be used in more error messages, and be applied to more things. This commit is simply an incremental improvement and later changes will improve diagnostics further.

  1. … 25 more files in changeset.
Refactor HTTP deprecation logic to use HttpRedirectVerifier

  1. … 60 more files in changeset.
Replace `FileResolver.resolveFilesAsTree()` and `compositeFileTree()` with `FileCollectionFactory`.

    • -16
    • +11
    ./DefaultFileOperationsTest.groovy
  1. … 40 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

    • -10
    • +9
    ./DefaultSourceDirectorySetTest.groovy
    • -21
    • +20
    ./copy/DefaultCopySpecResolutionTest.groovy
    • -5
    • +2
    ./copy/SyncCopyActionDecoratorTest.groovy
  1. … 34 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -3
    • +2
    ./CachingTaskInputFileCollectionTest.groovy
    • -1
    • +2
    ./DefaultSourceDirectorySetTest.groovy
  1. … 34 more files in changeset.
Replace some direct instantiation of `FileResolver` instances with a service.

    • -307
    • +0
    ./DefaultFileCollectionFactoryTest.groovy
  1. … 24 more files in changeset.
Use Deleter to remove files in Sync task

    • -1
    • +8
    ./copy/SyncCopyActionDecoratorTest.groovy
  1. … 4 more files in changeset.
Move unit tests to where they belong

    • -423
    • +0
    ./DefaultProjectLayoutTest.groovy
  1. … 1 more file in changeset.
Create Deleter as a service

  1. … 11 more files in changeset.
Move Deleter to :files

    • -129
    • +0
    ./delete/AbstractSymlinkDeleterTest.groovy
    • -41
    • +0
    ./delete/UnixDerivativeSymlinkDeleterTest.groovy
    • -42
    • +0
    ./delete/WindowsHardLinkDeleterTest.groovy
    • -41
    • +0
    ./delete/WindowsJunctionDeleterTest.groovy
    • -41
    • +0
    ./delete/WindowsSymbolicLinkDeleterTest.groovy
  1. … 11 more files in changeset.
Move resolving files to delete to DefaultFileOperations

    • -17
    • +9
    ./delete/AbstractSymlinkDeleterTest.groovy
  1. … 2 more files in changeset.
Test the non-resolving interface

Resolving is tested in DefaultFileOperationsTest already.

  1. … 1 more file in changeset.
Dissect Deleter, part 3

Peel away Clock again.

    • -1
    • +1
    ./delete/AbstractSymlinkDeleterTest.groovy
  1. … 3 more files in changeset.
Throw simple RuntimeException instead of custom one

  1. … 2 more files in changeset.
Move determining need for GC on failed delete outside of Deleter

    • -1
    • +1
    ./delete/AbstractSymlinkDeleterTest.groovy
  1. … 3 more files in changeset.
Simplify Deleter API

We don't need to use WorkResult here.

    • -4
    • +4
    ./delete/AbstractSymlinkDeleterTest.groovy
  1. … 4 more files in changeset.
Polish DeleterTest

Rename file collection visitor type and visit method.

    • -6
    • +6
    ./DefaultFileCollectionFactoryTest.groovy
  1. … 30 more files in changeset.
Some refactoring of file collection visitor.

  1. … 18 more files in changeset.