Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Model the output directory for source files generated by annotation processors as a `DirectoryProperty` and replace the convention mapping with a convention on the property.

This change means that JavaCompile tasks added by the Java base plugin for a source set will be up-to-date on first load from the instant execution cache, and will generate source files to the correct location when they do happen to run.

    • -2
    • +1
    ./testing/IncrementalTestIntegrationTest.groovy
  1. … 25 more files in changeset.
Fix Unrolled tests with partial success with instant execution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./testing/TestingIntegrationTest.groovy
  1. … 18 more files in changeset.
Improve documented deprecation warning assertions

Allow using /current/ in the documentation path in the assertion. This will make it easier to read/verify the documentation linked to, while actually asserting against the current version behind the scenes.

    • -5
    • +6
    ./jvm/plugins/JUnitTestSuitePluginGoodBehaviourTest.groovy
    • -5
    • +8
    ./jvm/test/AbstractJUnitTestExecutionIntegrationSpec.groovy
    • -5
    • +8
    ./jvm/test/JUnitTestSuiteComponentReportIntegrationTest.groovy
  1. … 60 more files in changeset.
Re-annotate some tests still leaking file handles

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./testing/testng/SampleTestNGIntegrationTest.groovy
  1. … 10 more files in changeset.
De-skip tests that don't leak files anymore

but still fail with instant execution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./testing/testng/SampleTestNGIntegrationTest.groovy
  1. … 18 more files in changeset.
Run more JVM testing coverage

only TestNG tests are causing very long timeouts

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -6
    • +24
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
Rename @ToBeFixedForInstantExecution.value to skip for explicitness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -6
    • +6
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -2
    • +2
    ./testing/testng/SampleTestNGIntegrationTest.groovy
    • -1
    • +1
    ./testing/testng/TestNGFailFastIntegrationTest.groovy
  1. … 34 more files in changeset.
Go over all @ToBeFixedForInstantExecution(Skip.FAILS_IN_SUBCLASS) cases

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -12
    • +12
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
  1. … 14 more files in changeset.
Add test for the exclude filter fix for JUnitPlatform

    • -0
    • +29
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
Expect deprecation warnings in tests

    • -0
    • +7
    ./jvm/plugins/JUnitTestSuitePluginGoodBehaviourTest.groovy
    • -0
    • +12
    ./jvm/test/AbstractJUnitTestExecutionIntegrationSpec.groovy
    • -0
    • +5
    ./jvm/test/JUnitComponentUnderTestIntegrationTest.groovy
    • -0
    • +5
    ./jvm/test/JUnitIncrementalTestExecutionTest.groovy
    • -0
    • +1
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
    • -0
    • +5
    ./jvm/test/JUnitTestSuiteComponentReportIntegrationTest.groovy
  1. … 50 more files in changeset.
Skip tests that fail to cleanup test files with instant execution

after another round of ci feedback

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./testing/testng/SampleTestNGIntegrationTest.groovy
  1. … 1 more file in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -9
    • +9
    ./jvm/test/JUnitComponentUnderTestIntegrationTest.groovy
    • -5
    • +5
    ./jvm/test/JUnitIncrementalTestExecutionTest.groovy
    • -13
    • +13
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
    • -3
    • +3
    ./testing/IncrementalTestIntegrationTest.groovy
    • -2
    • +2
    ./testing/TestOutputListenerIntegrationTest.groovy
    • -7
    • +7
    ./testing/TestReportIntegrationTest.groovy
    • -2
    • +2
    ./testing/TestTaskIntegrationTest.groovy
    • -2
    • +2
    ./testing/TestTaskJvmArgsProviderIntegrationTest.groovy
    • -3
    • +3
    ./testing/TestingIntegrationTest.groovy
    • -7
    • +7
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -12
    • +12
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
    • -2
    • +2
    ./testing/junit/JUnitCategoriesIntegrationSpec.groovy
    • -2
    • +2
    ./testing/junit/RerunPreviousFailedTestIntegrationTest.groovy
    • -3
    • +3
    ./testing/testng/SampleTestNGIntegrationTest.groovy
  1. … 858 more files in changeset.
Move skip reasons to @FailsWithInstantExecution and drop @IgnoreWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +7
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -12
    • +12
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
    • -2
    • +2
    ./testing/testng/TestNGFailFastIntegrationTest.groovy
  1. … 43 more files in changeset.
Annotate integ tests failing with instant execution in various projects

removing most of @IgnoreWithInstantExecution annotations

after fixing the @FailsWithInstantExecution rule

and more ci feedback

also make @IgnoreWithInstantExecution require a reason from a fixed set

and add it to the remaining ignores

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +1
    ./testing/TestingIntegrationTest.groovy
    • -7
    • +0
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -11
    • +11
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
    • -10
    • +10
    ./testing/testng/TestNGFailFastIntegrationTest.groovy
  1. … 123 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
  1. … 36 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after second round of CI feedback

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
  1. … 31 more files in changeset.
Fix TestNGStaticLoggingIntegrationTest

IntelliJ automatically removed an *used* import

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./testing/testng/TestNGStaticLoggingIntegrationTest.groovy
Annotate integ tests failing with instant execution in :testingJvm

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +9
    ./jvm/test/JUnitComponentUnderTestIntegrationTest.groovy
    • -0
    • +6
    ./jvm/test/JUnitIncrementalTestExecutionTest.groovy
    • -0
    • +13
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
    • -0
    • +3
    ./testing/IncrementalTestIntegrationTest.groovy
    • -0
    • +2
    ./testing/TestOutputListenerIntegrationTest.groovy
    • -0
    • +7
    ./testing/TestReportIntegrationTest.groovy
    • -0
    • +2
    ./testing/TestTaskIntegrationTest.groovy
    • -0
    • +2
    ./testing/TestTaskJvmArgsProviderIntegrationTest.groovy
    • -0
    • +4
    ./testing/TestingIntegrationTest.groovy
    • -0
    • +7
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -0
    • +12
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
    • -0
    • +2
    ./testing/junit/JUnitCategoriesIntegrationSpec.groovy
    • -0
    • +2
    ./testing/junit/RerunPreviousFailedTestIntegrationTest.groovy
    • -0
    • +3
    ./testing/testng/SampleTestNGIntegrationTest.groovy
  1. … 20 more files in changeset.
Include output of all failed suites in HTML report (#11262)

Prior to this commit, only the output of the root `TestDescriptor` was

included in the HTML report even though all failed suites were included

with their exceptions.

    • -1
    • +39
    ./testing/TestReportIntegrationTest.groovy
  1. … 8 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -1
    • +1
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -3
    • +6
    ./testing/junit/JUnitConsoleLoggingIntegrationTest.groovy
    • -0
    • +101
    ./testing/junitplatform/JUnitPlatformLoggingIntegrationTest.groovy
  1. … 3 more files in changeset.
Fix executing Specs tests via JUnit Platform and Vintage engine

Prior to this commit, the JUnitPlatformTestExecutionListener parsed the

unique ID to determine the class and method name for TestIdentifiers

without children but with a ClassSource. This occurs when a Spock test

class uses `@Unroll` on all its test methods. However, other testing

frameworks such as Specs2 don't provide a unique ID that is parseable

which lead to the methodName being null which cause a failure during

serialization. The effect was that tests hung because the build VM

was waiting for the worker to finish the tests it started.

The Spock-specific workaround in our listener is now replaced with a

more robust one that always uses the methodName provided by the JUnit

Platform instead of parsing it.

    • -0
    • +69
    ./testing/junit/Specs2IntegrationTest.groovy
  1. … 1 more file in changeset.
Remove an unnecessary `@IgnoreIf` from a bunch of tests.

    • -8
    • +0
    ./testing/TestReportIntegrationTest.groovy
    • -3
    • +0
    ./testing/TestingIntegrationTest.groovy
    • -3
    • +0
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
  1. … 16 more files in changeset.
Removed `ExecutionResult.executedTasks` and `skippedTasks` properties. Tests should use the assertion methods instead.

    • -3
    • +3
    ./testing/fixture/AbstractTestFilteringIntegrationTest.groovy
  1. … 5 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -12
    • +12
    ./testing/TestReportIntegrationTest.groovy
    • -4
    • +4
    ./testing/TestingIntegrationTest.groovy
    • -1
    • +1
    ./testing/junit/JUnitCategoriesIntegrationSpec.groovy
  1. … 95 more files in changeset.
Let testing-jvm tests not use deprecated configurations

    • -1
    • +1
    ./testing/IncrementalTestIntegrationTest.groovy
    • -4
    • +4
    ./testing/ParallelTestExecutionIntegrationTest.groovy
    • -1
    • +1
    ./testing/SuiteTimestampIntegrationTest.groovy
    • -4
    • +4
    ./testing/TestOutputListenerIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestProgressLoggingIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestReportIntegrationTest.groovy
    • -5
    • +5
    ./testing/TestTaskIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestTaskJdkRelocationIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestTaskJvmArgsProviderIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestTaskRelocationIntegrationTest.groovy
    • -13
    • +13
    ./testing/TestingIntegrationTest.groovy
    • -1
    • +1
    ./testing/fixture/JvmBlockingTestClassGenerator.groovy
    • -1
    • +1
    ./testing/fixture/TestNGCoverage.groovy
    • -5
    • +5
    ./testing/junit/BuildSrcSpockIntegrationTest.groovy
    • -1
    • +1
    ./testing/junit/JUnit3FilteringIntegrationTest.groovy
  1. … 62 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -2
    • +2
    ./jvm/test/JUnitStandaloneTestExecutionIntegrationTest.groovy
    • -1
    • +1
    ./testing/TestReportIntegrationTest.groovy
    • -5
    • +5
    ./testing/TestingIntegrationTest.groovy
    • -4
    • +4
    ./testing/fixture/AbstractJvmFailFastIntegrationSpec.groovy
    • -1
    • +1
    ./testing/junit/JUnitCategoriesIntegrationSpec.groovy
    • -1
    • +1
    ./testing/junit/JUnitConsoleLoggingIntegrationTest.groovy
    • -2
    • +2
    ./testing/junit/JUnitLoggingOutputCaptureIntegrationTest.groovy
    • -1
    • +1
    ./testing/junit/JUnitSmokeMultiVersionIntegrationSpec.groovy
    • -2
    • +2
    ./testing/junit/RerunPreviousFailedTestIntegrationTest.groovy
    • -3
    • +3
    ./testing/junitplatform/JUnitPlatformUserGuideIntegrationTest.groovy
    • -2
    • +2
    ./testing/testng/TestNGFailFastIntegrationTest.groovy
    • -1
    • +1
    ./testing/testng/TestNGLoggingOutputCaptureIntegrationTest.groovy
  1. … 148 more files in changeset.
Revert "Run tests against JUnit 4.13-beta-2"

This reverts commit 05d0a7b3b44f29d01fac4a160e23999858c04851.

    • -7
    • +6
    ./testing/fixture/JUnitCoverage.groovy
Fix filtering parameterized tests by category

Prior to this commit methods in parameterized test classes were not

checked for `@Category` annotations.

Resolves #8424.

    • -9
    • +16
    ./testing/junit/JUnitCategoriesCoverageIntegrationSpec.groovy
  1. … 4 more files in changeset.
Run tests against JUnit 4.13-beta-2

    • -6
    • +7
    ./testing/fixture/JUnitCoverage.groovy
Fix handling of aborted containers with completed children

When a container `TestIdentifier` was reported as finished, we reported

all of its children as skipped, regardless whether they already had been

completed previously. Now, we only report unstarted children as skipped.

Resolves #8685.

    • -2
    • +2
    ./testing/fixture/JUnitCoverage.groovy
    • -0
    • +53
    ./testing/junit/JUnitAbortedTestClassIntegrationTest.groovy
  1. … 3 more files in changeset.