Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Document reason for @ToBeFixedForInstantExecution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
Fix PropertyIntegrationTest for the configuration cache

by using a system property provider in the build under test

Signed-off-by: Paul Merlin <paul@gradle.com>

Correctly serialize a `Property` instance with finalize on read enabled and whose value is derived from a task output.

  1. … 3 more files in changeset.
Work around a race condition in `DefaultConfiguration` that is exposed when visiting the task dependencies of a `Configuration` while also visiting the files of the same `Configuration` instance.

This does not fix the race condition, but simply makes it less likely to have an effect. The underlying issue can be fixed later.

  1. … 1 more file in changeset.
Work around an issue where a `Property` instance may have multiple threads attempting to finalize its value.

This does not fix the issue, which is that multiple threads can use the property instance at the same time. For model objects such as `Property` instances only a single thread should use the instance at any given time.

  1. … 2 more files in changeset.
Add additional assertions in interoperability tests for org.gradle.api.provider.Property

Signed-off-by: Gregor Dschung <gregor@chkpnt.de>

    • -0
    • +3
    ./AbstractPropertyGroovyInterOpIntegrationTest.groovy
    • -0
    • +3
    ./AbstractPropertyJavaInterOpIntegrationTest.groovy
    • -0
    • +3
    ./AbstractPropertyKotlinInterOpIntegrationTest.groovy
    • -0
    • +13
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
    • -0
    • +3
    ./ManagedPropertyGroovyInterOpIntegrationTest.groovy
    • -0
    • +4
    ./ManagedPropertyJavaInterOpIntegrationTest.groovy
    • -0
    • +3
    ./ManagedPropertyKotlinInterOpIntegrationTest.groovy
    • -0
    • +4
    ./PropertyGroovyInterOpIntegrationTest.groovy
    • -0
    • +8
    ./PropertyJavaInterOpIntegrationTest.groovy
    • -0
    • +3
    ./PropertyKotlinInterOpIntegrationTest.groovy
When a strict `Property` is read, finalize all properties whose values are used to calculate the property's final value.

    • -0
    • +57
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 42 more files in changeset.
Add some context to exceptions that are thrown when querying the value of a `Property` instance, if diagnostic information is available for the property.

    • -0
    • +69
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 4 more files in changeset.
When a property instance is strict, apply the query constraints to `finalizeValue()` (which is a kind of query).

    • -148
    • +186
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 6 more files in changeset.
Disallow reading the value of a task output `Property` that is strict before the producing task has started execution.

    • -3
    • +3
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 27 more files in changeset.
Add `HasConfigurableValue.disallowUnsafeRead()` back onto public API.

Change the semantics so that the value cannot be read until after completion of project configuration, rather than prior to the start of `afterEvaluate()`

    • -19
    • +36
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 7 more files in changeset.
Remove `@ToBeFixedForInstantExecution` from `AbstractPropertyLanguageInterOpIntegrationTest`

    • -1
    • +4
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
Restore `@ToBeFixedForInstantExecution` for `PropertyKotlinInterOpIntegrationTest`

And `ManagedPropertyKotlinInterOpIntegrationTest`.

    • -0
    • +6
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
Remove `@ToBeFixedForInstantExecution` from `AbstractPropertyLanguageInterOpIntegrationTest`

    • -1
    • +0
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
Remove `@ToBeFixedForInstantExecution` from `ProviderIntegrationTest`

Add `@ToBeFixedForInstantExecution` to some new test cases.

    • -0
    • +5
    ./AbstractNestedBeanLanguageInterOpIntegrationTest.groovy
    • -4
    • +8
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
  1. … 1 more file in changeset.
Remove always-true KOTLIN_SCRIPT test precondition

    • -3
    • +0
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
    • -3
    • +0
    ./PropertyKotlinInterOpIntegrationTest.groovy
  1. … 42 more files in changeset.
Add test coverage to verify the various managed things work well when defined in/used from Java, Groovy and Kotlin.

    • -0
    • +58
    ./AbstractNestedBeanJavaInterOpIntegrationTest.groovy
    • -0
    • +39
    ./AbstractNestedBeanLanguageInterOpIntegrationTest.groovy
    • -0
    • +110
    ./AbstractPropertyGroovyInterOpIntegrationTest.groovy
    • -0
    • +132
    ./AbstractPropertyJavaInterOpIntegrationTest.groovy
    • -0
    • +105
    ./AbstractPropertyKotlinInterOpIntegrationTest.groovy
    • -32
    • +18
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
    • -0
    • +41
    ./ManagedNestedBeanJavaInterOpIntegrationTest.groovy
    • -0
    • +57
    ./ManagedPropertyGroovyInterOpIntegrationTest.groovy
    • -0
    • +61
    ./ManagedPropertyJavaInterOpIntegrationTest.groovy
    • -0
    • +59
    ./ManagedPropertyKotlinInterOpIntegrationTest.groovy
    • -0
    • +76
    ./NestedBeanGroovyInterOpIntegrationTest.groovy
    • -0
    • +55
    ./NestedBeanJavaInterOpIntegrationTest.groovy
    • -0
    • +69
    ./NestedBeanKotlinInterOpIntegrationTest.groovy
    • -92
    • +6
    ./PropertyGroovyInterOpIntegrationTest.groovy
    • -115
    • +7
    ./PropertyJavaInterOpIntegrationTest.groovy
  1. … 10 more files in changeset.
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 49 more files in changeset.
Merge branch 'release' into vv/groovy-2-5-10

# Conflicts:

# gradle/dependencies.gradle

    • -154
    • +0
    ./PropertyIntegrationTest.groovy
  1. … 2 more files in changeset.
Upgrade Groovy dependency to version 2.5.10

  1. … 6 more files in changeset.
Implement `disallowUnsafeReads()` for `ConfigurableFileCollection` implementations.

    • -7
    • +5
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 23 more files in changeset.
Implicitly finalize a strict property on read, when read is allowed.

    • -2
    • +46
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 2 more files in changeset.
Add `HasConfigurableValue.disallowUnsafeRead()` to allow plugins to switch lazy instances to 'strict' behaviour wrt reads.

In this commit, a strict `Property` disallows reads until the owning project's `afterEvaluate` starts. This is not implemented for `FileCollection` yet.

    • -0
    • +39
    ./PropertyLifecycleIntegrationTest.groovy
  1. … 35 more files in changeset.
Split up an integration test class.

    • -154
    • +0
    ./PropertyIntegrationTest.groovy
    • -0
    • +175
    ./PropertyLifecycleIntegrationTest.groovy
Fix MapPropertyIntegrationTest

Signed-off-by: Paul Merlin <paul@gradle.com>

Fix scripts under test that were using project.xxx during execution

where .xxx is simply handled by capturing just that.

for example, project.name, project.version or project.objects etc...

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 5 more files in changeset.
@ToBeFixedForInstantExecution(because = "Kotlin Gradle Plugin")

Kotlin 1.3.61 still reaches out to the project in task actions

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +17
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
  1. … 4 more files in changeset.
Disable stacktrace checking for PropertyKotlinInterOpIntegrationTest

This closes https://github.com/gradle/build-tool-flaky-tests/issues/76

It's not Gradle's fault for these stacktraces. Disable them.

    • -0
    • +1
    ./PropertyKotlinInterOpIntegrationTest.groovy
Report the chain of properties from which the value of a `ListProperty`, `SetProperty` and `MapProperty` come from, when the value is missing.

    • -10
    • +36
    ./CollectionPropertyIntegrationTest.groovy
    • -42
    • +67
    ./MapPropertyIntegrationTest.groovy
  1. … 19 more files in changeset.