Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Temporarily ignore tests that fail on Windows 10"

This reverts commit a14990b5

Move FilePathUtil and DefaultFileHierarchySet to `:files`

    • -0
    • +237
    ./main/java/org/gradle/internal/file/DefaultFileHierarchySet.java
    • -0
    • +33
    ./main/java/org/gradle/internal/file/FileHierarchySet.java
    • -0
    • +76
    ./main/java/org/gradle/internal/file/FilePathUtil.java
    • -0
    • +41
    ./test/groovy/org/gradle/internal/file/FilePathUtilTest.groovy
  1. … 12 more files in changeset.
Move NonNullApi annotation to :pineapple project

Retire NonNullInternalApi annotation in favor of NonNullApi.

  1. … 16 more files in changeset.
Move TreeType to :files

    • -0
    • +25
    ./main/java/org/gradle/internal/file/TreeType.java
  1. … 1 more file in changeset.
Temporarily ignore tests that fail on Windows 10

Recreate symlinked target directory as actual directory

    • -3
    • +5
    ./main/java/org/gradle/internal/file/Deleter.java
Do not follow symlinks when removing work outputs

    • -0
    • +36
    ./main/java/org/gradle/internal/file/Deleter.java
  1. … 16 more files in changeset.
Make checkstyle happy

Use linked list instead of array list for potentially empty and/or pattern parts

Add unit tests

Signed-off-by: Robert Stupp <snazy@snazy.de>

Add unit tests

Signed-off-by: Robert Stupp <snazy@snazy.de>

Prevent StackOverflowException caused by excessive 'or' via PatternMatcher

Signed-off-by: Robert Stupp <snazy@snazy.de>

Prevent StackOverflowException caused by excessive 'or' via PatternMatcher

Signed-off-by: Robert Stupp <snazy@snazy.de>

Drop tryDelete()

    • -11
    • +3
    ./main/java/org/gradle/internal/file/Deleter.java
  1. … 2 more files in changeset.
Make Deleter.delete() throw IOException

There's also tryDelete() now, but it should probably go away, too.

    • -1
    • +10
    ./main/java/org/gradle/internal/file/Deleter.java
Move Deleter interface out of impl package

    • -0
    • +71
    ./main/java/org/gradle/internal/file/Deleter.java
  1. … 39 more files in changeset.
Fix cleaning linked directory

Create directory when none existed

Introduce ensureEmptyDirectory() instead of cleanRecursively()

  1. … 7 more files in changeset.
Introduce Deleter.clean() to clean directory contents

  1. … 1 more file in changeset.
Use old java.io API instead of java.nio.file

This is because on Java 8 there is a bug that destroys performance. See https://bugs.openjdk.java.net/browse/JDK-8154077.

Address review comments

Use java.nio.Files to delete files

This should give us more information about what goes wrong when it does.

Throw IOException and expose simple delete() method on Deleter

This is the prime usage for IOException, so let's use it. Also expose another method that tries to delete a single file.

  1. … 3 more files in changeset.
Simplify Deleter API even more

  1. … 3 more files in changeset.
Create Deleter as a service

  1. … 11 more files in changeset.
Simpler API for Deleter

  1. … 1 more file in changeset.
Introduce interface for Deleter

    • -0
    • +24
    ./main/java/org/gradle/internal/file/impl/Deleter.java
  1. … 1 more file in changeset.
Move Deleter to :files

  1. … 10 more files in changeset.
Move DefaultFileMetadata to impl package

    • -0
    • +19
    ./main/java/org/gradle/internal/file/impl/package-info.java
  1. … 10 more files in changeset.