Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename method.

  1. … 7 more files in changeset.
Add `HasConfigurableValue.finalizeOnRead()` which allows a plugin to request that the value of a property or file collection become final the next time the value is queried, if not already final.

    • -0
    • +247
    ./internal/file/collections/DefaultConfigurableFileCollectionSpec.groovy
  1. … 4 more files in changeset.
Fail rather than emitting a deprecation warning when the value of a `Property` typed task property is changed after the task starts execution.

Also include the property display name, if attached, in the 'cannot change the value' error messages.

    • -5
    • +5
    ./internal/file/DefaultFilePropertyFactoryTest.groovy
  1. … 25 more files in changeset.
Allow resolving fixed file collections from a Directory or DirectoryProperty

just like a Directory or Directory property can be seen as a fixed FileTree

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +29
    ./internal/file/DirectoryPropertyTest.groovy
  1. … 3 more files in changeset.
Fix test

    • -1
    • +1
    ./internal/file/DefaultFilePropertyFactoryTest.groovy
Fix resolving `DirectoryTee` elements of a `FileCollection`.

  1. … 3 more files in changeset.
Replace `FileResolver.resolveFilesAsTree()` and `compositeFileTree()` with `FileCollectionFactory`.

    • -1
    • +3
    ./internal/file/DefaultFileCollectionFactoryTest.groovy
    • -1
    • +1
    ./internal/file/DirectoryPropertyTest.groovy
    • -1
    • +2
    ./internal/file/FileSystemPropertySpec.groovy
  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

  1. … 41 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -3
    • +3
    ./internal/file/DefaultFileCollectionFactoryTest.groovy
  1. … 38 more files in changeset.
Replace some direct instantiation of `FileResolver` instances with a service.

    • -0
    • +307
    ./internal/file/DefaultFileCollectionFactoryTest.groovy
  1. … 24 more files in changeset.
Add methods to allow a `Property<FileSystemLocation>` value to be set using a `Provider<File>`, to match the methods that allow the value to be set using a `File`.

    • -1
    • +32
    ./internal/file/FileSystemPropertySpec.groovy
  1. … 8 more files in changeset.
Move unit tests to where they belong

    • -0
    • +318
    ./internal/file/DefaultFilePropertyFactoryTest.groovy
  1. … 1 more file in changeset.
Rename file collection visitor type and visit method.

  1. … 33 more files in changeset.
Some refactoring of file collection visitor.

  1. … 19 more files in changeset.
Change file collection `visitLeafCollections()` so that visitor receives a 'source' object, instead of an enum, in order to make the decision whether to visit a child collection or not.

Use this in dependency resolution to remove some special-casing for local dependency files.

  1. … 31 more files in changeset.
Rework visiting a `Configuration` so that its contents are treated as a sequence of collections, rather than a single monolithic collection of files. This will allow visitors such as continuous build or instant execution some finer-grained visibility into the contents of the `Configuration`.

In this commit, the collections do not carry any useful information and the granularity is per artifact, which is too fine-grained. Later commits will address this.

  1. … 27 more files in changeset.
Merge `FileCollection.registerWatchPoints()` into `visitLeafCollections()`, so that a visitor can optionally receive the 'spec' or definition for each participant in a file collection.

This will also later be used by instant execution to serialize some file collection participants as files and some as definitions.

  1. … 19 more files in changeset.
Treat the artifacts produced for a local file dependency and those produced for other kinds of dependencies more similarly, when visiting the result.

Specifically, merge `ArtifactVisitor.visitFile()` into `ArtifactVisitor.visitArtifact()`, so that now all files/artifacts that participate in the resolution result are represented as a `ResolvableArtifact`.

  1. … 34 more files in changeset.
Allow a `FileCollection` visitor to skip visiting the output of artifact transforms, and use this when serializing file collections to the instant execution cache.

This is only intended to be a basic step towards allow visitors better control over what to visit and in what form to visit. In this step, the API is specific to artifact transforms but will be made more general in later changes.

  1. … 22 more files in changeset.
Change `FileCollection` implementations so that they all expose their task dependencies via `TaskDependencyContainer` rather than a mix of `Buildable` and `TaskDependencyContainer`.

  1. … 14 more files in changeset.
Refine the API for visiting the leaves of a FileCollection, so that a visitor does not have to recreate a FileTree from its root directory and set of patterns, but can instead use the original instance.

  1. … 8 more files in changeset.
Change confusing broken symlink error message thrown during file visits

  1. … 4 more files in changeset.
Merge remote-tracking branch 'origin/master' into lorinc/9575/copy-to-unreadable-output

    • -0
    • +157
    ./internal/file/collections/DirectoryWalkerTest.groovy
  1. … 3 more files in changeset.
Revert "Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers""

This reverts commit 669ec8c0211ad7e36ec4a91921e2da5da8619bef.

    • -0
    • +127
    ./internal/file/AbstractFileTreeElementTest.groovy
    • -0
    • +39
    ./internal/file/DefaultFileTreeElementTest.groovy
    • -0
    • +58
    ./internal/file/DirectoryPropertyTest.groovy
    • -0
    • +58
    ./internal/file/FilePropertyTest.groovy
    • -0
    • +72
    ./internal/file/FileSystemPropertySpec.groovy
    • -0
    • +138
    ./internal/file/FileSystemSubsetTest.groovy
    • -0
    • +74
    ./internal/file/collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -0
    • +902
    ./internal/file/collections/DefaultConfigurableFileCollectionSpec.groovy
    • -0
    • +319
    ./internal/file/collections/DefaultConfigurableFileTreeTest.groovy
    • -0
    • +234
    ./internal/file/collections/DefaultFileCollectionResolveContextTest.groovy
    • -0
    • +96
    ./internal/file/collections/DefaultSingletonFileTreeTest.groovy
    • -0
    • +75
    ./internal/file/collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -0
    • +266
    ./internal/file/collections/DirectoryFileTreeTest.groovy
    • -0
    • +130
    ./internal/file/collections/DirectoryWalkerTest.groovy
    • -0
    • +66
    ./internal/file/collections/FileCollectionAdapterTest.groovy
  1. … 310 more files in changeset.
Revert "Merge pull request #9840 from gradle/lptr/files/simplify-file-matchers"

This reverts commit 72dc39d9784910196e7840ac35317bc46ef4c4a1, reversing

changes made to 69ffd7ea87b343cb6f0f03b947b7605a5bea02b1.

    • -127
    • +0
    ./internal/file/AbstractFileTreeElementTest.groovy
    • -39
    • +0
    ./internal/file/DefaultFileTreeElementTest.groovy
    • -58
    • +0
    ./internal/file/DirectoryPropertyTest.groovy
    • -58
    • +0
    ./internal/file/FilePropertyTest.groovy
    • -72
    • +0
    ./internal/file/FileSystemPropertySpec.groovy
    • -138
    • +0
    ./internal/file/FileSystemSubsetTest.groovy
    • -74
    • +0
    ./internal/file/collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -902
    • +0
    ./internal/file/collections/DefaultConfigurableFileCollectionSpec.groovy
    • -234
    • +0
    ./internal/file/collections/DefaultFileCollectionResolveContextTest.groovy
  1. … 310 more files in changeset.
Move Stat and Chmod to :files

    • -1
    • +1
    ./internal/file/AbstractFileTreeElementTest.groovy
    • -2
    • +2
    ./internal/file/DefaultFileTreeElementTest.groovy
  1. … 37 more files in changeset.
Rename :files project to :file-collections

    • -0
    • +127
    ./internal/file/AbstractFileTreeElementTest.groovy
    • -0
    • +39
    ./internal/file/DefaultFileTreeElementTest.groovy
    • -0
    • +58
    ./internal/file/DirectoryPropertyTest.groovy
    • -0
    • +58
    ./internal/file/FilePropertyTest.groovy
    • -0
    • +72
    ./internal/file/FileSystemPropertySpec.groovy
    • -0
    • +138
    ./internal/file/FileSystemSubsetTest.groovy
    • -0
    • +74
    ./internal/file/collections/BuildDependenciesOnlyFileCollectionResolveContextTest.groovy
    • -0
    • +902
    ./internal/file/collections/DefaultConfigurableFileCollectionSpec.groovy
    • -0
    • +319
    ./internal/file/collections/DefaultConfigurableFileTreeTest.groovy
    • -0
    • +234
    ./internal/file/collections/DefaultFileCollectionResolveContextTest.groovy
    • -0
    • +96
    ./internal/file/collections/DefaultSingletonFileTreeTest.groovy
    • -0
    • +75
    ./internal/file/collections/DefaultUnauthorizedDirectoryWalkerTest.groovy
    • -0
    • +266
    ./internal/file/collections/DirectoryFileTreeTest.groovy
    • -0
    • +130
    ./internal/file/collections/DirectoryWalkerTest.groovy
    • -0
    • +66
    ./internal/file/collections/FileCollectionAdapterTest.groovy
  1. … 229 more files in changeset.