advanced

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Split samples and snippets

    • -1
    • +0
    ./app/assets/coffeescript/console.coffee
    • -7
    • +0
    ./app/assets/coffeescript/squareit.coffee
    • -18
    • +0
    ./app/controllers/Application.scala
    • -30
    • +0
    ./app/controllers/hello/HelloController.java
  1. … 7724 more files in changeset.
Fixed JS repository in sample

Convert user manual to be generated by Asciidoctor only

This change replaces all embedded Docbook syntax from the user manual.

Asciidoctor files are now converted directly to HTML and PDF.

It not only greatly simplifies the user manual generation pipeline, but also it makes it faster.

I did the following for all user manual pages:

- [x] Adjusted links to other manual pages, DSL docs, and Javadocs where necessary.

Fixed a couple dozen broken links at least.

- [x] Convert samples XML from docbook to asciidoctor syntax

- [x] Converted wide tables to a more flexible list-based display

Important contributor differences from now on:

- Users must use a `<file>.adoc#` prefix for all cross-reference links.

This is _required_ to achieve working links in all 3 outputs: multi-page user manual, single-page user manual, and PDF.

- The manual PDF is no longer themed, and no longer has the list of examples links in the TOC.

- File names were changed from camelCased to snake_case to have a crystal clear 1-1 mapping between source to output.

- Section reference verification is now handled by Asciidoctor verbose mode.

- The single-page user manual has the same navigation as the multi-page manual for now.

- [Common Asciidoctor extensions](https://github.com/gradle/dotorg-docs/tree/master/docs-asciidoctor-extensions) are now used by Gradle Guides and the User Manual, however, the the web assets (CSS, JS, etc) are not yet merged.

These extensions are responsible for injecting the navigation and styles.

The header/footer/navigation HTML can now be found under `subprojects/docs/src/main/resources`.

  1. … 401 more files in changeset.
Re-enable Play/Scala tests on Java 9+ (#5593)

Almost all Play/Scala tests were ignored on Java 9/10, which makes it lack coverage. This PR does:

- Update Scala version to Java9-compatible version according to [JDK compatibility](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html).

- Update default Play version to latest 2.6.15, which supports Java 9/10

- Adjust corresponding samples. Previous default Play version 2.3.10 was too old (release at 2014).

- Ignored the tests which can't work on Java 9+.

- Separate Play test resources with different versions. For example, Play 2.6 uses `build.gradle` and `Play 2.4/2.5` uses `build.gradle.old`.

- Previously `AbstractMultiVersionPlayContinuousBuildIntegrationTest` didn't have `targetPlatform` configuration, which made multi-version tests meaningless

- Fix `play-logback` configuration for `2.5.18`.

  1. … 165 more files in changeset.
Externalize samples testing infrastructure

This change replaces UserGuideSamplesRunner with an external library

called sample-check. Sample discovery, execution, and normalization

is delegated to this library, with some custom normalizers remaining

in the Gradle codebase.

Samples output has become co-located with the sample code. Samples tests

must be run with Java 8+.

    • -0
    • +2
    ./specifyPlayVersion.sample.conf
  1. … 782 more files in changeset.
Sample projects should provide root project name as best practice (#3730)

  1. … 240 more files in changeset.
Remove usage of --no-search-upwards and deprecate

  1. … 256 more files in changeset.
Use Java 8 required by Play 2.5

Use Java 8 required by Play 2.5

Updated advanced code sample

    • -2
    • +2
    ./app/controllers/hello/HelloController.java
Updated advanced code sample

    • -2
    • +2
    ./app/controllers/hello/HelloController.java
Update sample to use 2.5 instead of 2.3

Update sample to use 2.5 instead of 2.3

Replace Typesafe references with Lightbend

  1. … 11 more files in changeset.
Replace Typesafe references with Lightbend

  1. … 11 more files in changeset.
Simplify Play apps to not rely on templates provided by Play

- Different Play versions have different templates

- We only need to show a simple message

  1. … 12 more files in changeset.
Fleshing out Play user guide samples

+review REVIEW-5535

  1. … 14 more files in changeset.
Remove trailing slash to Typesafe ivy's repo url

+review REVIEW-5535

  1. … 18 more files in changeset.
More samples for Play applications

+review REVIEW-5535

  1. … 42 more files in changeset.
Fix Play components sample

+review REVIEW-5535

  1. … 3 more files in changeset.
use separate assets classloader that loads assets from files - use play.runsupport.AssetsClassLoader from Play's run-support library - requires Play >= 2.3.7 - run-support depends on sbt io library that is only available in Typesafe's ivy repository

+review REVIEW-5521

  1. … 26 more files in changeset.
Include a 3rd-party dependency in the Play ‘advanced’ sample

    • -2
    • +3
    ./app/controllers/hello/HelloController.java
  1. … 1 more file in changeset.
Improving the play advanced sample to be more interesting

    • -3
    • +1
    ./app/assets/coffeescript/console.coffee
    • -0
    • +7
    ./app/assets/coffeescript/squareit.coffee
    • -0
    • +34
    ./app/controllers/QuestionsThreeController.scala
    • -0
    • +7
    ./app/models/Person.scala
    • -0
    • +9
    ./app/views/fields.scala.html
    • -0
    • +13
    ./app/views/pass.scala.html
    • -0
    • +29
    ./app/views/person.scala.html
    • -0
    • +39
    ./app/views/square.scala.html
    • -0
    • +4
    ./public/javascripts/jquery-2.1.3.min.js
    • -0
    • +9
    ./public/stylesheets/bootstrap.min.css
  1. … 1 more file in changeset.
Allow the Scala platform version to be specified for a Play application

- Custom PlayPlatformRequirement is handled by PlayPlatformResolver

- PlayApplicationSpec.platform() uses a notation parser to convert map to requirement

  1. … 12 more files in changeset.
Changing the play samples and test fixtures to not define routes for controllers in the same package across multiple routes files.

+review REVIEW-5272

    • -29
    • +0
    ./app/controllers/HelloController.java
    • -0
    • +29
    ./app/controllers/hello/HelloController.java
  1. … 11 more files in changeset.
Changing play samples to use 'play' plugin instead of 'play-application'

  1. … 1 more file in changeset.
Fixing advanced play sample to reflect changes to coffeescript plugin not importing javascript plugin by default.

Adding integration tests to check that play samples are actually usable.

+review REVIEW-5272

    • -0
    • +3
    ./app/assets/coffeescript/console.coffee
    • -0
    • +9
    ./app/assets/javascripts/sample.js
    • -0
    • +12
    ./app/controllers/Application.scala
    • -0
    • +29
    ./app/controllers/HelloController.java
    • -0
    • +7
    ./app/views/index.scala.html
    • -0
    • +32
    ./app/views/main.scala.html
    • -0
    • +62
    ./conf/application.conf
    • binary
    ./public/images/favicon.png
    • -0
    • +3
    ./public/javascripts/hello.js
    • -0
    • +0
    ./public/stylesheets/main.css
    • -0
    • +30
    ./test/ApplicationSpec.scala
    • -0
    • +24
    ./test/IntegrationSpec.scala
  1. … 23 more files in changeset.