Clone
Cédric Champeau
committed
on 24 Mar 17
Fix concurrency bug in `HttpClientHelper`
The HTTP context should not be shared by several requests, or it just breaks when requests are don… Show more
Fix concurrency bug in `HttpClientHelper`

The HTTP context should not be shared by several requests, or it just breaks when requests are done in parallel.

This explains the failures seen with `NTLM` authentication, but not only: there were more failures with `BASIC`

authentication too (and probably random other failures).

This commit changes the `HttpContext` so that we create a new one per request, in case we don't use authentication,

and if we do, then requests cannot be done in parallel (until we find a proper fix). This removes the special case in

`HttpAuthenticationDependencyResolutionIntegrationTest`.

Show less

master + 522 more