main

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecation removal of Gradle GUI (#1749)

Remove Gradle GUI code, leftovers Open API code and user guides.

    • -217
    • +0
    ./java/org/gradle/foundation/ProjectView.java
    • -94
    • +0
    ./java/org/gradle/foundation/TaskView.java
    • -163
    • +0
    ./java/org/gradle/foundation/common/ObserverLord.java
  1. … 177 more files in changeset.
Fix checkstyle warnings for new checkstyle version

    • -165
    • +163
    ./java/org/gradle/foundation/common/ObserverLord.java
  1. … 13 more files in changeset.
Remove redundant conditional

Remove redundant modifiers

Changed `ExecHandleBuilder` into an interface and moved from 'core' to 'process' project.

  1. … 22 more files in changeset.
Moved classes out of o.g.internal.logging.internal to remove this package.

  1. … 80 more files in changeset.
Moved logging configuration classes referenced from `StartParameter` into a public package.

  1. … 26 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

  1. … 409 more files in changeset.
Introduce installation beacon and refactor representation of Gradle installation

- Installation discovery by finding JAR in lib directory

- Minor improvements

+review REVIEW-5867

  1. … 47 more files in changeset.
`coll.toArray(new T[coll.size()])` => `coll.toArray(new T[0])`

> Bottom line: toArray(new T[0]) seems faster, safer, and contractually cleaner, and therefore should be the default choice now. Future VM optimizations may close this performance gap for toArray(new T[size]), rendering the current "believed to be optimal" usages on par with an actually optimal one. Further improvements in toArray APIs would follow the same logic as toArray(new T[0]) — the collection itself should create the appropriate storage.

http://shipilev.net/blog/2016/arrays-wisdom-ancients/

Let's see what our performance tests say, if this is noticeable at all.

Changes made by IDEA "Structural Replace":

$coll$.toArray(new $T$[$coll$.size()])

=>

$coll$.toArray(new $T$[0])

+review REVIEW

  1. … 37 more files in changeset.
Separation of concerns: Externalize logic on how to find distribution.

+review REVIEW-5533

  1. … 12 more files in changeset.
Initialize the native services in the UI integration tests, not in the UI bits themselves.

+review REVIEW-5378

  1. … 5 more files in changeset.
Cleanup of NativeServices testing changes - Changed use of NativeServicesTestFixture to annotation in many cases - Centralized temp dir creation logic - Enhanced uninitialized NativeServices error message

+review REVIEW-5378

  1. … 41 more files in changeset.
Made SystemProperties class a singleton instead of just having static fields and methods. Doing so is also going to allow us to push synchronization logic into this class e.g. for creating instances through a factory with a provided java home system property.

+review REVIEW-5397

  1. … 51 more files in changeset.
Require NativeServices to be initialized prior to use

+review REVIEW-5378

  1. … 40 more files in changeset.
Changed the GUI to use ProjectTaskLister to determine the tasks of the project.

  1. … 6 more files in changeset.
Change: Correct some misspelling and duplicate words

  1. … 22 more files in changeset.
Convert HelpTasksPlugin to Java and delete ImplicitTasksConfigurer, moving the constants it housed to better homes.

+review

  1. … 9 more files in changeset.
Removed some deprecated methods from Project and Test.

    • -17
    • +0
    ./java/org/gradle/foundation/ProjectView.java
  1. … 24 more files in changeset.
Cleaned up some unused stuff.

  1. … 2 more files in changeset.
Typos.

Changed gui executor so that it does not sit in a tight loop when something goes wrong popping next request off queue.

Removed unused field.

Simplified gui startup.

Removed dual pane ui implementation as it is no longer used.

  1. … 3 more files in changeset.
Removed open api implementations from ui.

Removed GradleRunner as it is no longer used by anything.

  1. … 1 more file in changeset.
Assert that we have a gradle home when launching stuff from the gui.

Chagned gui client so that it does not throw away failures trying to connect to gui server.

Removed GradleRunnerFactory from openApi.

  1. … 3 more files in changeset.