Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove 'compare-gradle-builds' plugin from distribution (#10198)

* Remove non-public ProjectOutcomes model type

* Remove 'compare-gradle-builds' plugin from distribution

    • -2
    • +0
    ./CancellableConsumerConnectionTest.groovy
    • -2
    • +0
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -2
    • +0
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 138 more files in changeset.
Remove non-public ProjectOutcomes model type

    • -2
    • +0
    ./CancellableConsumerConnectionTest.groovy
    • -2
    • +0
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -2
    • +0
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 7 more files in changeset.
Remove non-public ProjectOutcomes model type

    • -2
    • +0
    ./CancellableConsumerConnectionTest.groovy
    • -2
    • +0
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -2
    • +0
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 7 more files in changeset.
Inline org.gradle.testing.internal.util.Specification

  1. … 53 more files in changeset.
Inline org.gradle.testing.internal.util.Specification

  1. … 53 more files in changeset.
Inline org.gradle.testing.internal.util.Specification

  1. … 52 more files in changeset.
Inline org.gradle.testing.internal.util.Specification

  1. … 53 more files in changeset.
spelling: parameterized

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

  1. … 14 more files in changeset.
spelling: environment

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Bo Zhang <bo@gradle.com>

    • -1
    • +1
    ./UnsupportedOlderVersionConnectionTest.groovy
Add some context to the exception thrown by the TAPI when the daemon is force killed on cancellation.

Remove some consumer side assumptions about the implementation of the producer, which were present as a work around to produce the correct exception in the consumer when the daemon is force killed by the producer and for very old producer versions.

    • -1
    • +2
    ./PluginClasspathInjectionSupportedCheckModelProducerTest.groovy
  1. … 11 more files in changeset.
Remove dead code from the TAPI

    • -78
    • +0
    ./ModelBuilderBackedModelProducerTest.groovy
  1. … 22 more files in changeset.
Remove support for connecting to Gradle <2.6

    • -148
    • +0
    ./ActionAwareConsumerConnectionTest.groovy
    • -154
    • +0
    ./BuildActionRunnerBackedConsumerConnectionTest.groovy
    • -3
    • +0
    ./CancellableConsumerConnectionTest.groovy
    • -84
    • +0
    ./GradleBuildAdapterProducerTest.groovy
    • -144
    • +0
    ./ModelBuilderBackedConsumerConnectionTest.groovy
    • -90
    • +0
    ./NonCancellableConsumerConnectionAdapterTest.groovy
    • -1
    • +0
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -1
    • +0
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 140 more files in changeset.
Remove public PhasedBuildActionExecutor type

The type behaves just like a regular build action

except that it can hook into different phases of

the build.

    • -3
    • +3
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 18 more files in changeset.
Remove projectsEvaluated hook from PhasedActions

And modify projectsLoaded hook to be run after configuration, making

sure that requested models are available.

For now, projects are configurated completely before running the

projectsLoaded action, however we can try to avoid unnecessary

configuration in the future without modifying public APIs.

Signed-off-by: Lucas Smaira <lsmaira@google.com>

    • -22
    • +2
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 19 more files in changeset.
Use umodifiable list in DefaultClassPath

This makes accidental mutation impossible and reduces some

of the repeated wrapping.

    • -1
    • +1
    ./PluginClasspathInjectionSupportedCheckModelProducerTest.groovy
  1. … 37 more files in changeset.
Change target version from 4.7 to 4.8

Changing all uses of 4.7 in documentation and code.

Signed-off-by: Lucas Smaira <lsmaira@google.com>

    • -1
    • +1
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -1
    • +1
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 33 more files in changeset.
Code and documentation ajustments to PR

This commit:

- Renames methods in PhasedBuildActionExecuter and corresponding uses

- Improves public java docs making them more precise

- Replaces mocks by stubs in unit tests when possible

- Makes action's handlers in phased actions not receiving failures (they

are send to build results)

Signed-off-by: Lucas Smaira <lsmaira@google.com>

    • -1
    • +1
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -82
    • +39
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 37 more files in changeset.
Introduce support for running phased actions

This commit introduces the ability of running multiple build actions in

different phases of the build. These actions are passed by the client

through the tooling api.

With this commit, a single action can be added to each one of the

supporting phases (after projects are loaded, after projects are

evaluated and after tasks are run).

This feature allows improvements like running actions that call a model

builder modifying the graph tasks, and then it is possible to first

fetch a model and then execute tasks, in this order. e.g. Android Studio

sync + source generation.

Signed-off-by: Lucas Smaira <lsmaira@google.com>

    • -0
    • +16
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -0
    • +235
    ./PhasedActionAwareConsumerConnectionTest.groovy
  1. … 53 more files in changeset.
Improve error messages for ToolingParameterProxy

ToolingParameterProxy#isValid is replaced by #validateParameter which instead

of returning a boolean indicating if the given Class<?> is a valid parameter

type, it throws an error with a precise description message if not valid.

    • -12
    • +51
    ./ToolingParameterProxyTest.groovy
  1. … 2 more files in changeset.
Fix test expectation

Improve error messages in BuildControllerAdapter

    • -6
    • +25
    ./BuildControllerAdapterTest.groovy
    • -118
    • +0
    ./ParameterInstantiatorBeanProxyTest.groovy
    • -0
    • +118
    ./ToolingParameterProxyTest.groovy
  1. … 5 more files in changeset.
Simplify handling of versions not supporting parameters

    • -0
    • +59
    ./BuildControllerWithoutParameterSupportTest.groovy
    • -80
    • +0
    ./ParameterValidatingControllerTest.groovy
  1. … 4 more files in changeset.
Change version of parameterized models to 4.4

This commit modifies all the java docs and concerned files in previous

commits in this pull request.

    • -1
    • +1
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -2
    • +2
    ./ParameterValidatingControllerTest.groovy
  1. … 31 more files in changeset.
Parameter connection related code simplification

Renamings and code simplifications suggested in the pull request.

No functionality changed.

    • -1
    • +2
    ./CancellableModelBuilderBackedModelProducerTest.groovy
    • -0
    • +147
    ./ParameterAcceptingConsumerConnectionTest.groovy
    • -147
    • +0
    ./ParameterCancellableConsumerConnectionTest.groovy
  1. … 14 more files in changeset.
Change version of parameterized models to 4.3

This commit modifies all the java docs and concerned files in previous

commits.

    • -1
    • +1
    ./ParameterCancellableConsumerConnectionTest.groovy
    • -2
    • +2
    ./ParameterValidatingControllerTest.groovy
  1. … 31 more files in changeset.
Code clean up for parameterized models

Refactorings and code clean up folloiwing commit "Introduce creation of

parameterized tooling models"

    • -9
    • +73
    ./BuildControllerAdapterTest.groovy
    • -80
    • +0
    ./BuildParameterCheckerControllerTest.groovy
    • -2
    • +1
    ./CancellableModelBuilderBackedModelProducerTest.groovy
    • -255
    • +0
    ./ParameterBuildControllerAdapterTest.groovy
    • -0
    • +118
    ./ParameterInstantiatorBeanProxyTest.groovy
    • -0
    • +80
    ./ParameterValidatingControllerTest.groovy
  1. … 21 more files in changeset.
Introduce creation of parameterized tooling models

This commit introduces the possibility of passing parameters through the

Tooling API to the model builders in order to create models based on

information received by the client.

This feature allows plugins to register a model builder for a given

model and parameter and then build models based on the received

parameter. It is preferable to passing gradle properties for two

reasons: first convenience and second because parameters can be created

inside the BuildAction.

A new interface ToolingParameterizedModelBuilder was created and should

be extended by parameterized builders. New methods were added to the

BuildController in order to build models with parameters. In order to

keep cross version compatibility, new protocol interfaces were created.

    • -0
    • +80
    ./BuildParameterCheckerControllerTest.groovy
    • -0
    • +255
    ./ParameterBuildControllerAdapterTest.groovy
    • -0
    • +147
    ./ParameterCancellableConsumerConnectionTest.groovy
  1. … 36 more files in changeset.
Generate start and finish events for Gradle distribution download done by the TAPI.

Also moved responsibility for creating the downloader down closer to where the download happens, and inject only the listeners that are interested in the events.

    • -4
    • +4
    ./LazyConsumerActionExecutorTest.groovy
  1. … 16 more files in changeset.
tooling: report gradle wrapper download progress

    • -3
    • +10
    ./LazyConsumerActionExecutorTest.groovy
    • -0
    • +3
    ./ProgressLoggingConsumerActionExecutorTest.groovy
  1. … 67 more files in changeset.
Add project/build identifiers to all core models

This avoids the need for compatibility mapping on the client.

Having project and build information on all models is also a prerequisite

to make build actions in composite builds work. The build controller takes

a 'target' argument and from that argument we need to be able to infer which

build and project it belongs to.

    • -1
    • +1
    ./CancellableModelBuilderBackedModelProducerTest.groovy
    • -1
    • +2
    ./GradleBuildAdapterProducerTest.groovy
    • -1
    • +1
    ./ModelBuilderBackedModelProducerTest.groovy
  1. … 54 more files in changeset.