ContinuousBuildCancellationCrossVersionSpec.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Split TAPI tests to dedicated source sets

    • -130
    • +0
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 346 more files in changeset.
Attempt to address flakiness in continuous build tests

The `ContinuousBuildCancellationCrossVersionSpec` is flaky, and it

appears that this is largely due to the Tooling client shutting down

during the build. This change forces the test client to wait for a

"Build cancelled." message before closing the TAPI client.

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 1 more file in changeset.
Remove use of tooling-api version to determine behavior of test

+review REVIEW-5816

    • -12
    • +34
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
Replace usage of GradleVersion with VersionNumber

- GradleVersion class has classloader issues within

ToolingApiCompatibilitySuiteRunner classloading

- perhaps because GradleDistribution references GradleVersion

and GradleDistribution gets loaded from outside the TAPI

classloader

+review REVIEW-5816

    • -2
    • +2
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 2 more files in changeset.
CI fix - Wait for cancel to be processed before continuing build

This is the same thing that the CancellationCrossVersionSpec tests do

+review REVIEW-5767

    • -5
    • +15
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
Attempt to fix flaky test

- give time for cancellation to get delivered

    • -0
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
When running on windows, instruct to use ctrl-d + enter to cancel the build.

I couldn't find anyway to defeat cmd.exe buffering. There are some anecdotes of this being possible with JLine (and of course direct native calls), but nothing feasible to use at this time.

+review

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 6 more files in changeset.
Some tooling api continuous build test coverage tweaks: use a model that is actually built inside the build, added some coverage for unsupported target Gradle version.

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 4 more files in changeset.
Exception upon cancellation is different with Gradle 2.1.

+review REVIEW-5509

    • -1
    • +7
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
Polishing of tooling api continuous build tests.

+review REVIEW-5509

    • -206
    • +35
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 8 more files in changeset.
Test continuous build cancellation from Tooling API with all versions that support cancellation.

+review REVIEW-5509

    • -3
    • +8
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 1 more file in changeset.
improve continuous build cancellation tests covers: - if cancellation happens during the build, we don't wait for changes - if cancellation happens while waiting for changes, we exit

+review REVIEW-5509

    • -2
    • +5
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
add continuous build cancellation tests - after cancelling a continuous build, we can subsequently run another - should cancel in a “watch period” that is non initial

+review REVIEW-5509

    • -0
    • +73
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
use CyclicBarrierHttpServer in testing cancellation

+review REVIEW-5509

    • -48
    • +80
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
s/continuous mode/continuous build/

+review REVIEW-5509

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 2 more files in changeset.
adjust testing delays in continuous build tooling api cancel

+review REVIEW-5509

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
use 'GradleConnector.newCancellationTokenSource()' - instead of 'new DefaultCancellationTokenSource()'

+review REVIEW-5509

    • -2
    • +2
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 1 more file in changeset.
Mostly cosmetic changes to continuous build tooling API integ tests.

- Removed some unnecessary syntax

- Corrected the test matrix boundaries

- Changed < Java 7 test to be agnostic to test VM

- Some tweaks to type support for Tooling API fixtures

- Some constants for gradle/tooling API version strings to make why certain versions are used clearer

+review REVIEW-5509

    • -75
    • +49
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 9 more files in changeset.
refactor tests

+review REVIEW-5509

    • -1
    • +1
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 2 more files in changeset.
Use the term “continuous build” consistently.

    • -0
    • +175
    ./ContinuousBuildCancellationCrossVersionSpec.groovy
  1. … 22 more files in changeset.