JUnitPlatformLoggingIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 36 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 38 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 37 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 37 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after third round of CI feedback

much better, no more OOMEs, no more hung builds, no more console

replacement weirdness

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +0
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 37 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after second round of CI feedback

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 32 more files in changeset.
Adopt tests to new behavior

    • -26
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 1 more file in changeset.
Adopt tests to new behavior

    • -26
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 1 more file in changeset.
Adopt tests to new behavior

    • -26
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 1 more file in changeset.
Revert "Fix edge case for class display names"

This reverts commit e04ef3476cd3927bb972a60e7184332d6e29876c.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Revert "Fix edge case for class display names"

This reverts commit e04ef3476cd3927bb972a60e7184332d6e29876c.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Revert "Fix edge case for class display names"

This reverts commit e04ef3476cd3927bb972a60e7184332d6e29876c.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix edge case for class display names

Simply using the class display name in test logging does not work,

because JUnit platform returns only the simple class name from

TestIdentifier.getDisplayName(). This results in the fully qualified

package name being cut off for top level classes.

This change adds some logic that tried to find out whether the display

name has been explicitly se tor not. If so then the class display name

will we use. If not the fully qualified class name will be used for top

level classes and the simple class name will be used for inner classes.

There is still one corner case that is not supported with this solution:

A user could set the simple class name as display name in order to remove

the package name from the output. Since there is no way to tell whether

this was explicitly configured by the user or not by looking at the

TestIdentifier, there does not seem to be a way to support this.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix edge case for class display names

Simply using the class display name in test logging does not work,

because JUnit platform returns only the simple class name from

TestIdentifier.getDisplayName(). This results in the fully qualified

package name being cut off for top level classes.

This change adds some logic that tried to find out whether the display

name has been explicitly se tor not. If so then the class display name

will we use. If not the fully qualified class name will be used for top

level classes and the simple class name will be used for inner classes.

There is still one corner case that is not supported with this solution:

A user could set the simple class name as display name in order to remove

the package name from the output. Since there is no way to tell whether

this was explicitly configured by the user or not by looking at the

TestIdentifier, there does not seem to be a way to support this.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix edge case for class display names

Simply using the class display name in test logging does not work,

because JUnit platform returns only the simple class name from

TestIdentifier.getDisplayName(). This results in the fully qualified

package name being cut off for top level classes.

This change adds some logic that tried to find out whether the display

name has been explicitly se tor not. If so then the class display name

will we use. If not the fully qualified class name will be used for top

level classes and the simple class name will be used for inner classes.

There is still one corner case that is not supported with this solution:

A user could set the simple class name as display name in order to remove

the package name from the output. Since there is no way to tell whether

this was explicitly configured by the user or not by looking at the

TestIdentifier, there does not seem to be a way to support this.

    • -1
    • +1
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Add more test cases

Some tests are still failing, this need discussion on how to handle

class display names.

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -8
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
Add more test cases

Some tests are still failing, this need discussion on how to handle

class display names.

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -8
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
Add more test cases

Some tests are still failing, this need discussion on how to handle

class display names.

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -8
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +101
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 5 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +101
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 6 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 3 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 2 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +101
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 5 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available. Furthermore

getDisplayName() and getClassDisplayName() are moved from

TestDescriptorInternal to TestDescriptor making them available in

beforeTest and afterTest callbacks.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +67
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 3 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

    • -0
    • +101
    ./JUnitPlatformLoggingIntegrationTest.groovy
  1. … 5 more files in changeset.