Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix edge case for class display names

Simply using the class display name in test logging does not work,

because JUnit platform returns only the simple class name from

TestIdentifier.getDisplayName(). This results in the fully qualified

package name being cut off for top level classes.

This change adds some logic that tried to find out whether the display

name has been explicitly se tor not. If so then the class display name

will we use. If not the fully qualified class name will be used for top

level classes and the simple class name will be used for inner classes.

There is still one corner case that is not supported with this solution:

A user could set the simple class name as display name in order to remove

the package name from the output. Since there is no way to tell whether

this was explicitly configured by the user or not by looking at the

TestIdentifier, there does not seem to be a way to support this.

  1. … 2 more files in changeset.
Fix edge case for class display names

Simply using the class display name in test logging does not work,

because JUnit platform returns only the simple class name from

TestIdentifier.getDisplayName(). This results in the fully qualified

package name being cut off for top level classes.

This change adds some logic that tried to find out whether the display

name has been explicitly se tor not. If so then the class display name

will we use. If not the fully qualified class name will be used for top

level classes and the simple class name will be used for inner classes.

There is still one corner case that is not supported with this solution:

A user could set the simple class name as display name in order to remove

the package name from the output. Since there is no way to tell whether

this was explicitly configured by the user or not by looking at the

TestIdentifier, there does not seem to be a way to support this.

  1. … 2 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

  1. … 5 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

  1. … 6 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

  1. … 5 more files in changeset.
Use display name in test logging

Test logging now logs the display name if it is available.

Fixes: #10983

Co-authored-by: Mark Nordhoff <mark.nordhoff@freenet.de>

  1. … 5 more files in changeset.
Support surrogate pairs in SimpleXmlWriter

fixes #10770

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>

  1. … 4 more files in changeset.
Support surrogate pairs in SimpleXmlWriter

fixes #10770

Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>

  1. … 4 more files in changeset.
Fix test

Keep pineapple as a WORKER module

  1. … 3 more files in changeset.
Revert "Add pineapple to worker classpath"

This reverts commit 500d2e6f28792688f6d7bb472a706d2e49ad2f7e.

  1. … 3 more files in changeset.
Add pineapple to worker classpath

  1. … 3 more files in changeset.
Add pineapple to worker classpath

  1. … 4 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

  1. … 162 more files in changeset.
Change few private methods to static

  1. … 252 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 285 more files in changeset.
Use 'implementation' dependencies everywhere

  1. … 285 more files in changeset.
Fix test

Fix tests

  1. … 3 more files in changeset.
Fix tests

  1. … 3 more files in changeset.
Fix some wrong/deprecated test imports

Signed-off-by: Jendrik Johannes <jendrik@gradle.com>

  1. … 2 more files in changeset.
Allow the services required by a given class to be queried prior to creating any instances of that class. Use this to allow `ArtifactTransformDependencies` to be injected into artifact transforms using any of the service injection patterns (that is, via a constructor or a getter).

  1. … 127 more files in changeset.
Replace most direct usages of `DirectInstantiator` with indirect usages via `InstantiatorFactory` or test fixtures instead. This means more consistent behaviour in unit tests because the objects under test will behave more similarly to how they do at runtime. This also allows the decision of how the instantiation should behave to live in as few places as possible, so this can be more easily evolved and contextualized.

  1. … 60 more files in changeset.
Add support for excluding tests via --excludeTests

Signed-off-by: Felipe Lima <felipe.lima@gmail.com>

  1. … 13 more files in changeset.
Remove org.gradle.readLoggingConfigFile

The previouslt deprecated system property is no longer supported and

simply ignored from now on.

Resolves #6301.

  1. … 4 more files in changeset.
Allow inner class pattern match an outer class (#6812)

This fixes #5763 .

In Gradle 4.7 we made a change https://github.com/gradle/gradle/pull/4597 which pre-excludes some classes if test pattern is provided. For example, if a test pattern `org.gradle.Foo.testMethod` is provided, we can definitely exclude `org.gradle.Bar` class. However, this introduced one issue: if test pattern `EnclosingClass$NestedClass.nestedTest` is provided, we exclude `EnclosingClass` - this prevents `JUnitPlatformClassProcessor` from discovering its inner class.

This PR fixes this issue by allowing `EnclosingClass` to match a `EnclosingClass$NestedClass` pattern.

  1. … 2 more files in changeset.