Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Polish up integration tests for gpg cmd

Signed-off-by: Bo Zhang <bo@gradle.com>

  1. … 12 more files in changeset.
Rename Signatory.getInputProperty() to getKeyId()

The new name collides with an already existing method in PgpSignatory

which returned the key in a different format. Since this method was only

used in a two test cases, these have been modified to work with the new

method instead.

  1. … 4 more files in changeset.
Improve readability of PgpSignatoryFactory.getPropertySafely()

Polish changes from pull request #2268

  1. … 3 more files in changeset.
Adds a check for null values in signing properties (#2268)

  1. … 2 more files in changeset.
Replace usages of org.gradle.api.Nullable

With javax.annotation.Nullable.

  1. … 460 more files in changeset.
Remove direct use of PgpSignatory in the Sign task

Conceptually, the signing plugin allows for using multiple signatories

that implement different signing methods. However, in practice the Sign

task always casts the signatory instance returned by Sign.getSignatory()

into a PgpSignatory. This makes it impossible to use a signatory that is

not derived from PgpSignatory.

The Sign task needs to access the PgpSignatory in order to retrieve the

key id which serves as task input value for the signatory property.

This commit fixes this direct dependency by adding the method

getInputValue() to the Signatory interface. This method returns a value

representing the input value of the signatory property. The Sign task

can then use this method for retrieving a value that represents the

signatory property for a specific signatory implementation.

  1. … 2 more files in changeset.
Move Java sources from src/main/groovy to src/main/java

There are no Groovy sources left, so there's no need to keep these files in src/main/groovy.

    • -0
    • +121
    ./PgpSignatory.java
    • -0
    • +167
    ./PgpSignatoryFactory.java
    • -0
    • +52
    ./PgpSignatoryProvider.java
  1. … 46 more files in changeset.