Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./sftp/SftpClientReuseIntegrationTest.groovy
    • -2
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -8
    • +8
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -3
    • +3
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 869 more files in changeset.
Move skip reasons to @FailsWithInstantExecution and drop @IgnoreWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./sftp/SftpClientReuseIntegrationTest.groovy
    • -2
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -8
    • +8
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -3
    • +3
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 42 more files in changeset.
Annotate integ tests failing to cleanup with instant execution in :resourcesSftp

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./sftp/SftpClientReuseIntegrationTest.groovy
    • -2
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -8
    • +8
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -2
    • +3
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 4 more files in changeset.
Annotate integ tests failing with instant execution in various projects

removing most of @IgnoreWithInstantExecution annotations

after fixing the @FailsWithInstantExecution rule

and more ci feedback

also make @IgnoreWithInstantExecution require a reason from a fixed set

and add it to the remaining ignores

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
  1. … 126 more files in changeset.
Annotate integ tests failing with instant execution in :resourcesSftp

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -0
    • +8
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -0
    • +2
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 2 more files in changeset.
Annotate integ tests failing with instant execution in :resourcesSftp

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -0
    • +8
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -0
    • +2
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 2 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Fix SftpClientReuseIntegrationTest

    • -0
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
Merge resources integration tests

    • -50
    • +0
    ./sftp/AbstractSftpDependencyResolutionTest.groovy
    • -95
    • +0
    ./sftp/SftpClientReuseIntegrationTest.groovy
    • -120
    • +0
    ./sftp/ivy/IvySftpRepoDynamicRevisionIntegrationTest.groovy
    • -253
    • +0
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
    • -41
    • +0
    ./sftp/ivy/IvySftpRepoResolveIntegrationTest.groovy
    • -90
    • +0
    ./sftp/maven/MavenSftpRepoResolveIntegrationTest.groovy
  1. … 118 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 95 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Tweak the output produced by `TreeFormatter`.

    • -1
    • +2
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 36 more files in changeset.
Tweak the API of `BlockingHttpServer` and fix some flakiness in its error reporting.

Also replace the remaining usages of `CyclicBarrierHttpServer` with `BlockingHttpServer`.

    • -6
    • +8
    ./sftp/SftpClientReuseIntegrationTest.groovy
  1. … 16 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

    • -6
    • +14
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 61 more files in changeset.
Support HTTP header based authentication for Maven repositories

Now it's possible to use a custom HTTP header to authorize access to

Maven repositories. This enables Gradle to access private GitLab and TFS

repositories used as Maven repositories or any OAuth2 protected Maven

repository.

Resolves #5571.

    • -1
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
  1. … 30 more files in changeset.
Improve error reporting in case no matching dynamic version is found

This commit improves rendering of errors in case resolution fails because

all versions in a dynamic range are evicted, and that at least one of the

evicted versions was evicted because of attribute matching. The error will

now report the attributes on each tested version, as well as the requested

attributes.

For this, the module not found exception has been updated to carry more

context, and now makes use of the tree formatter for consistency with other

exceptions in the codebase.

    • -4
    • +3
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 37 more files in changeset.
Increase timeout

Test may take longer under heavy load.

    • -1
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
Fixed tests for changes to error message.

    • -6
    • +6
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
Disable parallel resolution for all SFTP tests

Previously we were using `executer.withArgument` to limit

parallism in these tests. However, this value is reset for any

subsequent exectuion for the same executer in the same test.

This has been fixed by using the `beforeExecute` hook to always

set `max-workers=1`.

    • -2
    • +4
    ./sftp/AbstractSftpDependencyResolutionTest.groovy
    • -2
    • +4
    ./sftp/ivy/IvySftpRepoResolveIntegrationTest.groovy
  1. … 4 more files in changeset.
Disable concurrent downloads for STFP tests

The test fixture doesn't seem to handle concurrent requests properly.

    • -0
    • +5
    ./sftp/AbstractSftpDependencyResolutionTest.groovy
    • -0
    • +5
    ./sftp/ivy/IvySftpRepoResolveIntegrationTest.groovy
  1. … 4 more files in changeset.
Make SftpClientReuseIntegrationTest fail with original failure

    • -1
    • +2
    ./sftp/SftpClientReuseIntegrationTest.groovy
Introduce delay in sftp reuse test to allow connections to close

    • -0
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
Up test log level to INFO to troubleshoot flakiness

    • -1
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
Change test to simply close connections rather than restarting sftp server

    • -1
    • +1
    ./sftp/SftpClientReuseIntegrationTest.groovy
  1. … 1 more file in changeset.
Check that an existing sftp connection is still connected before reuse

    • -0
    • +91
    ./sftp/SftpClientReuseIntegrationTest.groovy
  1. … 4 more files in changeset.
Removed a bunch of calls to `withDeprecationChecksDisabled()` and `withStackTraceChecksDisabled()`.

    • -1
    • +1
    ./sftp/ivy/IvySftpRepoErrorsIntegrationTest.groovy
  1. … 10 more files in changeset.