org

Signed-off-by: Paul Merlin <paul@gradle.com>

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

And files we missed due to moving things to coreApi.

In order to use S3 backed artifact repositories, it was previously

required to add `--add-modules java.xml.bind` to `org.gradle.jvmargs`

when running on Java 9 and above. Since Java 11 no longer contains the

`java.xml.bind` module, Gradle now bundles JAXB 2.3.1

(`com.sun.xml.bind:jaxb-impl`) and uses it on Java 9 and above.

Now the canned ACL `bucket-owner-full-control` is used for uploading

artifacts to S3 buckets to ensure the bucket owner has permission to

read and manage them.

Fixes #5233.

Signed-off-by: Salvian Reynaldi <salvian@traveloka.com>

- Add the javax.xml.bind module when running on JDK >= 9

- Delete test for exception message when javax.xml.bind is not present

because it would require another VM which seems overkill for this

simple scenario.

- Fix exception message to use `--add-modules` instead of `-addmods`

which was only present in early access releases.

Issue: gradle/gradle-private#1199

Signed-off-by: Dennis Hoer <dennis.hoer@pearson.com>

Signed-off-by: Dennis Hoer <dennis.hoer@pearson.com>

Signed-off-by: Dennis Hoer <dennis.hoer@pearson.com>

Signed-off-by: Dennis Hoer <dennis.hoer@pearson.com>

Signed-off-by: Dennis Hoer <dennis.hoer@pearson.com>

- This isn't wired into anything, so no services actually work yet.

+review REVIEW-6323

Digged inside the code to find all code path leading to the

instantiation of ExternalResourceReadResponse class and verify the

resource is properly closed.

+review REVIEW-6323

S3 repository can authenticate using AWS EC2 instance metadata

* This is related to https://github.com/gradle/gradle/blob/c2dc9979706e6b3beca13f1de860834e9255fb1b/design-docs/finding-and-using-credentials.md#story-an-s3-repository-can-be-configured-to-authenticate-using-awss-ec2-instance-metadata

* Note that the AWS S3 Client implementation will now use the following

credentials (in this specific order)

- Environment (AWS_ACCESS_KEY, AWS_SECRET_ACCESS_KEY,

AWS_SESSION_TOKEN)

- Java System Properties - aws.accessKeyId and aws.secretKey

- Credential profiles file at the default

location (~/.aws/credentials) shared by all AWS SDKs and the AWS CLI

- Instance Profile Credentials - delivered through the Amazon EC2

metadata service

* The implementation assumes that only ONE authentication can be used

per s3-resource at a time

* This patch enforces that each Authentication now declares

`requiresCredentials` to be explicit

Integration tests:

Note that we cannot mock the instance meta data since it uses the ip

169.254.169.254 so we mock the system properties that the client

CredentialsProviderChain will look for.

+review REVIEW-6072

We only need the java.xml.bind Jigsaw module for uploading,

resolving works fine without it.

+review REVIEW-6072

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.