Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make http server fixture's handle() thread safe

As stated in the here implemented 'ServerWithExpectations' fixture:

"handlers, as well as failures, need to be thread-safe"

This concrete case was working most of the time since usually there are

not more than one expectations for the same request. But if the

same request is expected several times, and the requests are received

in parallel (as it is the case for metadata download), the handle()

method behaved flaky - by not doing reading and updating of the 'run'

flag as an atomic operation.

  1. … 4 more files in changeset.
Make http server fixture's handle() thread safe

As stated in the here implemented 'ServerWithExpectations' fixture:

"handlers, as well as failures, need to be thread-safe"

This concrete case was working most of the time since usually there are

not more than one expectations for the same request. But if the

same request is expected several times, and the requests are received

in parallel (as it is the case for metadata download), the handle()

method behaved flaky - by not doing reading and updating of the 'run'

flag as an atomic operation.

  1. … 4 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

  1. … 12 more files in changeset.
Merge resources integration tests

  1. … 109 more files in changeset.
Adjust tests and samples to new metadata sources defaults

  1. … 95 more files in changeset.
Adjust tests and samples to new publishing default behavior

  1. … 43 more files in changeset.
Adjust tests and samples to new metadata sources defaults

  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

  1. … 15 more files in changeset.
Adjust tests following Gradle Module Metadata feature preview removal

  1. … 29 more files in changeset.
Adjust tests following Gradle Module Metadata feature preview removal

  1. … 29 more files in changeset.
Adjust tests following Gradle Module Metadata feature preview removal

  1. … 29 more files in changeset.
Revert "Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'""

This reverts commit 0625bc7420e55e87730673231af6ad45dd04f47a.

  1. … 90 more files in changeset.
Revert "Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'""

This reverts commit 0625bc7420e55e87730673231af6ad45dd04f47a.

  1. … 90 more files in changeset.
Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'"

This reverts commit 2f79026f5e127a8175e25844522237615b19ed52 because of a performance regression,

reversing changes made to 7f1e66079ce629ecde3e09e549e9796ab85761dc.

  1. … 90 more files in changeset.
Resolve additional failing tests

Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

  1. … 8 more files in changeset.
Fix tests

  1. … 3 more files in changeset.
Fix tests

  1. … 3 more files in changeset.
Do not use Maven libraries for publishing with `maven-publish`

The use of aether and other Maven libraries was problematic:

- Static state forced us to prohibit concurrent publishing tasks

- It was difficult to control/understand the generated `maven-metadata.xml` files

- Multiple layers of indirection Gradle->Maven->Gradle->Maven made the code

difficult to comprehend and modify

Publishing of snapshot modules is not yet working. This will come in a

subsequent commit.

  1. … 11 more files in changeset.
Do not use Maven libraries for publishing with `maven-publish`

The use of aether and other Maven libraries was problematic:

- Static state forced us to prohibit concurrent publishing tasks

- It was difficult to control/understand the generated `maven-metadata.xml` files

- Multiple layers of indirection Gradle->Maven->Gradle->Maven made the code

difficult to comprehend and modify

Publishing of snapshot modules is not yet working. This will come in a

subsequent commit.

  1. … 11 more files in changeset.
Do not use Maven libraries for publishing with `maven-publish`

The use of aether and other Maven libraries was problematic:

- Static state forced us to prohibit concurrent publishing tasks

- It was difficult to control/understand the generated `maven-metadata.xml` files

- Multiple layers of indirection Gradle->Maven->Gradle->Maven made the code

difficult to comprehend and modify

Publishing of snapshot modules is not yet working. This will come in a

subsequent commit.

  1. … 11 more files in changeset.
Do not use Maven libraries for publishing with `maven-publish`

The use of aether and other Maven libraries was problematic:

- Static state forced us to prohibit concurrent publishing tasks

- It was difficult to control/understand the generated `maven-metadata.xml` files

- Multiple layers of indirection Gradle->Maven->Gradle->Maven made the code

difficult to comprehend and modify

Publishing of snapshot modules is not yet working. This will come in a

subsequent commit.

  1. … 11 more files in changeset.
Spelling (#8147)

Misspellings make it harder to search for things; they make it harder for people to understand code and descriptions; and sometimes they result in bugs.

This PR fixes quite a few typos.

  1. … 13 more files in changeset.
Migrate to Jetty 9

  1. … 20 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

  1. … 61 more files in changeset.
Bundle JAXB into Gradle distribution and use it on Java 9 and above

In order to use S3 backed artifact repositories, it was previously

required to add `--add-modules java.xml.bind` to `org.gradle.jvmargs`

when running on Java 9 and above. Since Java 11 no longer contains the

`java.xml.bind` module, Gradle now bundles JAXB 2.3.1

(`com.sun.xml.bind:jaxb-impl`) and uses it on Java 9 and above.

  1. … 10 more files in changeset.
Give S3 bucket owner full control over published artifacts

Now the canned ACL `bucket-owner-full-control` is used for uploading

artifacts to S3 buckets to ensure the bucket owner has permission to

read and manage them.

Fixes #5233.

Signed-off-by: Salvian Reynaldi <salvian@traveloka.com>

  1. … 4 more files in changeset.
Add extra --add-modules parameters to forking GradleExecuter