MavenS3RepoErrorsIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -6
    • +6
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :resourcesS3

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 4 more files in changeset.
Annotate integ tests failing with instant execution in :resourcesS3

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 4 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 12 more files in changeset.
Merge resources integration tests

    • -148
    • +0
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 123 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 95 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -2
    • +0
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Spelling (#8147)

Misspellings make it harder to search for things; they make it harder for people to understand code and descriptions; and sometimes they result in bugs.

This PR fixes quite a few typos.

    • -1
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 15 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

    • -4
    • +10
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 61 more files in changeset.
Improve error reporting in case no matching dynamic version is found

This commit improves rendering of errors in case resolution fails because

all versions in a dynamic range are evicted, and that at least one of the

evicted versions was evicted because of attribute matching. The error will

now report the attributes on each tested version, as well as the requested

attributes.

For this, the module not found exception has been updated to carry more

context, and now makes use of the tree formatter for consistency with other

exceptions in the codebase.

    • -2
    • +2
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 37 more files in changeset.
Fix typo on S3 AwsImAuthentication

    • -1
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 1 more file in changeset.
Fixed tests for changes to error message.

    • -2
    • +2
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
Merge pull request #690 from kiddouk:story/S3-repository-can-be-configured-to-authenticate-using-AWS-EC2-instance-metadata

S3 repository can authenticate using AWS EC2 instance metadata

* This is related to https://github.com/gradle/gradle/blob/c2dc9979706e6b3beca13f1de860834e9255fb1b/design-docs/finding-and-using-credentials.md#story-an-s3-repository-can-be-configured-to-authenticate-using-awss-ec2-instance-metadata

* Note that the AWS S3 Client implementation will now use the following

credentials (in this specific order)

- Environment (AWS_ACCESS_KEY, AWS_SECRET_ACCESS_KEY,

AWS_SESSION_TOKEN)

- Java System Properties - aws.accessKeyId and aws.secretKey

- Credential profiles file at the default

location (~/.aws/credentials) shared by all AWS SDKs and the AWS CLI

- Instance Profile Credentials - delivered through the Amazon EC2

metadata service

* The implementation assumes that only ONE authentication can be used

per s3-resource at a time

* This patch enforces that each Authentication now declares

`requiresCredentials` to be explicit

Integration tests:

Note that we cannot mock the instance meta data since it uses the ip

169.254.169.254 so we mock the system properties that the client

CredentialsProviderChain will look for.

    • -1
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 22 more files in changeset.
Changed some tests to use the ExecutionFailure fixture rather than scraping the build's stderr for strings of a particular format.

    • -4
    • +3
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
Address review items for Authentication types

+review REVIEW-5569

    • -1
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 19 more files in changeset.
Check that other repositories cannot use HTTP auth types

+review REVIEW-5574

    • -0
    • +22
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 7 more files in changeset.
Use a consistent error message when something goes wrong getting or putting an external resource.

    • -2
    • +2
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 11 more files in changeset.
fix failing integtest in resourcesS3 after moving AwsCredentials

    • -1
    • +2
    ./MavenS3RepoErrorsIntegrationTest.groovy
Some tidy-ups of S3 int tests.

    • -3
    • +3
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
Some test coverage to reporting locations when we can't resolve something.

    • -2
    • +4
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
some cleanup on S3 related integtests

+review REVIEW-5361

    • -1
    • +1
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 6 more files in changeset.
don't directly use s3stubSupport for setting up test fixtures

+review REVIEW-5361

    • -4
    • +6
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 1 more file in changeset.
moved all s3 related resources, fixtures, tests and integration tests into resourceS3 subproject

- required to add maven/ivy testfixtures (only compiling one class each atm)

+review REVIEW-5361

    • -0
    • +118
    ./MavenS3RepoErrorsIntegrationTest.groovy
  1. … 69 more files in changeset.