internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed some test cases for changes to view types.

+review REVIEW-5708

  1. … 1 more file in changeset.
Mixed DependentSourceSet into JavaSourceSet, so that the `dependencies` property is reachable from the public API.

This will allow it to be visible to view generation, plus plugins implemented in languages other than Groovy.

+review REVIEW-5708

  1. … 2 more files in changeset.
Use the public type of a binary in its display name.

Also removed `BinarySpecInternal.setPublicType()` as this is always known at construction now.

+review REVIEW-5708

    • -5
    • +0
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 8 more files in changeset.
BaseBinarySpec.sources is a node-backed ModelMap

    • -6
    • +0
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 22 more files in changeset.
Renamed LanguageSourceSet.fullName -> projectScopedName

This change makes LanguageSourceSet consistent with BinarySpec

Issue: gradle/langos#40 +review REVIEW-5681

  1. … 8 more files in changeset.
Remove unnecessary public API methods

+review REVIEW-5669

  1. … 7 more files in changeset.
Changed the JVM and native component plugins to use names for binaries that reflect the role they play.

Now that more than one component may have a binary with a given name, use:

- `jar` as the name for a Jar binary that belongs to a JVM library

- `executable` as the name for an executable that belongs to a native application

- `sharedLibrary` and `staticLibrary` as the name for the binaries of a native library.

These can later turn into static properties of the appropriate `ComponentSpec` types.

There is a breaking change in this commit: the lifecycle task name and output directory name of the binaries of components with multiple variants now include the component name at the start of the name, rather than somewhere in the middle.

    • -2
    • +2
    ./jvm/ClassDirectoryBinaryNamingScheme.java
  1. … 26 more files in changeset.
Moved the concept of the owning component of a binary up from various subtypes up to BaseBinarySpec.

Previously, native and jvm library binary specs exposed their owning component, for use in rules. This is now available in a consistent way for all binary specs (which can all be owned by a component). Later, this should probably be moved to a view that is mixed in to those binaries that are actually owned by a component.

This change also allows certain immutable properties of the component to be used to calculate some properties of the binary.

    • -0
    • +5
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 11 more files in changeset.
Allow A LanguageSourceSet of any registered type to be created via FunctionalSourceSet

- Adds languageRegistry to FSS

- LSS creation uses FSS's LanguageRegistry

- Don't push language factories into FSS

- Add a basDir property to FSS for initializing LSS's with a default source directory

- Remove language source set factory registration from ComponentRules

  1. … 15 more files in changeset.
Allow managed binaries and components to extend specs

This allows users to declare managed types that extend a non-managed

interface with a registered default implementation. The managed

instance will delegate everything possible to an instance of the

default implementation (stored as an unmanaged instance in the node),

while storing all other managed properties in child nodes.

Changes:

* Instead of generating managed proxy classes during schema extraction,

now they are generated (and cached) during instantiation.

* Instantiation of purely managed types are not validated during schema

extraction.

Things still to do:

* Handle error cases during declaration of managed type

* Add projections for internal views declared for super-types (both

managed and unmanaged)

+review REVIEW-5651

    • -0
    • +5
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 43 more files in changeset.
Moved a bunch of classes from 'core' to 'plugins' project.

    • -1
    • +1
    ./tasks/testing/junit/JULRedirector.java
    • -0
    • +26
    ./tasks/testing/processors/StandardOutputRedirector.java
  1. … 5 more files in changeset.
Changed JavaBasePlugin to create compile and process resources tasks using the legacy types rather than the software model type. This allows the software types to be created later (ie as rules require them).

  1. … 3 more files in changeset.
Changed DefaultClassDirectoryBinarySpec so that it is an adapter over SourceSet, and added some test coverage.

    • -6
    • +4
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 1 more file in changeset.
Moved some logic from DefaultClassDirectoryBinarySpec to DefaultSourceSet.

    • -1
    • +1
    ./jvm/ClassDirectoryBinaryNamingScheme.java
    • -3
    • +0
    ./jvm/ClassDirectoryBinarySpecInternal.java
    • -9
    • +9
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 3 more files in changeset.
Changed BinarySpecInternal so that it carries details about the public type of the binary, and use this to calculate the schema, rather than trying to inspect the binary to figure out if it's decorated or a model view or whatever.

Changed ModelSchemaStore so that it deals only with types and not instances.

    • -0
    • +7
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 18 more files in changeset.
Renamed FileCollectionContainer.resolve() to visitContents()

  1. … 25 more files in changeset.
Minor tweaks.

  1. … 1 more file in changeset.
Show JVM binary variants in component report

+review REVIEW-5596

    • -0
    • +8
    ./jvm/ClassDirectoryBinaryRenderer.java
  1. … 19 more files in changeset.
Some fixes to enable test filtering for JUnit versions < 4.6. Added some test coverage.

    • -6
    • +8
    ./tasks/testing/junit/JUnitTestEventAdapter.java
    • -20
    • +0
    ./tasks/testing/junit/JUnitTestFramework.java
  1. … 8 more files in changeset.
Improved test filtering for Junit classes that use a Runner that is not also Filterable.

  1. … 3 more files in changeset.
fix handling of tasks without declared test classes available

+review REVIEW-5563

    • -0
    • +11
    ./tasks/testing/filter/DefaultTestFilter.java
  1. … 6 more files in changeset.
Moved Throwable Serializer from plugins to messaging projects.

    • -12
    • +2
    ./tasks/testing/worker/TestEventSerializer.java
  1. … 3 more files in changeset.
Changed TestEventSerializer so that it provides a Serializer rather than a StatefulSerializer.

    • -30
    • +3
    ./tasks/testing/worker/TestEventSerializer.java
    • -2
    • +2
    ./tasks/testing/worker/TestWorker.java
  1. … 11 more files in changeset.
Properly deprecated methods

Hopefully this works with Java 6 and 7 as well as Java 8

+review REVIEW-5541

    • -0
    • +1
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 4 more files in changeset.
Adding build session scope to PluginServiceRegistry

+review REVIEW-5510

  1. … 34 more files in changeset.
handle test not available anymore

  1. … 12 more files in changeset.
allow setting class and method name explicit in TestFilter

    • -1
    • +11
    ./tasks/testing/filter/DefaultTestFilter.java
  1. … 3 more files in changeset.
Reverted deprecation as it messes with Java 7- compilers

Works without problems in Java 8. Weird.

+review REVIEW-5541

    • -1
    • +0
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 2 more files in changeset.
Fixed compile error +review REVIEW-5541

    • -1
    • +2
    ./jvm/DefaultClassDirectoryBinarySpec.java
Use rules to add component- and owned source sets to binaries' inputs

+review REVIEW-5541

    • -6
    • +6
    ./jvm/DefaultClassDirectoryBinarySpec.java
  1. … 11 more files in changeset.