Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rewrite tests for Java/Groovy compilation avoidance

    • -2
    • +2
    ./GroovySecurityManagerIssuesIntegrationTest.groovy
  1. … 10 more files in changeset.
Add a serializer for RequestProtocol requests

And allow work implementations to register serializers for their arguments.

    • -1
    • +1
    ./compile/DaemonGroovyCompilerIntegrationTest.groovy
  1. … 25 more files in changeset.
Add a serializer for RequestProtocol requests

And allow work implementations to register serializers for their arguments.

    • -1
    • +1
    ./compile/DaemonGroovyCompilerIntegrationTest.groovy
  1. … 25 more files in changeset.
Clean up test code

Issue #7398

    • -23
    • +0
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
Fix Groovy/Java library compatibility

This commit fixes the Groovy + Java Library compatibility,

by making sure that if, and only if, the Java Library is

applied on a project that also applies the Java Library

plugin, then the correct variants is selected.

    • -0
    • +135
    ./GroovyJavaLibraryInteractionIntegrationTest.groovy
    • -99
    • +0
    ./GroovyPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Issue 7398: groovy + java-library plugin compatibility.

Signed-off-by: James X. Nelson <James@WeTheInter.net>

    • -0
    • +93
    ./GroovyPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Issue 7398: groovy + java-library plugin compatibility.

Signed-off-by: James X. Nelson <James@WeTheInter.net>

    • -0
    • +99
    ./GroovyPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Polishing

    • -1
    • +0
    ./GroovyCrossCompilationIntegrationTest.groovy
  1. … 1 more file in changeset.
Only decorate compilation of JavaCompile task

Makes names clearer and reduces potential confusion.

    • -4
    • +0
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -24
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 18 more files in changeset.
Report annotation processor type in build operation result

Instead of just reporting whether an annotation processor was

incremental, we now report its type, i.e. aggregating, isolating, or

unknown.

    • -1
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 10 more files in changeset.
Report whether annotation processor is incremental

This commit adds an `incremental` property to the result of the build

operation and checks that it’s reported correctly for the different

annotation processor types.

    • -0
    • +1
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 23 more files in changeset.
Report List<AnnotationProcessorDetails> instead of Map<String, Long>

    • -1
    • +1
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -16
    • +16
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 3 more files in changeset.
Allow to detect when annotation processor info is missing

- Remove redundant task path from build operation details as it's

enclosed in an ExecuteTaskBuildOperationType operation already.

- Add coverage for forking compilation where annotation processors are

neither instrumented nor tracked.

- Use `null` to signal that no annotation processor execution times are

available.

- Extract lookup code for build operation into separate fixture class

and reuse it in all tests.

    • -0
    • +5
    ./GroovyCrossCompilationIntegrationTest.groovy
    • -14
    • +7
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 5 more files in changeset.
Remove duplicate assertions from BasicGroovyCompilerIntegrationSpec

    • -5
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
Report annotation processor execution time

In order to track time spent by annotation processors, invocations of

compilers in `JavaCompile` and `GroovyCompile` are now wrapped in build

operations that report the execution time per fully-qualified annotation

processor class name in their result.

    • -1
    • +37
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 22 more files in changeset.
Set default value to annotationProcessorGeneratedSourcesDirectory

This also fixes the documentation for the options.annotationProcessorPath

default value.

Fixes #4956

Signed-off-by: Thomas Broyer <t.broyer@ltgt.net>

    • -14
    • +14
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 10 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

    • -0
    • +1
    ./GroovyBasePluginIntegrationTest.groovy
  1. … 61 more files in changeset.
Do not use snapshot Groovy versions in tests

When we depend on a SNAPSHOT version of Groovy, we shouldn't run tests that need to download Groovy versions with that SNAPSHOT version. This is to prevent us from bumping into problems with how Groovy snapshots are published.

    • -4
    • +0
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -2
    • +0
    ./compile/DaemonGroovyCompilerIntegrationTest.groovy
  1. … 3 more files in changeset.
Handle -proc:none in ApiGroovyCompiler

    • -1
    • +1
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 1 more file in changeset.
Upgrade to Groovy 2.5.3-SNAPSHOT (#6903)

This is a temporary measure until Groovy 2.5.3 GA comes out to fix Java 11 incompatibilities.

    • -0
    • +4
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -0
    • +2
    ./compile/DaemonGroovyCompilerIntegrationTest.groovy
  1. … 8 more files in changeset.
Upgrade to Groovy 2.5.3-SNAPSHOT (#6903)

This is a temporary measure until Groovy 2.5.3 GA comes out to fix Java 11 incompatibilities.

    • -0
    • +4
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
    • -0
    • +2
    ./compile/DaemonGroovyCompilerIntegrationTest.groovy
  1. … 8 more files in changeset.
Always use configured annotationProcessorPath

- Don't use an empty path for `-proc:none` because it is also used by

compiler plugins

- Don't support setting it to `null` anymore.

Resolves #6573.

    • -2
    • +2
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 11 more files in changeset.
Use global init script to set mirrors for buildSrc (#6627)

    • -1
    • +1
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 50 more files in changeset.
Ignore some tests on IBM JDK

Some tests (e.g. JavaFx) are not supported by IBM JDK 8, ignored.

    • -3
    • +2
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 2 more files in changeset.
Ignore some tests on IBM JDK

Some tests (e.g. JavaFx) are not supported by IBM JDK 8, ignored.

    • -3
    • +2
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 2 more files in changeset.
Use external repository mirrors in build (#6094)

We've been bitten by external repository fluctuation for a long time.

This PR makes most of tests use repository mirrors set up by ourselves

via init script and system property.

There're still some tests not switching to mirrors, which would be fixed

in follow-up commits.

    • -0
    • +1
    ./compile/BasicGroovyCompilerIntegrationSpec.groovy
  1. … 99 more files in changeset.
Set timeout for AbstractIntegrationSpec (#5806)

We have been bitten by CI build exection timeout for a long time.

This PR introduces timeout for AbstractIntegrationSpec in order to

monitor execution timeout. Upon timeout, a spock interceptor can

print all threads' stack traces in all JVMs so that we can diagnose

the potential issues in other JVMs (daemons, test workers, etc.).

    • -2
    • +2
    ./compile/InProcessGroovyCompilerIntegrationTest.groovy
  1. … 29 more files in changeset.
Revert "Improve test assertion"

This reverts commit 92608803248e698ad9eec60acb2bca7e627e2549.

    • -2
    • +1
    ./GroovyBasePluginIntegrationTest.groovy
Improve test assertion

As noted in code review: https://github.com/gradle/gradle/pull/5726#discussion_r196305459

    • -1
    • +2
    ./GroovyBasePluginIntegrationTest.groovy
Improve test assertion

As noted in code review: https://github.com/gradle/gradle/pull/5726#discussion_r196305459

    • -1
    • +2
    ./GroovyBasePluginIntegrationTest.groovy