Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove `StringScriptSource`, to be replaced with the existing `TextResourceScriptSource`.

    • -2
    • +3
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 9 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Inject FeaturePreviews in DefaultVersionComparator

This will enable to select which StaticVersionComparator to use based on

feature preview activation.

As a consequence, the VersionComparator becomes build scoped and has to

be injected instead of being instantiated in different places.

Issue #13050

    • -1
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 26 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 46 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 46 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 46 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 46 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 45 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 45 more files in changeset.
Improve variant matching error messages

Error messages prove to be difficult to interpret from a user point of

view. This commit tries to improve the situation by doing a couple of

things:

1. describing more clearly what the consumer is asking for. This includes,

when possible (currently only in the Java ecosystem), interpreting the

consumer attributes as a human-readable description, instead of a raw

list of attributes.

2. giving more context when possible. In particular, sometimes we fail

with an ambiguous variant error selection, but we only list the remaining

candidates, not listing the ones which were actually discarded during

selection. This proved to be particularly complex to debug from various

users (plugin authors and end-users).

    • -2
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 46 more files in changeset.
Remove "self-resolving" plugin resolver since injected plugins now come from included builds

    • -44
    • +0
    ./SelfResolvingRequestPluginResolverTest.groovy
  1. … 8 more files in changeset.
Introduce a `JAVA_API_JARS` usage

This commit introduces a new `JAVA_API_JARS` usage, mirror

to the `JAVA_RUNTIME_JARS` usage. This is both for consistency,

and to make sure that the `JAVA_API` and `JAVA_RUNTIME` usages

are limited to cases where the consumer doesn't care, or when

a producer doesn't have a more specific usage to provide.

This is, for example, the case for Java platforms. It's worth

noting than in case a producer mixes both "generic" usages

and "specific" usages, selection is likely to produce unexpected

results, because of disambiguation rules.

The Java disambiguation rule has been simplified and now

supports more cases.

    • -0
    • +2
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 37 more files in changeset.
Revert "Merge pull request #6774 from gradle/eskatos/plugins/markers-metadata-only"

This reverts commit 0426976b85d5f732f43c97a97951986d5c3f74fc, reversing

changes made to 26cd8ebad223ade618f20997d6a08ef5fad4ffce.

    • -8
    • +44
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 9 more files in changeset.
Let plugins {} block resolution fetch plugin markers only

Removing one http request for a jar artifact per resolved marker.

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -44
    • +8
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 2 more files in changeset.
Support snapshot plugin versions

Using snapshot plugins previously ended up in a blocking error

with a "Plugin Repositories (snapshot plugin versions are not

supported)" message.

With this commit, it is now possible to use snapshot plugins like:

plugins {

id 'org.springframework.boot' version '2.0.0.BUILD-SNAPSHOT'

}

Fix #3902

Signed-off-by: Sebastien Deleuze <sdeleuze@pivotal.io>

    • -2
    • +17
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 2 more files in changeset.
Cache parsing of version strings

The version parser is by far the largest contributor to garbage created during the

resolution of a large dependency graph. This commit creates a build scope version

parser which is shared and caches the result of parsing, avoiding the creation of

a significant number of arrays.

    • -1
    • +3
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 45 more files in changeset.
Fix unit test

    • -1
    • +1
    ./SelfResolvingRequestPluginResolverTest.groovy
Fix unit tests

    • -0
    • +44
    ./SelfResolvingRequestPluginResolverTest.groovy
  1. … 5 more files in changeset.
Restore repo URL in plugin resolution error messages

    • -6
    • +8
    ./ArtifactRepositoriesPluginResolverTest.groovy
  1. … 17 more files in changeset.
pluginManagement { repositories {} } is a RepositoryHandler

Remove PluginRepositoriesSpec and related types

Remove internal PluginRepository type hierarchy

Introduce build scoped PluginDependencyResolutionServices

Introduce RepositoryHandler.gradlePluginPortal()

Plugin resolution error messages changed has they now use the regular

ArtifactRepository display name

    • -0
    • +72
    ./ArtifactRepositoriesPluginResolverTest.groovy
    • -60
    • +0
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 44 more files in changeset.
Constructor was only used in tests

No need to have an additional constructor. Make class more readable.

    • -1
    • +2
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 4 more files in changeset.
Split PluginRequest implementation

    • -3
    • +4
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 14 more files in changeset.
Revert "Rename `VersionSelector` to `VersionMatcher`"

This reverts commit 5046159bfc739c3d86c59411dd4b4a1c36786b81. The Nebula resolution rules plugin makes use of internal classes,

and broke with this refactoring.

    • -3
    • +3
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 67 more files in changeset.
Rename `VersionSelector` to `VersionMatcher`

This refactor is introduced to reduce confusion: the selector corresponds to

the requested version, which can be an exact version number, a range, or

anything else. The matchers, on the other hand, match a selector. In other

words, the selector is a specification, while the matcher does the actual

work of matching.

    • -3
    • +3
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 69 more files in changeset.
Allow script plugins to be applied via the plugins DSL

Remote URLs are also supported:

```

plugins {

script "path/to/other.gradle"

script "https://example.com/another.gradle"

}

```

Local file paths are expressed as relative from the requesting script.

Constrain plugins {} block api to distinguish binary and script

plugin requests by both strongly modeled types and ad-hoc groovy parsing

of the plugins block. This pave the way for proper support of the

plugins {} block with the Gradle Kotlin DSL.

Implement ScriptPlugin PluginResolver by generating a synthetic

"imperative" Plugin class that loads and applies the script plugin when

applied.

This synthetic generated loader class and the script plugins are loaded

into the buildSrc classloader scope.

Only Project targets are supported.

`apply false` is not supported.

    • -3
    • +4
    ./ArtifactRepositoryPluginResolverTest.groovy
  1. … 63 more files in changeset.