Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -15
    • +15
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -2
    • +2
    ./PluginUnderTestMetadataIntegrationTest.groovy
    • -9
    • +9
    ./ValidatePluginsIntegrationTest.groovy
    • -2
    • +2
    ./ValidateTaskPropertiesIntegrationTest.groovy
  1. … 869 more files in changeset.
Move skip reasons to @FailsWithInstantExecution and drop @IgnoreWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -15
    • +15
    ./AbstractPluginValidationIntegrationSpec.groovy
  1. … 45 more files in changeset.
Annotate integ tests failing with instant execution in various projects

removing most of @IgnoreWithInstantExecution annotations

after fixing the @FailsWithInstantExecution rule

and more ci feedback

also make @IgnoreWithInstantExecution require a reason from a fixed set

and add it to the remaining ignores

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -14
    • +14
    ./AbstractPluginValidationIntegrationSpec.groovy
  1. … 126 more files in changeset.
Annotate integ tests failing with instant execution in :pluginDevelopment

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +15
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -1
    • +4
    ./PluginUnderTestMetadataIntegrationTest.groovy
    • -0
    • +9
    ./ValidatePluginsIntegrationTest.groovy
    • -0
    • +2
    ./ValidateTaskPropertiesIntegrationTest.groovy
  1. … 2 more files in changeset.
Annotate integ tests failing with instant execution in :pluginDevelopment

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +15
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -1
    • +4
    ./PluginUnderTestMetadataIntegrationTest.groovy
    • -0
    • +9
    ./ValidatePluginsIntegrationTest.groovy
    • -0
    • +2
    ./ValidateTaskPropertiesIntegrationTest.groovy
  1. … 2 more files in changeset.
Validate plugin source set defined in extension (#10859)

Validate plugin source set defined in extension

    • -0
    • +50
    ./ValidatePluginsIntegrationTest.groovy
Migrate tests from PropertyValidationAccessTest

We now have integration tests for both static and runtime for all of these.

    • -10
    • +178
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +48
    ./RuntimePluginValidationIntegrationTest.groovy
    • -2
    • +39
    ./ValidatePluginsIntegrationTest.groovy
  1. … 2 more files in changeset.
Migrate tests from PropertyValidationAccessTest

We now have integration tests for both static and runtime for all of these.

    • -10
    • +178
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +48
    ./RuntimePluginValidationIntegrationTest.groovy
    • -2
    • +39
    ./ValidatePluginsIntegrationTest.groovy
  1. … 1 more file in changeset.
Simplify test

    • -9
    • +1
    ./ValidatePluginsIntegrationTest.groovy
Configure source set to validate lazily

So that extension configuration has a chance to take effect.

    • -0
    • +58
    ./ValidatePluginsIntegrationTest.groovy
  1. … 1 more file in changeset.
Rename and fix test

It doesn't matter how things are applied, we are testing the deprecated behavior here.

    • -160
    • +0
    ./ValidateTaskPropertiesConfiguredByPluginIntegrationTest.groovy
    • -0
    • +156
    ./ValidateTaskPropertiesIntegrationTest.groovy
Remove unnecessary integration test

The only case tested here is already covered in AbstractPluginValidationIntegrationSpec.

    • -123
    • +0
    ./ValidatePluginsConfiguredByPluginIntegrationTest.groovy
Display nice type names consistently for validation warnings

Also use the new expectDeprecationWarning(String) to check for emitted runtime validation warnings.

    • -5
    • +5
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -5
    • +12
    ./RuntimePluginValidationIntegrationTest.groovy
  1. … 2 more files in changeset.
Consistently check for path sensitivity warnings during runtime

    • -94
    • +31
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -3
    • +4
    ./RuntimePluginValidationIntegrationTest.groovy
    • -6
    • +10
    ./ValidatePluginsIntegrationTest.groovy
  1. … 13 more files in changeset.
Correctly report everything

    • -7
    • +7
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +6
    ./RuntimePluginValidationIntegrationTest.groovy
  1. … 19 more files in changeset.
Correctly report everything

    • -7
    • +7
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +6
    ./RuntimePluginValidationIntegrationTest.groovy
  1. … 19 more files in changeset.
Consolidate type validation

Use ValidateContext with a few standard implementations instead of the many different interfaces and implementations we used to collect valdiation problems before. This fixes issues with types being displayed inconsistently.

The implementation is not fully correct yet: we now fail to display the correct type for problems that are bound to a type instead of a property.

    • -7
    • +7
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -9
    • +1
    ./RuntimePluginValidationIntegrationTest.groovy
  1. … 46 more files in changeset.
Use nicer way to assert validation output

    • -46
    • +27
    ./ValidatePluginsIntegrationTest.groovy
Remove unnecessary dependency

The plugin should apply it already.

    • -4
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Only test validating external types for static validation

    • -90
    • +0
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -10
    • +0
    ./RuntimePluginValidationIntegrationTest.groovy
    • -10
    • +86
    ./ValidatePluginsIntegrationTest.groovy
Remove unnecessary test requirement

    • -4
    • +0
    ./AbstractPluginValidationIntegrationSpec.groovy
Migrate "reports conflicting types when property is replaced"

    • -0
    • +35
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -36
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Migrate "can validate task classes using types from other projects"

    • -0
    • +57
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +5
    ./RuntimePluginValidationIntegrationTest.groovy
    • -52
    • +5
    ./ValidatePluginsIntegrationTest.groovy
Ensure that the validated task is executed, not that it's the only one

    • -2
    • +2
    ./RuntimePluginValidationIntegrationTest.groovy
Migrate "can validate task classes using external types"

    • -0
    • +37
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -0
    • +5
    ./RuntimePluginValidationIntegrationTest.groovy
    • -31
    • +5
    ./ValidatePluginsIntegrationTest.groovy
Migrate "detects annotations on setter methods"

    • -0
    • +54
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -56
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Migrate "detects annotations on non-property methods"

    • -0
    • +36
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -39
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Migrate "detects annotations on private getter methods"

    • -0
    • +42
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -45
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Migrate "detects problems with file inputs"

    • -0
    • +83
    ./AbstractPluginValidationIntegrationSpec.groovy
    • -82
    • +0
    ./ValidatePluginsIntegrationTest.groovy
Allow distinguishing between errors and warnings emitted in strict mode

    • -1
    • +19
    ./AbstractPluginValidationIntegrationSpec.groovy