Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace some direct usages of `DefaultConfigurableFileCollection` with `FileCollectionFactory`.

  1. … 50 more files in changeset.
Introduce an internal factory to create `JavaForkOptions`, to encapsulate the service(s) needed to create instances of this type and decouple clients from this detail. This could/should move to `ObjectFactory` or some other public factory type.

  1. … 41 more files in changeset.
Introduce an internal factory to create `JavaForkOptions`, to encapsulate the service(s) needed to create instances of this type and decouple clients from this detail. This could/should move to `ObjectFactory` or some other public factory type.

  1. … 41 more files in changeset.
spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Signed-off-by: Bo Zhang <bo@gradle.com>

  1. … 2 more files in changeset.
Tweak the output produced by `TreeFormatter`.

  1. … 36 more files in changeset.
Move `TreeFormatter` out of core and decouple from `TreeVisitor` by introducing an interface to represent something that can receive diagnostic information.

    • -3
    • +2
    ./play/internal/DefaultPlayApplicationBinarySpecTest.groovy
  1. … 68 more files in changeset.
Allow the services required by a given class to be queried prior to creating any instances of that class. Use this to allow `ArtifactTransformDependencies` to be injected into artifact transforms using any of the service injection patterns (that is, via a constructor or a getter).

  1. … 127 more files in changeset.
Replace most direct usages of `DirectInstantiator` with indirect usages via `InstantiatorFactory` or test fixtures instead. This means more consistent behaviour in unit tests because the objects under test will behave more similarly to how they do at runtime. This also allows the decision of how the instantiation should behave to live in as few places as possible, so this can be more easily evolved and contextualized.

    • -3
    • +16
    ./play/plugins/PlayDistributionPluginTest.groovy
  1. … 60 more files in changeset.
Fix play unit test

Get rid of TaskExecutionHistory

  1. … 13 more files in changeset.
Don't attempt to change a worker's working dir

Since Java 11 no longer supports changing the working directory of a

running process, a worker's working dir is now always

`GRADLE_USER_HOME/workers`.

Setting the working directory of a worker via the fork options of

`WorkerConfiguration` is now prohibited.

Resolves #7323.

  1. … 26 more files in changeset.
Move classpath fingerprinting to its own package

  1. … 30 more files in changeset.
Remove unnecessary resolution of the Play toolchain

    • -11
    • +1
    ./play/plugins/PlayTestPluginTest.groovy
  1. … 1 more file in changeset.
Separate `ITaskFactory` from `NamedEntityInstantiator<Task>` so that the instantiator is applied as a decoration over the factory.

    • -2
    • +2
    ./play/internal/DefaultPlayApplicationBinarySpecTest.groovy
  1. … 37 more files in changeset.
Replace internal `SourceDirectorySetFactory` with a method on public `ObjectFactory` service, to allow plugins to create instances of this type without resorting to using internal types.

  1. … 44 more files in changeset.
Remove Play 2.2 support

This commit removes support for Play Framework 2.2 which was previously

deprecated.

Signed-off-by: Ben McCann <ben@benmccann.com>

  1. … 13 more files in changeset.
Use the fingerprint package

  1. … 86 more files in changeset.
Rename Snapshotter -> Fingerprinter

  1. … 37 more files in changeset.
Use PathToFileResolver where possible (#5805)

  1. … 39 more files in changeset.
Re-enable Play/Scala tests on Java 9+ (#5593)

Almost all Play/Scala tests were ignored on Java 9/10, which makes it lack coverage. This PR does:

- Update Scala version to Java9-compatible version according to [JDK compatibility](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html).

- Update default Play version to latest 2.6.15, which supports Java 9/10

- Adjust corresponding samples. Previous default Play version 2.3.10 was too old (release at 2014).

- Ignored the tests which can't work on Java 9+.

- Separate Play test resources with different versions. For example, Play 2.6 uses `build.gradle` and `Play 2.4/2.5` uses `build.gradle.old`.

- Previously `AbstractMultiVersionPlayContinuousBuildIntegrationTest` didn't have `targetPlatform` configuration, which made multi-version tests meaningless

- Fix `play-logback` configuration for `2.5.18`.

  1. … 169 more files in changeset.
Normalize `ModuleIdentifier`

This commit reworks the `ComponentModuleIdentifier`/`ComponentModuleSelector`/`ModuleVersionSelector`

classes to use `ModuleIdentifier` under the hood, instead of storing denormalized strings. This has

the advantage that we can reduce the use of the module identifier factory, which is called very

often during dependency resolution. Sharing instances reduces the need for conversions, and makes

comparisons faster.

    • -1
    • +2
    ./play/plugins/PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 164 more files in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

This reverts commit 13eaebc2b1244511dcbff4c59cd41253e3b69642.

    • -0
    • +5
    ./play/plugins/PlayTestPluginTest.groovy
  1. … 88 more files in changeset.
Revert "Dogfood ImmutableFileCollection on production code (#4988)"

This reverts commit 834632674ca29b6fd190857947338b2b54a9bb62.

The commit caused a bug in incremental compilation, causing changes

to go undetected.

    • -5
    • +0
    ./play/plugins/PlayTestPluginTest.groovy
  1. … 88 more files in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

Use ImmutableFileCollection in production code

    • -0
    • +5
    ./play/plugins/PlayTestPluginTest.groovy
  1. … 88 more files in changeset.
Dogfood ImmutableFileCollection in tests (#4972)

Reduce the number of static factory methods from ImmutableFileCollection

Use layout.fileFor() in a smoke test

  1. … 32 more files in changeset.
Don't reload play application after assets change

Signed-off-by: Bo Zhang <bo@gradle.com>

  1. … 10 more files in changeset.
Remove FileResolver.resolveLater(), since resolve() is cheap now

This is a follow-up to making FileResolver faster. It is now

so cheap that resolveLater() no longer serves any purpose. The

result can no longer be different over time either, as resolve()

no longer looks at the file system.

Removing that code saves a lot of memory when repeatedly looking

up the build directory of a project (which happens a lot).

  1. … 9 more files in changeset.
Fix #3029: Use correct server class when distributing Play applications (#3314)

Use correct server class when distributing Play applications

Fix https://github.com/gradle/gradle/issues/3029

    • -3
    • +19
    ./play/plugins/PlayDistributionPluginTest.groovy
  1. … 1 more file in changeset.
Fix #2999: runPlayBinary needs to be adapted for Play 2.6 (#3018)

Scala 2.12 as the preferred version when using Play 2.6

Fix https://github.com/gradle/gradle/issues/2999

Add Play 2.6 and scala 2.12 support.

    • -35
    • +22
    ./play/internal/PlayPlatformResolverTest.groovy
  1. … 15 more files in changeset.
Fix sanity check build with new workingDir property of PlayRun

  1. … 3 more files in changeset.