Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove unit tests covered by integration tests in Play project

    • -93
    • +0
    ./PlayDistributionPluginTest.groovy
Fix Play unit test

Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 500 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 497 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 506 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 501 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 501 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -168
    • +0
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
    • -270
    • +0
    ./PlayDistributionPluginTest.groovy
  1. … 497 more files in changeset.
Allow the services required by a given class to be queried prior to creating any instances of that class. Use this to allow `ArtifactTransformDependencies` to be injected into artifact transforms using any of the service injection patterns (that is, via a constructor or a getter).

  1. … 127 more files in changeset.
Replace most direct usages of `DirectInstantiator` with indirect usages via `InstantiatorFactory` or test fixtures instead. This means more consistent behaviour in unit tests because the objects under test will behave more similarly to how they do at runtime. This also allows the decision of how the instantiation should behave to live in as few places as possible, so this can be more easily evolved and contextualized.

    • -3
    • +16
    ./PlayDistributionPluginTest.groovy
  1. … 60 more files in changeset.
Fix play unit test

Remove unnecessary resolution of the Play toolchain

  1. … 1 more file in changeset.
Re-enable Play/Scala tests on Java 9+ (#5593)

Almost all Play/Scala tests were ignored on Java 9/10, which makes it lack coverage. This PR does:

- Update Scala version to Java9-compatible version according to [JDK compatibility](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html).

- Update default Play version to latest 2.6.15, which supports Java 9/10

- Adjust corresponding samples. Previous default Play version 2.3.10 was too old (release at 2014).

- Ignored the tests which can't work on Java 9+.

- Separate Play test resources with different versions. For example, Play 2.6 uses `build.gradle` and `Play 2.4/2.5` uses `build.gradle.old`.

- Previously `AbstractMultiVersionPlayContinuousBuildIntegrationTest` didn't have `targetPlatform` configuration, which made multi-version tests meaningless

- Fix `play-logback` configuration for `2.5.18`.

  1. … 170 more files in changeset.
Normalize `ModuleIdentifier`

This commit reworks the `ComponentModuleIdentifier`/`ComponentModuleSelector`/`ModuleVersionSelector`

classes to use `ModuleIdentifier` under the hood, instead of storing denormalized strings. This has

the advantage that we can reduce the use of the module identifier factory, which is called very

often during dependency resolution. Sharing instances reduces the need for conversions, and makes

comparisons faster.

    • -1
    • +2
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 164 more files in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

This reverts commit 13eaebc2b1244511dcbff4c59cd41253e3b69642.

  1. … 88 more files in changeset.
Revert "Dogfood ImmutableFileCollection on production code (#4988)"

This reverts commit 834632674ca29b6fd190857947338b2b54a9bb62.

The commit caused a bug in incremental compilation, causing changes

to go undetected.

  1. … 88 more files in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

Use ImmutableFileCollection in production code

  1. … 88 more files in changeset.
Fix #3029: Use correct server class when distributing Play applications (#3314)

Use correct server class when distributing Play applications

Fix https://github.com/gradle/gradle/issues/3029

    • -3
    • +19
    ./PlayDistributionPluginTest.groovy
  1. … 1 more file in changeset.
Wire build gate into Play runner classes

    • -36
    • +0
    ./PlayCoffeeScriptPluginTest.groovy
  1. … 20 more files in changeset.
Add unit test coverage for #1857

    • -0
    • +25
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
Use `ArtifactCollection` in place of `ResolvedConfiguration.resolvedArtifacts`

    • -7
    • +7
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 1 more file in changeset.
Revert De-duplicate commonly used immutable objects in dependency resolution and IDE changes

Commits reverted:

- 807b1e4f8d1585d93c1de3e9ca83d99d0819e2d2

- 9482b0b05374253cafdb776550d7016385912e04

- 4ecead06b53ec6b0f15c517bf0d0c6a74c3b3c05

- db1135a8a5f1c507e0df3c03ad12ddc963799e4d

- 7350bcbae30a777909cec74ebfd5a91d2c89081e

Additionally, minor changes to avoid usage of introduced

classes and methods from subsequent commits.

Issue: gradle/gradle-private#563

    • -1
    • +1
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 109 more files in changeset.
De-duplicate (= intern) some instances in dependency resolution

- Reduce memory usage of dependency resolution by de-duplicating the

most commonly used immutable instances.

- Objects aren't strictly immutable: displayName is calculated lazily

- solution is thread-safe without synchronization

- lazy calculation is needed for efficient interning since a lookup

will always create a new instance.

- Use strong references in some instance interners

- strong references cause less GC overhead than weak references

- Strong references:

DefaultModuleIdentifier

DefaultModuleVersionIdentifier

DefaultModuleVersionSelector

DefaultModuleComponentIdentifier

DefaultModuleComponentSelector

DefaultProjectComponentSelector

- Weak references:

DefaultLibraryBinaryIdentifier

DefaultLibraryComponentSelector

DefaultIvyArtifactName

- Both reference types:

DefaultBuildIdentifier

DefaultProjectComponentIdentifier

- The reason for special handing is that DefaultBuildIdentifier

has a state field "current" as part of the instance which

isn't part of equals/hashCode.

+review REVIEW-6277

    • -1
    • +1
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 104 more files in changeset.
Moved test factory methods out of production code

    • -1
    • +1
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 19 more files in changeset.
Always use factory method to create ProjectComponentId

    • -7
    • +5
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 24 more files in changeset.
Revert attempt to be clever about renaming jar files in Play distribution

+review REVIEW-5766

    • -11
    • +1
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 3 more files in changeset.
Don't prefix files in play distribution when prefix == file-name

+review REVIEW-5766

    • -24
    • +34
    ./PlayDistributionPluginRenameArtifactFilesTest.groovy
  1. … 2 more files in changeset.
Fixed `PlayCoffeeScriptPlugin` for changes to dependencies implied by `@BinaryTasks`.

    • -29
    • +10
    ./PlayCoffeeScriptPluginTest.groovy
  1. … 1 more file in changeset.
Fixed `PlayJavaScriptPlugin` for changes to `@LanguageType`.

    • -29
    • +10
    ./PlayJavaScriptPluginTest.groovy
  1. … 1 more file in changeset.
Address review items

+review REVIEW-5772

  1. … 2 more files in changeset.