Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 497 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 494 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 503 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 498 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 498 more files in changeset.
Remove play framework support from Gradle distribution

This is superseded by: https://gradle.github.io/playframework/

This commit removes:

- The `platform-play` and `ide-play` subprojects

- The documentation for the functionality provided by these projects

    • -48
    • +0
    ./reflect/ScalaOptionInvocationWrapper.java
  1. … 494 more files in changeset.
Remove deprecated Class.newInstance() (#6496)

`Class.newInstance()` was deprecated in Java 9.

  1. … 34 more files in changeset.
Fix deprecation warning

Calling Class.newInstance() is deprecated on Java 9 and caused

compilation to fail for `platformPlay`.

Use interruptible FileChannel to read

  1. … 2 more files in changeset.
Replace usage of `String#format` with good old string concatenation

The rationale behind this change is that while `String#format` is usually admitted as good for readability (this is arguable),

in practice it is very bad for performance. Since Java 6, the JVM (the JIT, to be correct) does a pretty good job at optimizing

string concatenation. However, it is only capable to do so if we're using "dirty" string concatenations (using `+`), or `StringBuilder`.

However, usage of `StringBuilder` is not recommended either for 2 reasons:

1. it significantly decreases code readability

2. in Java 9, String concatenation is even more optimized thanks to `invokedynamic`, and code using `StringBuilder` will *not* benefit

from this optimization.

There are sill leftover `String#format` calls in the code, in the following cases:

- the call is used to generate an exception message. That's 90% of the remaining calls.

- the call is obviously a debug message, often used in `toString` (because as we all know, `toString` should only be used for debugging)

- the format includes specific number formatting patterns

- I missed it

  1. … 226 more files in changeset.
Remove package-info for o.g.scala.internal.reflect

The current convention is not to add package-info.java files in internal

packages. This one was the lone exception.

add support for Play 2.4.x

+review REVIEW-5529

    • -0
    • +71
    ./reflect/ScalaObject.java
  1. … 18 more files in changeset.
Reformat code in the platform-play project

  1. … 33 more files in changeset.
Replaced Function<Object[], Object> with a ScalaMethod type

- Not yet generified for return type

- No nice way to wrap scala return values

- No nice way to create scala input types

+review REVIEW-5246

    • -0
    • +80
    ./reflect/ScalaMethod.java
    • -0
    • +23
    ./reflect/ScalaReflectionUtil.java
  1. … 8 more files in changeset.
Moved org.gradle.play.internal.scala.reflection.util -> org.gradle.scala.internal.reflect

    • -0
    • +40
    ./reflect/ScalaCodecMapper.java
    • -0
    • +38
    ./reflect/ScalaListBuffer.java
    • -0
    • +48
    ./reflect/ScalaOptionInvocationWrapper.java
    • -0
    • +63
    ./reflect/ScalaUtil.java
    • -0
    • +23
    ./reflect/package-info.java
  1. … 11 more files in changeset.