Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add Tar task to play distribution

    • -10
    • +25
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 7 more files in changeset.
Fix spelling of PLAY_REPOSITORIES in test fixtures

    • -2
    • +2
    ./PlayApplicationPluginIntegrationTest.groovy
    • -2
    • +2
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 11 more files in changeset.
Deduplicate project dependencies in Play distributions

- Changed stage task to Sync because when we change dependencies, we were including both old and new

- Add a "renamer" that knows how to rename project dependencies in the playRun configuration to be unique

+review REVIEW-5766

    • -11
    • +15
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 6 more files in changeset.
Add test for overlapping play dependencies

    • -0
    • +45
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 1 more file in changeset.
Fix integration tests: we don't configure tasks for empty Twirl and Routes source sets

The language infrastructure avoids creating tasks for source sets that don't have any

sources. This was done because we _create_ a source set for every applicable language,

and we wanted to avoid the user see a compile task for every one of these when their

component only used one type of source.

So if a project applies a bunch of language plugins, we wanted to only create

the CompileCpp task if there were actually Cpp sources present.

A better approach to achieve this might be to avoid creating these empty source sets

in the first place.

    • -4
    • +6
    ./PlayApplicationPluginIntegrationTest.groovy
    • -5
    • +6
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Converted Play Twirl and Routes compilation to use language transform infrastructure

- Transform between Twirl/RoutesSourceSet and `ScalaSourceCode` output type

- Currently only applies to `PlayApplicationBinarySpecInternal` types, and still

depends on properties provided by the binary.

    • -4
    • +4
    ./PlayApplicationPluginIntegrationTest.groovy
    • -4
    • +4
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 16 more files in changeset.
Fixed typo in method name.

    • -1
    • +1
    ./PlayApplicationPluginIntegrationTest.groovy
Fixed a bunch of tests to work when the machine's line separator is not \n.

    • -6
    • +6
    ./PlayApplicationPluginIntegrationTest.groovy
    • -1
    • +1
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
    • -1
    • +1
    ./PlayJavaScriptPluginIntegrationTest.groovy
  1. … 24 more files in changeset.
Use a `@Defaults` rule to create default source directories

Revert "Change play plugins and tests to replace default source sets"

This reverts commit 97aafa43999b7e4db18b99325ffb51ca9ccdf8ec.

Revert "Fix unit test"

This reverts commit 2dffb35eae42d654161cde29b5b6c005f8f0bb40.

Revert "Change play tests to replace source sets"

This reverts commit 3431690d8e333dc608b7d2726f7fe4ab185ed4de.

Revert "Fix native test"

This reverts commit ffc5ab1e51dfc0a58478475b517366eda7180c01.

Revert "Change cunit plugin to replace rather than append src dirs"

This reverts commit 1c6f3878da758614e6bd9239b4fd1a9d769bde23.

+review REVIEW-5669

    • -4
    • +3
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 17 more files in changeset.
Change play tests to replace source sets

    • -3
    • +4
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 1 more file in changeset.
Changed play repositories configuration in integ tests to use common definition.

+review REVIEW-5582

    • -16
    • +6
    ./PlayApplicationPluginIntegrationTest.groovy
    • -12
    • +2
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 9 more files in changeset.
Test this instead in `PlayPlatformComponentReportIntegrationTest`

+review REVIEW-5596

    • -33
    • +0
    ./PlayApplicationPluginIntegrationTest.groovy
Don't render Play ToolChain in components report: it adds no value

    • -2
    • +1
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 1 more file in changeset.
Reverted the unfinished attempt to move away from ToolChain and ToolProvider to ToolResolver and ResolvedTool

- This work needs a lot more thought and speccing: reverting for now seems like the best option

+review REVIEW-5398

    • -1
    • +2
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 40 more files in changeset.
Remove trailing slash to Typesafe ivy's repo url

+review REVIEW-5535

    • -1
    • +1
    ./PlayApplicationPluginIntegrationTest.groovy
    • -1
    • +1
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 17 more files in changeset.
Make all references to the ivy typesafe repo the same

+review REVIEW-5535

    • -8
    • +6
    ./PlayApplicationPluginIntegrationTest.groovy
    • -8
    • +6
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 11 more files in changeset.
update default Play application version to 2.3.9

+review REVIEW-5521

    • -2
    • +3
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 8 more files in changeset.
use separate assets classloader that loads assets from files - use play.runsupport.AssetsClassLoader from Play's run-support library - requires Play >= 2.3.7 - run-support depends on sbt io library that is only available in Typesafe's ivy repository

+review REVIEW-5521

    • -0
    • +7
    ./PlayApplicationPluginIntegrationTest.groovy
    • -0
    • +7
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 25 more files in changeset.
Use @LanguageType registration consistently in Play support (where possible)

+review REVIEW-5375

    • -1
    • +1
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Rename default source sets for JavaScript and CoffeeScript in a Play app

+review REVIEW-5375

    • -4
    • +3
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
    • -2
    • +2
    ./PlayJavaScriptPluginIntegrationTest.groovy
  1. … 9 more files in changeset.
Tweak Play framework task names for readability

    • -6
    • +6
    ./PlayApplicationPluginIntegrationTest.groovy
    • -6
    • +6
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 8 more files in changeset.
Better names for Play source sets/tasks

- routeSources -> routes

- twirlCompileX -> compileX

- routesCompileX -> compileX

+review REVIEW-5377

    • -5
    • +5
    ./PlayApplicationPluginIntegrationTest.groovy
    • -4
    • +4
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 10 more files in changeset.
Combine 2 unrolled tests into 1

+review REVIEW-5375

    • -19
    • +20
    ./PlayApplicationPluginIntegrationTest.groovy
Improved sorting of source sets in components report

    • -18
    • +1
    ./PlayApplicationPluginIntegrationTest.groovy
    • -2
    • +2
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
    • -2
    • +2
    ./PlayJavaScriptPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Include label for source directory in components report

    • -10
    • +10
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 13 more files in changeset.
Removing references to PlayToolChain in favor of ToolResolver

+review REVIEW-5398

    • -2
    • +1
    ./PlayApplicationPluginIntegrationTest.groovy
  1. … 7 more files in changeset.
Migrating play tool resolution from ToolProvider to ToolChain

+review REVIEW-5398

    • -0
    • +5
    ./PlayApplicationPluginGoodBehaviourIntegrationTest.groovy
  1. … 7 more files in changeset.
Revert "Copy binary tasks to the tasks node, rather than through the TaskContainer."

Breaks the native tests in a way that needs a redesign.

This reverts commit 1e41d721da3bcecbd54e5e52e9d6e12fad6e6ef2.

    • -12
    • +4
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
  1. … 19 more files in changeset.
Copy binary tasks to the tasks node, rather than through the TaskContainer.

+review REVIEW-5382

    • -4
    • +12
    ./PlayCoffeeScriptPluginIntegrationTest.groovy
  1. … 19 more files in changeset.
Rewiring twirl and routes -> scala pipeline to be cleaner and more implicit

+review REVIEW-5377

    • -2
    • +8
    ./PlayApplicationPluginIntegrationTest.groovy
    • -2
    • +2
    ./PlayDistributionPluginIntegrationTest.groovy
  1. … 12 more files in changeset.