Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Software Model @UnsupportedWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -0
    • +2
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -5
    • +2
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 74 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -0
    • +2
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -5
    • +2
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 75 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -0
    • +2
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -5
    • +2
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 75 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -0
    • +2
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -5
    • +2
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 75 more files in changeset.
Improve documented deprecation warning assertions

Allow using /current/ in the documentation path in the assertion. This will make it easier to read/verify the documentation linked to, while actually asserting against the current version behind the scenes.

    • -2
    • +3
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -3
    • +4
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 61 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +6
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +6
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +6
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +6
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +6
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +6
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +6
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +6
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 51 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 52 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 41 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 58 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Expect deprecation warnings in tests

    • -1
    • +2
    ./AutoTestedSamplePlatformJvmIntegrationTest.groovy
    • -1
    • +5
    ./JvmComponentPluginGoodBehaviourTest.groovy
    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 53 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -5
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :platformJvm

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
Annotate integ tests failing with instant execution in :platformJvm

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./JvmComponentPluginIntegrationTest.groovy
Simplified the naming scheme used to the output directories of JVM binaries.

Reused `BinaryNamingScheme` to calculate the output directories for these binaries.

Also added classes dir, resources dir and API jar output paths to components report.

    • -1
    • +1
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 24 more files in changeset.
Replaced a bunch of usages of `$('p')` with `$.p`

    • -10
    • +10
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 32 more files in changeset.
Added convenience methods for generating task names to `BinaryTasksCollection`.

This allows a plugin to create tasks for a binary without needing to care about where in the model the binary might happen to live.

    • -4
    • +4
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 6 more files in changeset.
Changed the JVM and native component plugins to use names for binaries that reflect the role they play.

Now that more than one component may have a binary with a given name, use:

- `jar` as the name for a Jar binary that belongs to a JVM library

- `executable` as the name for an executable that belongs to a native application

- `sharedLibrary` and `staticLibrary` as the name for the binaries of a native library.

These can later turn into static properties of the appropriate `ComponentSpec` types.

There is a breaking change in this commit: the lifecycle task name and output directory name of the binaries of components with multiple variants now include the component name at the start of the name, rather than somewhere in the middle.

    • -4
    • +4
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 26 more files in changeset.
Polish indentation in JvmComponentPluginIntegrationTest

Like in commit 526ed7, this change indents heredoc-style triple-quoted

strings for readability, this time in `JvmComponentPluginIntegrationTest`.

The rationale for doing this here, and continuing to do it wherever

encountered, is that the indented approach is already more prevalent

throughout the codebase:

# all instances of multiline strings appended to build files:

$ git ls-files | grep \.groovy$ |

xargs git grep 'buildFile <<' | wc -l

1955

# the subset of the above that are intended:

$ git ls-files | grep \.groovy$ |

xargs git grep -h -A1 'buildFile <<' |

egrep -v '(^--|buildFile)' | egrep '^($| )' | wc -l

1090

# the subset of the above that are not indented:

$ git ls-files | grep \.groovy$ |

xargs git grep -h -A1 'buildFile <<' |

egrep -v '(^--|buildFile)' | egrep -v '^($| )' | wc -l

819

Thus, on the dual bases of better readability and existing precedent,

this commit humbly suggests the indented style be favored in the future.

    • -138
    • +136
    ./JvmComponentPluginIntegrationTest.groovy
Remove test fixture that enables transformed model rules DSL. Not required any more.

    • -5
    • +1
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 43 more files in changeset.
Changed a few more int tests to use `binaries` model element instead of `binaries` project extension.

    • -6
    • +7
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 7 more files in changeset.
Changed a bunch of int tests to use `binaries` from model land rather than legacy land.

    • -7
    • +9
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 11 more files in changeset.
Don't use 'binaries' extension in platformJvm project

    • -9
    • +12
    ./JvmComponentPluginIntegrationTest.groovy
Removed `JvmComponentExtension` now that model DSL is improved

- Updated test for configuring jar binary of jvm library to use model DSL

    • -8
    • +8
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 5 more files in changeset.
Change the return type of BinarySpec.getBinaries() to ModelMap<BinarySpec>.

+review REVIEW-5498

    • -4
    • +4
    ./JvmComponentPluginIntegrationTest.groovy
  1. … 19 more files in changeset.