BinaryTasksModelRuleExtractorTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

    • -2
    • +4
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 24 more files in changeset.
Moved registration of `BinarySpec.tasks` from `BinaryBasePlugin` to `BaseBinarySpec`.

Also use the descriptor of a `BinarySpec` or `ComponentSpec` as the descriptor for its children, consistent with the approach used for the children of a struct.

    • -2
    • +2
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 15 more files in changeset.
`ModelAction` no longer needs to be parameterized.

    • -1
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 35 more files in changeset.
Treat `@RuleInput` properties on `RuleSource` types as references to implicit inputs for all rules on the rule source.

Moved responsibility for applying a rule to a particular scope up from `ModelRegistry` to `ModelRuleExtractor`. Now, all `RuleAction` instances applied to a `ModelRegistry` are applied relative to the root element, and it is the caller's responsibility to scope the action as required before registering it.

+review REVIEW-5756

    • -2
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 16 more files in changeset.
Use contextualized `RuleInvoker` to run `@BinaryTasks` rule methods.

+review REVIEW-5756

    • -3
    • +2
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 6 more files in changeset.
Reworked the parameters to `ExtractedModelRule.apply()` so that per-application context, such as explicit bindings, can be provided.

+review REVIEW-5756

    • -3
    • +5
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 12 more files in changeset.
Moved some classes from o.g.model.internal.core to o.g.model.internal.inspect.

Also moved a class that was only used by a single test to live in that test class.

+review REVIEW-5756

    • -0
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 27 more files in changeset.
Collect several more `RuleSource` validation problems rather than failing on first problem.

In particular, problems with `@ComponentBinaries` and `@BinaryTasks` are collected.

+review REVIEW-5739

    • -12
    • +35
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 7 more files in changeset.
More improvements to validation of a RuleSource type.

- Fixed NPE when a rule method has no parameters.

- Collect more kinds of validation failures, rather than failing on first of these kinds of failures.

- Validate that the first parameter of a `@Rules` metod is assignable to `RuleSource`

+review REVIEW-5739

    • -2
    • +2
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 19 more files in changeset.
Add type parameter to ModelAction

AbstractModelAction already had a type parameter, so ModelAction should

have one too.

+review REVIEW-5738

    • -1
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 36 more files in changeset.
Moved test interfaces back to their tests themselves

Since IBM JDK 6 is not throwing errors about these anymore, might as

well move them back to the tests they belong to.

+review REVIEW-5658

    • -1
    • +3
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 21 more files in changeset.
Model actions don't get access automatically to node view

+review REVIEW-5629

    • -1
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 29 more files in changeset.
Fixed tests

+review REVIEW-5620

    • -6
    • +15
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 4 more files in changeset.
Extract out inlined interfaces to fix issues with IBM jdk

    • -7
    • +4
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 12 more files in changeset.
Attempt to fix test on jdk 6

    • -1
    • +1
    ./BinaryTasksModelRuleExtractorTest.groovy
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

    • -12
    • +12
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 117 more files in changeset.
Test fixes after recent API change.

+review REVIEW-5353

    • -11
    • +6
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 4 more files in changeset.
Collection mutation rule specifies input taking mutation rule for particular model element

+review REVIEW-5353

    • -2
    • +3
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 68 more files in changeset.
Rules are extracted from plugins once and cached globally

+review REVIEW-5335

    • -8
    • +12
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 27 more files in changeset.
Rename rule definition handlers to rule extractors

+review REVIEW-5335

    • -0
    • +108
    ./BinaryTasksModelRuleExtractorTest.groovy
  1. … 52 more files in changeset.