Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fail configuration if target machine is unsupported

    • -1
    • +15
    ./toolchain/ToolChainAvailabilityTest.groovy
  1. … 27 more files in changeset.
Spelling (#8199)

Fix several spelling issues.

  1. … 36 more files in changeset.
Split methods required in Worker

    • -3
    • +14
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 18 more files in changeset.
Move `TreeFormatter` out of core and decouple from `TreeVisitor` by introducing an interface to represent something that can receive diagnostic information.

    • -4
    • +4
    ./toolchain/ToolChainAvailabilityTest.groovy
  1. … 67 more files in changeset.
Decorate all domain collection container for emitting build ops (#7876)

* Update all domain object container with decorator for tracing executed callback actions

* Add decorator to a ll required occurances of DefaultDomainObjectSet

* Keep ctor for DefaultPolymorphicDomainObjectContainer as its used in gradle-idea-ext plugin

* Bring back DefaultDomainObjectSet constructor used by the android plugin

* keep backwards compatibility

    • -1
    • +2
    ./DefaultBinaryTasksCollectionTest.groovy
  1. … 122 more files in changeset.
Separate `ITaskFactory` from `NamedEntityInstantiator<Task>` so that the instantiator is applied as a decoration over the factory.

    • -2
    • +2
    ./DefaultBinaryTasksCollectionTest.groovy
  1. … 37 more files in changeset.
Remove deprecated Class.newInstance() (#6496)

`Class.newInstance()` was deprecated in Java 9.

    • -1
    • +2
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 34 more files in changeset.
Re-use `TaskDependencyResolveContext` during task graph building (#3807)

All dependency resolution in Gradle should happen via TaskDependencyResolveContext during when building the task graph. Calling `DefaultTaskDependency.getDependencies(task)` should be avoided since it creates a new `TaskDependencyResolveContext` and needs to calculate the dependencies again.

`SkipTaskWithNoActionsExecuter` now re-uses the `TaskExecutionGraph` to determine the dependencies of a task instead of re-evaluating them.

After this commit, the task properties are resolved at three places:

- When building the task graph for walking the input files

- When checking if there a task can be executed in parallel with the currently running tasks based on on the declared outputs, destroyables and task local state

- For using the task properties during task execution

The last two places could still be unified into one, but that seems to be a little bit more complicated.

  1. … 23 more files in changeset.
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

    • -2
    • +4
    ./registry/BinaryTasksModelRuleExtractorTest.groovy
    • -7
    • +9
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
    • -1
    • +3
    ./registry/ComponentBinariesModelRuleExtractorTest.groovy
  1. … 22 more files in changeset.
Cleanup unit test outputs

- 'language-java'

- 'platform-base'

- 'platform-native'

- 'platform-play'

- 'testing-native'

  1. … 11 more files in changeset.
Pass an immutable (and readable) view of the subject to `@Validate` rules.

Also added a new exception type to distinguish between mutating a read only view and mutating a closed view.

    • -0
    • +5
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 16 more files in changeset.
Fix test

    • -7
    • +0
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
    • -6
    • +4
    ./registry/ComponentBinariesModelRuleExtractorTest.groovy
Reuse `isAnnotationPresent`

    • -2
    • +3
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 1 more file in changeset.
Rename Buildable{ModelElement => ComponentSpec}

This rename better reflects the fact that (the former)

BuildableModelElement now extends ComponentSpec, and in the process

helps to eliminate the unnecessary concept of "model elements" in favor

of referring to everything in terms of components and component specs.

Javadoc in BuildableComponentSpec and certain parameters and member

variables in AbstractBuildableComponentSpec have also been updated and

renamed for clarity and consistency.

    • -0
    • +56
    ./BuildableComponentSpecTest.groovy
  1. … 24 more files in changeset.
Changed `ComponentSpecIdentifier` so that it represents components arranged in some kind of hierarchy.

    • -0
    • +67
    ./DefaultComponentSpecIdentifierTest.groovy
  1. … 2 more files in changeset.
Replace `@BinaryType` and `@LanguageType` with `@ComponentType`

The original annotations have been retained for the purpose of

deprecation but they no longer work.

    • -33
    • +30
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 64 more files in changeset.
Merged the `BinarySpec` and `LanguageSourceSet` type registries into the `ComponentSpec` registry.

The type registration annotations have not changed, however they all now act on the same registry. The annotations will be merged later.

    • -3
    • +6
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 11 more files in changeset.
Make `TestBuildableModelElement` conform to `AbstractBuildableModelElement`

Fix platform-base tests

    • -4
    • +5
    ./registry/ComponentBinariesModelRuleExtractorTest.groovy
  1. … 1 more file in changeset.
Removed some unnecessary or duplicate validation from type registration rule implementation:

- Implementation class does not necessarily need to extend some base class.

- Implementation class does not need to implement public or internal view types.

- Implementation classes does not necessarily need a no-args constructor.

    • -4
    • +0
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 14 more files in changeset.
Changed a number of usages of `ComponentSpec` to use more specific types.

    • -7
    • +7
    ./registry/ComponentBinariesModelRuleExtractorTest.groovy
  1. … 8 more files in changeset.
Removed the various subtypes of `TypeBuilder`. These have been replaced by `TypeBuilder`.

    • -2
    • +2
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 10 more files in changeset.
Replaced most usages of `BinaryTypeBuilder` and `ComponentTypeBuilder` with the more general `TypeBuilder`.

    • -16
    • +16
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 48 more files in changeset.
Changed the contract for @ComponentType, @BinaryType and @LanguageType rule methods so that they may accept a `TypeBuilder` instead of the annotation-specific subtype of `TypeBuilder`.

This will allow the removal of the annotation-specific subtypes. These subtypes are all now empty.

    • -5
    • +2
    ./registry/BinaryTypeModelRuleExtractorTest.groovy
  1. … 4 more files in changeset.
Moved `ArgWriter` to baseServices project, so that it can be used from more places.

+review REVIEW-5806

  1. … 10 more files in changeset.
Consolidated some code that transforms an argument list into an arg files.

+review REVIEW-5806

  1. … 5 more files in changeset.
Implement recursive rule application

Rules can be applied recursively to all elements of a given

type in the given scope by adding the `@Each` annotation to

the subject of the rule.

Rules are not applied to reference nodes nor to child elements

of reference nodes.

+review REVIEW-5808

    • -1
    • +4
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 10 more files in changeset.
Store rule definition in extracted rule

    • -2
    • +2
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 13 more files in changeset.
Collect rule source problems in specific class

We want to collect other types of validation errors later, thus the

rule-specific errors need to be moved out of ValidationProblemCollector.

+review REVIEW-5761

    • -2
    • +3
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 18 more files in changeset.
Avoid converting `ModelType` to `Type` and immediately back to `ModelType`.

    • -1
    • +1
    ./registry/AbstractAnnotationModelRuleExtractorTest.groovy
  1. … 2 more files in changeset.