Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixes.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 1 more file in changeset.
Fixes.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 24 more files in changeset.
Add `BuildServiceParameters.None` marker type that is used to indicate that a build service does not take any parameters, to match the pattern used in other places.

Extract some validation logic from several places so it can be reused in the places where parameterized isolated objects, such as artifact transforms or build services, are registered.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 35 more files in changeset.
Add `BuildServiceParameters.None` marker type that is used to indicate that a build service does not take any parameters, to match the pattern used in other places.

Extract some validation logic from several places so it can be reused in the places where parameterized isolated objects, such as artifact transforms or build services, are registered.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 35 more files in changeset.
Fail configuration if target machine is unsupported

  1. … 27 more files in changeset.
Spelling (#8199)

Fix several spelling issues.

  1. … 36 more files in changeset.
Split methods required in Worker

  1. … 18 more files in changeset.
Move `TreeFormatter` out of core and decouple from `TreeVisitor` by introducing an interface to represent something that can receive diagnostic information.

  1. … 67 more files in changeset.
Add some validation of extension constructors, and tweak some error messages.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 15 more files in changeset.
Remove some direct usages of `ClassGenerator` and `DirectInstantiator` from outside of the `Instantiator` infrastructure.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 3 more files in changeset.
Decorate all domain collection container for emitting build ops (#7876)

* Update all domain object container with decorator for tracing executed callback actions

* Add decorator to a ll required occurances of DefaultDomainObjectSet

* Keep ctor for DefaultPolymorphicDomainObjectContainer as its used in gradle-idea-ext plugin

* Bring back DefaultDomainObjectSet constructor used by the android plugin

* keep backwards compatibility

    • -1
    • +2
    ./base/internal/DefaultBinaryTasksCollectionTest.groovy
  1. … 122 more files in changeset.
Separate `ITaskFactory` from `NamedEntityInstantiator<Task>` so that the instantiator is applied as a decoration over the factory.

    • -2
    • +2
    ./base/binary/BaseBinarySpecTest.groovy
    • -2
    • +2
    ./base/internal/DefaultBinaryTasksCollectionTest.groovy
  1. … 36 more files in changeset.
Remove deprecated Class.newInstance() (#6496)

`Class.newInstance()` was deprecated in Java 9.

  1. … 34 more files in changeset.
Re-use `TaskDependencyResolveContext` during task graph building (#3807)

All dependency resolution in Gradle should happen via TaskDependencyResolveContext during when building the task graph. Calling `DefaultTaskDependency.getDependencies(task)` should be avoided since it creates a new `TaskDependencyResolveContext` and needs to calculate the dependencies again.

`SkipTaskWithNoActionsExecuter` now re-uses the `TaskExecutionGraph` to determine the dependencies of a task instead of re-evaluating them.

After this commit, the task properties are resolved at three places:

- When building the task graph for walking the input files

- When checking if there a task can be executed in parallel with the currently running tasks based on on the declared outputs, destroyables and task local state

- For using the task properties during task execution

The last two places could still be unified into one, but that seems to be a little bit more complicated.

  1. … 23 more files in changeset.
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

  1. … 22 more files in changeset.
Cleanup unit test outputs

- 'language-java'

- 'platform-base'

- 'platform-native'

- 'platform-play'

- 'testing-native'

  1. … 11 more files in changeset.
Pass an immutable (and readable) view of the subject to `@Validate` rules.

Also added a new exception type to distinguish between mutating a read only view and mutating a closed view.

  1. … 16 more files in changeset.
missing core plugin IDs

+review REVIEW-5913

  1. … 17 more files in changeset.
Fix test

Reuse `isAnnotationPresent`

  1. … 1 more file in changeset.
Rename Buildable{ModelElement => ComponentSpec}

This rename better reflects the fact that (the former)

BuildableModelElement now extends ComponentSpec, and in the process

helps to eliminate the unnecessary concept of "model elements" in favor

of referring to everything in terms of components and component specs.

Javadoc in BuildableComponentSpec and certain parameters and member

variables in AbstractBuildableComponentSpec have also been updated and

renamed for clarity and consistency.

    • -0
    • +56
    ./base/internal/BuildableComponentSpecTest.groovy
  1. … 24 more files in changeset.
Changed `ComponentSpecIdentifier` so that it represents components arranged in some kind of hierarchy.

    • -0
    • +67
    ./base/internal/DefaultComponentSpecIdentifierTest.groovy
  1. … 2 more files in changeset.
Replace `@BinaryType` and `@LanguageType` with `@ComponentType`

The original annotations have been retained for the purpose of

deprecation but they no longer work.

    • -1
    • +1
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 63 more files in changeset.
Split up `ComponentModelBasePlugin` to 2 separate plugins: one which deals with the very base `ComponentSpec` type and infrastructure, and one which deals with the higher level component types such as `LibrarySpec` and `ApplicationSpec`.

    • -2
    • +5
    ./base/plugins/BinaryBasePluginTest.groovy
    • -0
    • +58
    ./base/plugins/ComponentBasePluginTest.groovy
  1. … 13 more files in changeset.
Merged the `BinarySpec` and `LanguageSourceSet` type registries into the `ComponentSpec` registry.

The type registration annotations have not changed, however they all now act on the same registry. The annotations will be merged later.

  1. … 11 more files in changeset.
Make `TestBuildableModelElement` conform to `AbstractBuildableModelElement`

Fix platform-base tests

  1. … 1 more file in changeset.
Removed some unnecessary or duplicate validation from type registration rule implementation:

- Implementation class does not necessarily need to extend some base class.

- Implementation class does not need to implement public or internal view types.

- Implementation classes does not necessarily need a no-args constructor.

  1. … 14 more files in changeset.
Changed a number of usages of `ComponentSpec` to use more specific types.

  1. … 8 more files in changeset.
Replaced `ComponentSpecInternal` with a more specific internal interface that represents a component that is built into some intermediate format before its final outputs are produced.

This new interface is internal as it is essentially just a rename of `ComponentSpecInternal`, and will probably be replaced by something instead based on the target platform(s) of the component.

    • -2
    • +2
    ./base/binary/BaseBinarySpecTest.groovy
  1. … 17 more files in changeset.