Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

    • -1
    • +1
    ./internal/tasks/StaleOutputCleanerTest.groovy
  1. … 407 more files in changeset.
Fix tests

    • -1
    • +1
    ./internal/tasks/StaleOutputCleanerTest.groovy
  1. … 372 more files in changeset.
Polish code

    • -1
    • +0
    ./internal/tasks/StaleOutputCleanerTest.groovy
  1. … 2 more files in changeset.
Rename StaleClassCleaner to StaleOutputCleaner and add Javadoc

    • -88
    • +0
    ./internal/tasks/StaleClassCleanerTest.groovy
    • -0
    • +88
    ./internal/tasks/StaleOutputCleanerTest.groovy
  1. … 12 more files in changeset.
Merge StaleClassCleaner with SimpleStaleClassCleaner

    • -130
    • +0
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
    • -0
    • +88
    ./internal/tasks/StaleClassCleanerTest.groovy
  1. … 3 more files in changeset.
Use Deleter in cleaning stale outputs, take 2

This covers the remaining use cases:

- stale class cleanup for compilers

- stale overlapping output cleanup

    • -7
    • +10
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 30 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 162 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 285 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 285 more files in changeset.
Replace internal `SourceDirectorySetFactory` with a method on public `ObjectFactory` service, to allow plugins to create instances of this type without resorting to using internal types.

    • -3
    • +4
    ./sources/BaseLanguageSourceSetTest.groovy
  1. … 44 more files in changeset.
Delete empty package directories

When all classes of a package have been removed,

the package directory in the output directory

will now be removed as well. This ensures that

the resulting JAR will be byte-for-byte equivalent

to a clean build.

    • -12
    • +58
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 5 more files in changeset.
Delete stale generated sources on full recompiles

Fixes https://github.com/gradle/gradle/issues/4935

    • -3
    • +3
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 13 more files in changeset.
Cleanup directories when sources become empty (#2611)

Cleanup directories when sources become empty and not only files.

- Improved performance for SkipEmptySourceFilesTaskExecuter

It is not necessary to resolve a FileCollection when checking if the

previous execution had output files.

Moreover, we now record the empty output files after we deleted them,

so the task has to do less work next time.

    • -5
    • +11
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 13 more files in changeset.
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

    • -1
    • +3
    ./internal/ComponentTypeModelRuleExtractorTest.groovy
    • -1
    • +3
    ./internal/registry/LanguageTypeModelRuleExtractorTest.groovy
  1. … 23 more files in changeset.
Move JVM-component dependency resolution classes

Moved a lot of classes from ':platform-base' to ':platform-jvm',

and restructured into common `org.gradle.jvm.internal.resolve` package.

    • -75
    • +0
    ./internal/model/DefaultVariantsMetaDataTest.groovy
    • -26
    • +0
    ./internal/model/ParametrizedBinaryString.java
    • -26
    • +0
    ./internal/model/ParametrizedBinaryVariantDimension1.java
    • -24
    • +0
    ./internal/model/ParametrizedVariant.java
    • -22
    • +0
    ./internal/model/VariantDimension1.java
    • -22
    • +0
    ./internal/model/VariantDimension2.java
    • -20
    • +0
    ./internal/model/VariantDimension3.java
    • -107
    • +0
    ./internal/model/VariantsMetaDataHelperTest.groovy
  1. … 51 more files in changeset.
Move some JVM-specific resolution types into :platform-jvm

- Remove use of `UsageKind` from generic component-model dependency resolution

- Renamed and moved JVM-specific resolve context

    • -50
    • +0
    ./internal/resolve/LocalComponentResolveContextTest.groovy
  1. … 10 more files in changeset.
Revert "Expose per-property previous task output files"

This reverts commit 49d7688ffcff55bcbb915f615449b8f47c43d043.

+review REVIEW-6141

    • -4
    • +8
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 28 more files in changeset.
Expose per-property previous task output files

Output files from the previous execution were accessible as a single file collection previously. Now it is possible to query per-property instead. This simplifies the logic somewhat (no need to filter files belonging to other properties). This is also a step towards a more optimal implementation for output directory snapshots, where we can reconstruct the absolute paths of files from the directory path and relative paths of files (instead of storing the full absolute path).

+review REVIEW-6141

    • -8
    • +4
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 27 more files in changeset.
Clarify and document internal code

+review REVIEW-6141

    • -4
    • +4
    ./internal/tasks/SimpleStaleClassCleanerTest.groovy
  1. … 5 more files in changeset.
Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

    • -5
    • +2
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 97 more files in changeset.
Use old API methods for task inputs and outputs

Will revert deprecation in next commit.

+review REVIEW-6038

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 38 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 199 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 199 more files in changeset.
Bind task output files to properties

This change introduces a binding between task properties and output files. Output annotations automatically register property values to the corresponding property name.

The `TaskOutputs` API gained new methods with an `include` prefix that allow more flexible configuration of output properties, including specifying the property name to bind the files to. The old methods have been deprecated.

Properties that were not assigned a property name will be bound to a sequence of pseudo names like `$1`, `$2` etc.

+review REVIEW-6038

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 41 more files in changeset.
Changed unit tests to use Project or ProjectInternal instead of the implementation classes.

    • -2
    • +2
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 32 more files in changeset.
Replace `TaskOutputs.files()` with `file()` in tests

In preparation of deprecating `TaskOutputs.files()`

+review REVIEW-6010

    • -1
    • +1
    ./plugins/LifecycleBasePluginTest.groovy
  1. … 3 more files in changeset.