Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
make inner classes static where possible

Signed-off-by: Steven Crockett <crockett.j.steven@gmail.com>

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
  1. … 42 more files in changeset.
Apply `Inner class may be 'static'` inspection the whole project

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
  1. … 41 more files in changeset.
Apply `Anonymous type can be replaced with lambda` inspection the whole project

    • -14
    • +5
    ./BinaryTasksModelRuleExtractor.java
  1. … 665 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -2
    • +2
    ./ComponentBinariesModelRuleExtractor.java
  1. … 907 more files in changeset.
Organize imports

  1. … 338 more files in changeset.
Replace anonymous classes with lambdas

    • -14
    • +5
    ./BinaryTasksModelRuleExtractor.java
  1. … 710 more files in changeset.
Replace anonymous classes with lambdas

    • -13
    • +5
    ./BinaryTasksModelRuleExtractor.java
  1. … 694 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 899 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 899 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 887 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 894 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 899 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./AbstractAnnotationDrivenComponentModelRuleExtractor.java
    • -0
    • +6
    ./ComponentModelBaseServiceRegistry.java
    • -9
    • +9
    ./ComponentTypeModelRuleExtractor.java
  1. … 899 more files in changeset.
Revert "Use Java 8-compatible variant of Guava"

  1. … 25 more files in changeset.
Revert "Merge pull request #8991 from gradle/lptr/core/use-guava-java-8"

This reverts commit b3c791db65d344ddbe1878b56db41761db385aa5, reversing

changes made to 29c75bff79d89cfd6f69335a6bd056f1bdf1d160.

  1. … 25 more files in changeset.
Work around Java 6 compatibility issues

  1. … 21 more files in changeset.
Work around Java 6 compatibility issues

  1. … 21 more files in changeset.
Work around Java 6 compatibility issues

  1. … 21 more files in changeset.
Work around Java 6 compatibility issues

  1. … 21 more files in changeset.
Separate `ITaskFactory` from `NamedEntityInstantiator<Task>` so that the instantiator is applied as a decoration over the factory.

  1. … 37 more files in changeset.
Replace usages of org.gradle.api.Nullable

With javax.annotation.Nullable.

    • -3
    • +18
    ./BinaryTasksModelRuleExtractor.java
    • -2
    • +10
    ./ComponentBinariesModelRuleExtractor.java
    • -3
    • +15
    ./ComponentTypeModelRuleExtractor.java
  1. … 458 more files in changeset.
Introduce a ExecutionScopeServices between BuildSession and Build scopes

- This isn't wired into anything, so no services actually work yet.

    • -15
    • +2
    ./ComponentModelBaseServiceRegistry.java
  1. … 30 more files in changeset.
Removed some deprecated software model type.

    • -4
    • +0
    ./ComponentModelBaseServiceRegistry.java
    • -52
    • +0
    ./DeprecatedAnnotationsInspector.java
  1. … 6 more files in changeset.
Added `ModelElement` interface, which is a view that provides some basic meta-data for a particular model element. Currently supported by `ModelMap` and `ModelSet` elements.

Also changed the generated display name for `ModelSet` views to be consistent with that provided for `ModelMap` views.

  1. … 14 more files in changeset.
Remove `ModelReference` interning

- interning, while reducing memory usage, also has a clear impact on performance of task creation

- task creation is now 5% faster

- compensates some of memory usage increase by optimizing model creation

+review REVIEW-5852

    • -14
    • +16
    ./ComponentTypeModelRuleExtractor.java
  1. … 10 more files in changeset.
ComponentBinaries rule doesn't apply to reference nodes

Rules that are applied to all descendent nodes in a scope should only

be applied to element nodes, and not to reference nodes to avoid

applying the rule multiple times.

See JIRA issue: https://issues.gradle.org/browse/GRADLE-3422

    • -5
    • +5
    ./ComponentBinariesModelRuleExtractor.java
  1. … 1 more file in changeset.
Cleaned out a bunch of TODOs

  1. … 30 more files in changeset.
Give error message with migration instructions for non longer supported annotations

+review

    • -0
    • +4
    ./ComponentModelBaseServiceRegistry.java
    • -0
    • +52
    ./DeprecatedAnnotationsInspector.java
  1. … 1 more file in changeset.
Add @Override where missing in production software model sources

Prior to this change, the affected submodules had 2044 occurrences of

the @Override annotation. With this commit, there are now 3492

occurrences. This suggests some divergence in IDE settings, either

across developers, across time, or both. At the moment, it appears that

IDEA (15 CE) is configured correctly to add @Override automatically.

This same refactoring should probably be done globally acrosse the

Gradle codebase, but has been constrained here to software model-related

submodules (a) because it is what the author is responsible for and (b)

because significant refactoring of type hierarchies is underway there

right now--the kind of work most likely to benefit from the compiler

checks that proper use of @Override affords.

Should this same refactoring be applied globally, it would be worth

looking into enforcing consistent use of @Override via checkstyle or

similar at the same time.

    • -0
    • +5
    ./ComponentModelBaseServiceRegistry.java
  1. … 419 more files in changeset.
Replace `@BinaryType` and `@LanguageType` with `@ComponentType`

The original annotations have been retained for the purpose of

deprecation but they no longer work.

    • -38
    • +0
    ./BinaryTypeModelRuleExtractor.java
    • -8
    • +0
    ./ComponentModelBaseServiceRegistry.java
    • -11
    • +165
    ./ComponentTypeModelRuleExtractor.java
    • -38
    • +0
    ./LanguageTypeModelRuleExtractor.java
  1. … 59 more files in changeset.