Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert loopback

  1. … 1 more file in changeset.
Run perf with loopback

  1. … 14 more files in changeset.
Apply `Anonymous type can be replaced with lambda` inspection the whole project

    • -8
    • +5
    ./DefaultFileLockContentionHandler.java
  1. … 666 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

    • -5
    • +5
    ./DefaultFileLockContentionHandler.java
  1. … 909 more files in changeset.
Replace anonymous classes with lambdas

    • -8
    • +5
    ./DefaultFileLockContentionHandler.java
  1. … 711 more files in changeset.
Replace anonymous classes with lambdas

    • -8
    • +5
    ./DefaultFileLockContentionHandler.java
  1. … 695 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 890 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 897 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -11
    • +11
    ./DefaultFileLockContentionHandler.java
  1. … 902 more files in changeset.
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./DefaultFileLockContentionHandler.java
  1. … 1005 more files in changeset.
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./DefaultFileLockContentionHandler.java
  1. … 999 more files in changeset.
Revert "Merge pull request #7838 from gradle/eskatos/messaging/bind-loopback-if-available"

Listening to the loopback device seems to cause some connection issues

to the daemon from IDEA. Reverting the change for now.

This reverts commit 9a940b21ee06ed0b5c83b7d88f7d191a0d7a590e, reversing

changes made to 18b1f6e10f32f623986868bb39e083b49467b16e.

  1. … 6 more files in changeset.
Release lock in a `finally { }` block.

    • -15
    • +21
    ./DefaultFileLockContentionHandler.java
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Handle missing type correctly

When communicating with an old version, the length of the received

packet will be shorter than the byte array. Now, `FileLockPacketPayload`

only reads the type when it has been received and returns UNKNOWN if it

has not. Previously, it would have worked by accident because the last

byte was zero which corresponds to the ordinal number of UNKNOWN.

  1. … 2 more files in changeset.
Make file lock packet type explicit

`FileLockCommunicator` now includes an additional byte that represents

the `FileLockPacketType` when sending packets to other processes.

`DefaultFileLockContentionHandler` now checks for the

`LOCK_RELEASE_CONFIRMATION` type instead of interpreting any packet for

a lock for which it already has received a packet as a lock release

confirmation.

Adding the additional byte will be ignored by old versions which only

read the first 9 bytes. New versions can still read packets from old

versions that do not include the byte. They use the `UNKNOWN` type in

this case. Thus, this protocol change is backwards compatible.

    • -9
    • +12
    ./DefaultFileLockContentionHandler.java
    • -0
    • +90
    ./FileLockPacketPayload.java
    • -0
    • +29
    ./FileLockPacketType.java
  1. … 2 more files in changeset.
Improve file lock contention handling

This commit improves the likelihood for lock requesters to acquire a

file lock after it is released due to contention. After the lock has

been released, the former lock holder now sends a packet to the sockets

of all requesters. While old clients will simply ignore the additional

packet, new clients will interpret it as a signal that the file lock has

been released and will try to acquire it immediately.

Issue: gradle/gradle-private#1412.

    • -12
    • +72
    ./DefaultFileLockContentionHandler.java
  1. … 12 more files in changeset.
Minor readability improvements and test cleanup

    • -3
    • +3
    ./DefaultFileLockContentionHandler.java
  1. … 1 more file in changeset.
Improve code structure and add documentation

    • -20
    • +64
    ./DefaultFileLockContentionHandler.java
Confirm to all interested parties that the lock is about to be released

    • -9
    • +6
    ./DefaultFileLockContentionHandler.java
Fix classycle issue

+review REVIEW-6562

    • -2
    • +0
    ./DefaultFileLockContentionHandler.java
    • -0
    • +113
    ./FileLockCommunicator.java
    • -0
    • +19
    ./GracefullyStoppedException.java
  1. … 4 more files in changeset.
Move org.gradle.cache.internal to persistent-cache project

+review REVIEW-6562

    • -0
    • +160
    ./DefaultFileLockContentionHandler.java
    • -0
    • +27
    ./FileLockContentionHandler.java
  1. … 183 more files in changeset.
Only send ping for lock release once

    • -16
    • +61
    ./DefaultFileLockContentionHandler.java
  1. … 4 more files in changeset.