Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Round both lastModified for CommonFileSystemTest

Some Java 8 versions on Unix only captures the

seconds in lastModified.

For example, Oracle JDK 1.8.0_181-b13 does not

capture milliseconds, while OpenJDK 1.8.0_242-b08

does.

Native platform always returns the milliseconds,

so we need to cut off the millisecond part for

comparison with the value returned by Java NIO.

    • -1
    • +1
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Round both lastModified for CommonFileSystemTest

Some Java 8 versions on Unix only captures the

seconds in lastModified.

For example, Oracle JDK 1.8.0_181-b13 does not

capture milliseconds, while OpenJDK 1.8.0_242-b08

does.

Native platform always returns the milliseconds,

so we need to cut off the millisecond part for

comparison with the value returned by Java NIO.

    • -1
    • +2
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Round both lastModified for CommonFileSystemTest

Some Java 8 versions on Unix only capture the

seconds in lastModified.

For example, Oracle JDK 1.8.0_181-b13 does not

capture milliseconds, while OpenJDK 1.8.0_242-b08

does.

Native platform always returns the milliseconds,

so we need to cut off the millisecond part for

comparison with the value returned by Java NIO.

    • -1
    • +2
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Rename FileMetadata{Snapshot -> }

Snapshot doesn't add anything to the name.

    • -7
    • +7
    ./AbstractFileMetadataAccessorTest.groovy
    • -6
    • +6
    ./FallbackFileMetadataAccessorTest.groovy
    • -3
    • +3
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
  1. … 47 more files in changeset.
Address some review feedback.

    • -16
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
    • -4
    • +4
    ./FallbackFileMetadataAccessorTest.groovy
    • -2
    • +2
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
  1. … 3 more files in changeset.
Stat named pipes as missing files

as we do when we encounter those types when walking

a directory.

    • -0
    • +12
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 4 more files in changeset.
Inline method in test

    • -5
    • +1
    ./FallbackFileMetadataAccessorTest.groovy
Add more tests for stating symlinks

    • -0
    • +41
    ./AbstractFileMetadataAccessorTest.groovy
Allow stating a symlink cycle

via native platform.

    • -0
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Allow stating a symlink cycle

via native platform.

    • -2
    • +0
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Allow stating a symlink cycle

via native platform.

    • -2
    • +0
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Allow stating a symlink cycle

via native platform.

    • -0
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Allow stating a symlink cycle

via native platform.

    • -0
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 1 more file in changeset.
Detect cycles for symlinks

in `DirectorySnapshotter`.

    • -0
    • +19
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 2 more files in changeset.
Detect cycles for symlinks

in `DirectorySnapshotter`.

    • -0
    • +19
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 2 more files in changeset.
Determine symlink access in stat

This way we can use the information when deciding what to

watch.

    • -0
    • +18
    ./AbstractFileMetadataAccessorTest.groovy
    • -0
    • +8
    ./FallbackFileMetadataAccessorTest.groovy
  1. … 9 more files in changeset.
Determine symlink access in stat

This way we can use the information when deciding what to

watch.

    • -0
    • +18
    ./AbstractFileMetadataAccessorTest.groovy
    • -0
    • +8
    ./FallbackFileMetadataAccessorTest.groovy
  1. … 9 more files in changeset.
Determine symlink access in stat

This way we can use the information when deciding what to

watch.

    • -0
    • +57
    ./AbstractFileMetadataAccessorTest.groovy
    • -0
    • +8
    ./FallbackFileMetadataAccessorTest.groovy
  1. … 9 more files in changeset.
Add a test for stating symlinks pointing to symlinks

    • -0
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
Add a test for stating symlinks pointing to symlinks

    • -0
    • +16
    ./AbstractFileMetadataAccessorTest.groovy
Add a test for NativePlatformBackedFileMetadataAccessor

    • -3
    • +4
    ./AbstractFileMetadataAccessorTest.groovy
    • -1
    • +6
    ./FallbackFileMetadataAccessorTest.groovy
    • -0
    • +53
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
Add a test for NativePlatformBackedFileMetadataAccessor

    • -3
    • +4
    ./AbstractFileMetadataAccessorTest.groovy
    • -1
    • +6
    ./FallbackFileMetadataAccessorTest.groovy
    • -0
    • +53
    ./NativePlatformBackedFileMetadataAccessorTest.groovy
Use native platform for stat by default

instead of using Java NIO APIs with a `File.exists()`

on Linux and Windows.

This is a preparation for #12966.

    • -37
    • +0
    ./Jdk7FileMetadataAccessorTest.groovy
    • -0
    • +37
    ./NioFileMetadataAccessorTest.groovy
  1. … 4 more files in changeset.
Use native platform for stat by default

instead of using Java NIO APIs with a `File.exists()`

on Linux and Windows.

This is a preparation for #12966.

    • -37
    • +0
    ./Jdk7FileMetadataAccessorTest.groovy
    • -0
    • +37
    ./NioFileMetadataAccessorTest.groovy
  1. … 4 more files in changeset.
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

    • -1
    • +1
    ./AbstractFileMetadataAccessorTest.groovy
    • -1
    • +1
    ./UnsupportedFilePermissionsTest.groovy
  1. … 406 more files in changeset.
Fix tests

    • -1
    • +1
    ./AbstractFileMetadataAccessorTest.groovy
    • -1
    • +1
    ./UnsupportedFilePermissionsTest.groovy
  1. … 371 more files in changeset.
Move Stat and Chmod to :files

  1. … 38 more files in changeset.
Move Stat and Chmod to :files

  1. … 38 more files in changeset.
TODO

    • -5
    • +5
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 45 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -5
    • +5
    ./AbstractFileMetadataAccessorTest.groovy
  1. … 44 more files in changeset.