Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Introduce convenience methods on ModelRegistry

+review REVIEW-5685

    • -5
    • +9
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 24 more files in changeset.
Fix test

+review REVIEW-5689

    • -15
    • +10
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 5 more files in changeset.
Rename ModelRegistry.create() to register() +review REVIEW-5678

    • -2
    • +2
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 67 more files in changeset.
Introduce TestNodeInitializerRegistry

Simpler singleton access to a registry in tests.

+review REVIEW-5651

    • -3
    • +2
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 6 more files in changeset.
Use an interface for injecting the inputs into a transformed rules closure. Also defer registration of configure/initialize rules closures until the projections of the subject are known.

    • -133
    • +0
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 9 more files in changeset.
Treat dynamic property references at the top level of a rule closure in the DSL as an input reference.

    • -2
    • +4
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 12 more files in changeset.
Revert direct path access for services

+review REVIEW-5645

    • -1
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -2
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 34 more files in changeset.
Mark services with `@Service`, and reference them via path in the model

Also fixes rule-cycles in Android plugin.

+review REVIEW-5640

    • -1
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +2
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 37 more files in changeset.
Get `NodeInitializerRegistry` from the model

+review REVIEW-5629

    • -1
    • +6
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +6
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 4 more files in changeset.
Fixed some more tests

+review REVIEW-5629

    • -3
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
Fixed tests

+review REVIEW-5629

    • -3
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 2 more files in changeset.
Removes unnecessary use of ModelSchemaStore

+review REVIEW-5619

    • -1
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 3 more files in changeset.
Adds a ConstructableTypesRegistry to create types that are not strictly 'managed' - NodeInitializerExtractionStrategy's can be asked what types they support - Fails the build when NodeInitializerRegistry can not find an appropriate node initializer - Removes managed type check ModelDslBacking's

+review REVIEW-5619

    • -7
    • +4
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +3
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 39 more files in changeset.
Fixed test

+review REVIEW-5617

    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
Fixed test

    • -1
    • +3
    ./internal/NonTransformedModelDslBackingTest.groovy
Introduced `NodeInitializerRegistry`

+review REVIEW-5617

    • -4
    • +5
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 46 more files in changeset.
Adds more coverage for DSL model source locator

+review REVIEW-5552

    • -1
    • +0
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 5 more files in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 30 more files in changeset.
Reimplements the format of rule binding errors - removes file seperator from build script location

+review REVIEW-5556

    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 29 more files in changeset.
Removes unnecessary delegating transformer

+review REVIEW-5552

    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 1 more file in changeset.
Model report displays a relative path to the build script for DSL based rules - Moves RelativeFileNameTransformer to core

+review

    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 19 more files in changeset.
Reorganised managed model creation to have the schema provide the creation strategy.

This allows custom schema extraction strategies to have a say in how objects are to be created.

+review REVIEW-5536

    • -3
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -3
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 48 more files in changeset.
Rename org.gradle.model.collections.ManagedSet to org.gradle.model.ModelSet.

    • -2
    • +2
    ./internal/NonTransformedModelDslBackingTest.groovy
  1. … 26 more files in changeset.
Busted InputReferences out of RuleVisitor and pushed this up so that it is visible to the action that calculates the inputs for a DSL model rule.

    • -4
    • +7
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 4 more files in changeset.
Improve efficiency of string to enum conversion for property setting.

Don't go looking for potential transforms until the dispatch fails and only go looking if property types match.

    • -2
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -2
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 15 more files in changeset.
Add support for beforeEach/afterEach rule methods to ManagedSet.

+review

    • -1
    • +2
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +2
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 14 more files in changeset.
Allow top level, managed, elements to be added to the model graph.

Example:

model {

thing(Thing) {

}

}

Works for both styles of model blocks.

+review

    • -19
    • +53
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -2
    • +53
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 26 more files in changeset.
Close off access to the project/script for rules declared in the new model DSL.

+review REVIEW-5382

    • -2
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 2 more files in changeset.
Allow model nodes to be 'ephemeral'.

Ephemeral nodes are not “stable”.

Non stable nodes are reset when the registry is stabilized, allowing the registry to be reused.

This mechanism will be used to allow the model registry to be scrubbed of nodes that hold build instance state in between reusing the model state between builds.

+review

    • -1
    • +1
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 16 more files in changeset.
Pull the error for trying to create model nodes as scopes other than root “up”.

+review REVIEW-5353

    • -3
    • +2
    ./internal/NonTransformedModelDslBackingTest.groovy
    • -1
    • +1
    ./internal/TransformedModelDslBackingTest.groovy
  1. … 25 more files in changeset.