Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Handle $('p') expressions that appear in the default value for nested closure parameters. Not handled on the top level closures yet.

  1. … 1 more file in changeset.
Remove test fixture that enables transformed model rules DSL. Not required any more.

  1. … 39 more files in changeset.
Removed speculative conversion of property references in DSL rules closures into input references. Can now only use $('p') expressions to refer to other rule elements as inputs.

  1. … 10 more files in changeset.
Changed transformed rule DSL so that rule closure can see the project and script, making transformed and non-transformed rule closures work more similarly in preparation for switching the transform on by default. Using the project/script in rule closures will later be deprecated and removed, after the syntax for input references has been simplified and replacements for some of the things on project have been added.

  1. … 4 more files in changeset.
Replaces 'node' with 'element'

  1. … 5 more files in changeset.
Treat dynamic property references at the top level of a rule closure in the DSL as an input reference.

  1. … 9 more files in changeset.
Fixed NPE when a transformed `model { }` rule take an old school polymorphic container thingy as subject.

  1. … 1 more file in changeset.
Uses a better error message for model types that cannot be constructed

+review REVIEW-5632

  1. … 8 more files in changeset.
Adds a ConstructableTypesRegistry to create types that are not strictly 'managed' - NodeInitializerExtractionStrategy's can be asked what types they support - Fails the build when NodeInitializerRegistry can not find an appropriate node initializer - Removes managed type check ModelDslBacking's

+review REVIEW-5619

  1. … 40 more files in changeset.
Tweaks to test for binding failures due to format change.

+review REVIEW-5556

Fixes binding error report format tests

+review REVIEW-5556

Improves the format of model rule bind exceptions * Adds release notes for recent model changes * Normalizes line separotors to be consistent with InProcessGradleExecuter * Removes an unused class

+review REVIEW-5556

  1. … 14 more files in changeset.
Renames mutable & immutable to subject & inputs, respectively - Adds some options to the spec

+review

  1. … 9 more files in changeset.
Second attempt to fix on windows

+review REVIEW-5552

Fixes file seperator issue

+review REVIEW-5552

Uses OS file separator to fix tests on windows.

+review REVIEW-5552

  1. … 2 more files in changeset.
Model report displays a relative path to the build script for DSL based rules - Moves RelativeFileNameTransformer to core

+review

  1. … 18 more files in changeset.
Support detecting variables as input references in the model DSL.

For now, this only works if you want to reference 'thing'.

  1. … 5 more files in changeset.
Allow the calculation of inputs for a DSL model rule to be deferred until the subject is known. Includes some regressions in validation of unbound rules and eagerly creates unmanaged elements during validation. Will be fixed later.

  1. … 8 more files in changeset.
Unnecessary inputs.

First steps at interpreting bare property reads as input references in the model DSL.

Current implementation treats any property reference chain, starting with the bare word 'thing' as a reference.

  1. … 3 more files in changeset.
Apply @Defaults rules before the closure provided to a creator rule in the transformed DSL. Added some test coverage.

  1. … 1 more file in changeset.
Remove some obsolete imports in integration tests.

+review REVIEW-5491

  1. … 38 more files in changeset.
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

  1. … 115 more files in changeset.
Allow top level, managed, elements to be added to the model graph.

Example:

model {

thing(Thing) {

}

}

Works for both styles of model blocks.

+review

    • -0
    • +121
    ./groovy/org/gradle/model/dsl/ModelDslCreationIntegrationTest.groovy
  1. … 26 more files in changeset.
Close off access to the project/script for rules declared in the new model DSL.

+review REVIEW-5382

  1. … 2 more files in changeset.
Don't use subject children as rule inputs in tests

+review REVIEW-5343

Changed DSL int test so that it does not use internal types.

Fix some more missed usages of RuleSource annotation

+review REVIEW-5359

  1. … 2 more files in changeset.
Change rule source marking from annotation to base class

+review REVIEW-5359

  1. … 71 more files in changeset.