Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Don't use subject children as rule inputs in tests

+review REVIEW-5343

Changed DSL int test so that it does not use internal types.

Fix some more missed usages of RuleSource annotation

+review REVIEW-5359

  1. … 2 more files in changeset.
Change rule source marking from annotation to base class

+review REVIEW-5359

  1. … 71 more files in changeset.
Collection mutation rule specifies input taking mutation rule for particular model element

+review REVIEW-5353

  1. … 68 more files in changeset.
Added a root node to the model graph and cleaned up MutableModelNode so that links are always added using a ModelCreator.

This means all graph additions are done by linking a node from another node, and so we can apply consistent validation and behaviour.

  1. … 10 more files in changeset.
PolymorphicDomainObjectContainer<T> instances bridged into the model are now viewed as a CollectionBuilder<T> instance from the model DSL.

- Added CollectionBuilder.named(name, action) to apply configuration to a particular element.

- Provide roughly equivalent DSL for creating and configuring elements.

  1. … 13 more files in changeset.
Temporary fix for broken int test

Extracted an interface from ModelNode for creation and mutator actions to use instead of bolting directly onto ModelNode.

  1. … 20 more files in changeset.
Changed ModelProjection to extend ModelAdapter and ModelPromise, so that various wrappers are no longer required and to reduce the object count for each model graph node.

  1. … 9 more files in changeset.
Reinstate some previously ignored test coverage due to model registry changes.

+review REVIEW-5264

  1. … 8 more files in changeset.
Ignore/fix a bunch of tests now that model elements can't be inserted at nested paths in the graph (i.e. they must be inserted via the parent).

The ignored tests will be fixed and unignored soon.

+review REVIEW-5264

  1. … 6 more files in changeset.
Don't implement Plugin in rule sources used in tests if it's not necessary

+review REVIEW-5239

  1. … 4 more files in changeset.
Introduce a feature toggle for the new model DSL, off by default.

  1. … 4 more files in changeset.
Execute rule closures in the context of other top level closures in a script.

+review REVIEW-5177

  1. … 10 more files in changeset.
Unbound inputs produce error message with line number of input declaration, and suggestions on alternatives when using model DSL

+review REVIEW-5177

  1. … 19 more files in changeset.
Test coverage for using something that is not a closure literal to define rules using DSL

+review REVIEW-5177

  1. … 2 more files in changeset.
Detect attempted use of model {} at top level with non literal closure arg.

+review REVIEW-5177

  1. … 3 more files in changeset.
Add explicit coverage of use of model {} block in script plugin with input extraction.

+review REVIEW-5177

Improve error message when invalid model path is used as rule input reference, and add test coverage.

+review REVIEW-5177

  1. … 3 more files in changeset.
Add explicit test for supporting duplicate input definitions in DSL rule.

+review REVIEW-5177

Add explicit test for inputs being finalised when used in dsl rules.

+review REVIEW-5177

  1. … 1 more file in changeset.
Expand test coverage and sync completed coverage with spec.

+review REVIEW-5177

  1. … 2 more files in changeset.
Allow use of model {} in nested scopes, but inputs are not supported.

+review REVIEW-5177

  1. … 13 more files in changeset.
Detect when model {} has been called with an untransformed closure and error with an appropriate message.

This means it was called in some kind of nested scope, or from outside of a build script.

+review REVIEW-5177

  1. … 8 more files in changeset.
Revert "Revert "Expansion/improvement of compile time transforming for model rules in the DSL.""

This reverts commit 1a9872da557fc63a2af73abc4447cb28d96a4d4d.

Problems with original implementation have been fixed.

  1. … 15 more files in changeset.
Revert "Expansion/improvement of compile time transforming for model rules in the DSL."

This reverts commit b6a2261e3ea52f22e34ca07b3e8493febe21d669.

Need to deal with the unit tests that are using the model DSL, which is no longer feasible because it relies on transforms.

  1. … 15 more files in changeset.
Expansion/improvement of compile time transforming for model rules in the DSL.

+review REVIEW-5177

    • -0
    • +72
    ./groovy/org/gradle/model/dsl/ModelDslIntegrationTest.groovy
  1. … 15 more files in changeset.
Expanded test coverage for transform.

+review REVIEW-5177

First cut at DSL model rules taking inputs.

+review

  1. … 40 more files in changeset.