Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Software Model @UnsupportedWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 73 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +8
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 871 more files in changeset.
Annotate integ tests failing with instant execution in :modelGroovy

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -0
    • +8
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Annotate integ tests failing with instant execution in :modelGroovy

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -0
    • +8
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Fix ModelDslRuleInputDetectionIntegrationSpec

    • -0
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 160 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 281 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 282 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 283 more files in changeset.
Fix model Groovy usages of output test fixtures

    • -3
    • +3
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
GRADLE-3373: Fixed model DSL transformation to allow input references as method parameters when the last method parameter is a closure.

    • -1
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -2
    • +51
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 1 more file in changeset.
Added some test coverage for using `$.p` expressions in closures passed to `Project.model { }`.

These closures are not transformed and this usage should fail. The `Project.model { }` will be removed once the model DSL supports use cases such as 'apply these rules to all projects in the build'.

    • -5
    • +39
    ./NestedModelDslUsageIntegrationSpec.groovy
Changed the contract of `ExecutionResult.output` and `error` to return the output with line separators normalized to \n.

    • -3
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 5 more files in changeset.
Added some test coverage to verify that nested rule DSL closures cannot see the delegate of outer closures.

    • -0
    • +1
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Don't treat null-safe or spread property expressions as part of the path for a `$.path` input reference.

For example, treat `$.things*.name` as `($.things)*.name`. Similarly, treat `$.thing?.name` as `($.thing)?.name`.

    • -1
    • +30
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
Fixed DSL rule extraction when a closure that looks like a nested DSL rule is nested inside a closure that is not.

    • -0
    • +25
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +57
    ./NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 2 more files in changeset.
Changed the descriptor for DSL rules so that it more closely matches the expression used in the code to reference the subject.

This change also detangles the subject path from the DSL rule descriptor, so that they can be different.

    • -4
    • +4
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 25 more files in changeset.
Use an interface for injecting the inputs into a transformed rules closure. Also defer registration of configure/initialize rules closures until the projections of the subject are known.

    • -1
    • +2
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 9 more files in changeset.
Fixed int test on windows.

    • -2
    • +3
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
Added support for `$.p` expressions to reference inputs from DSL model rules.

    • -4
    • +139
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Allow `$('p')` expressions in the default values for top level rule closure parameters.

    • -1
    • +37
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
Handle $('p') expressions that appear in the default value for nested closure parameters. Not handled on the top level closures yet.

    • -2
    • +7
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
Remove test fixture that enables transformed model rules DSL. Not required any more.

    • -5
    • +0
    ./ModelDslRuleDetectionIntegrationSpec.groovy
    • -6
    • +0
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -5
    • +0
    ./NestedModelDslUsageIntegrationSpec.groovy
  1. … 41 more files in changeset.
Removed speculative conversion of property references in DSL rules closures into input references. Can now only use $('p') expressions to refer to other rule elements as inputs.

    • -41
    • +9
    ./ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 12 more files in changeset.