Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Software Model @UnsupportedWithInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 73 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Mark software model tests as @UnsupportedWithInstantExecution

to reduce CI time and noise when making changes

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +2
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 74 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -8
    • +8
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 871 more files in changeset.
Annotate integ tests failing with instant execution in :modelGroovy

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -0
    • +8
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Annotate integ tests failing with instant execution in :modelGroovy

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -0
    • +8
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 2 more files in changeset.
Fix ModelDslRuleInputDetectionIntegrationSpec

    • -0
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 160 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 281 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 282 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
  1. … 283 more files in changeset.
Fix model Groovy usages of output test fixtures

    • -3
    • +3
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
GRADLE-3373: Fixed model DSL transformation to allow input references as method parameters when the last method parameter is a closure.

    • -1
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
    • -2
    • +51
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 1 more file in changeset.
Moved int test into a package to live alongside some other tests with similar responsibilities.

    • -466
    • +0
    ./ModelMapDslIntegrationTest.groovy
  1. … 1 more file in changeset.
Added some test coverage for using `$.p` expressions in closures passed to `Project.model { }`.

These closures are not transformed and this usage should fail. The `Project.model { }` will be removed once the model DSL supports use cases such as 'apply these rules to all projects in the build'.

    • -5
    • +39
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
Changed the contract of `ExecutionResult.output` and `error` to return the output with line separators normalized to \n.

    • -3
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 5 more files in changeset.
Added some test coverage to verify that nested rule DSL closures cannot see the delegate of outer closures.

    • -0
    • +50
    ./ModelMapDslIntegrationTest.groovy
    • -0
    • +1
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
Enabled nested DSL rules for the API methods of `ModelMap`.

For example, `all { ... }` or `beforeEach(Type) { ... }`. This means that the closures passed to these methods will be treated as nested rules, with their own inputs, descriptor and so on.

    • -0
    • +143
    ./ModelMapDslIntegrationTest.groovy
  1. … 2 more files in changeset.
Added some test coverage for dynamically creating and configuring the elements of a `ModelMap` using the rules DSL.

    • -2
    • +69
    ./ModelMapDslIntegrationTest.groovy
Don't treat null-safe or spread property expressions as part of the path for a `$.path` input reference.

For example, treat `$.things*.name` as `($.things)*.name`. Similarly, treat `$.thing?.name` as `($.thing)?.name`.

    • -1
    • +30
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 1 more file in changeset.
Improved the rule descriptors used for nested DSL rules, so that they better reflect the expression used to define the rule in the build script.

    • -0
    • +35
    ./ModelMapDslIntegrationTest.groovy
  1. … 2 more files in changeset.
Enable nested DSL rules for subjects of type `ModelMap`.

This is the first step of enabling the DSL for creating and configuring items in a `ModelMap`. It is currently only supported for `name(Type) { ... }` and `name { ... }` syntax.

With this change, the closures in the syntax above are treated as rule actions, so that their input references are not treated as inputs for the outer closure but are instead treated as inputs of the nested rule. These actions are also given their own descriptor.

    • -0
    • +171
    ./ModelMapDslIntegrationTest.groovy
  1. … 3 more files in changeset.
Fixed DSL rule extraction when a closure that looks like a nested DSL rule is nested inside a closure that is not.

    • -0
    • +25
    ./transform/ModelDslRuleDetectionIntegrationSpec.groovy
    • -1
    • +1
    ./transform/NestedModelDslUsageIntegrationSpec.groovy
    • -0
    • +57
    ./transform/NestedModelRuleDslDetectionIntegrationTest.groovy
  1. … 2 more files in changeset.
Changed the descriptor for DSL rules so that it more closely matches the expression used in the code to reference the subject.

This change also detangles the subject path from the DSL rule descriptor, so that they can be different.

    • -4
    • +4
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 25 more files in changeset.
Use an interface for injecting the inputs into a transformed rules closure. Also defer registration of configure/initialize rules closures until the projections of the subject are known.

    • -1
    • +2
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy
  1. … 9 more files in changeset.
Fixed int test on windows.

    • -2
    • +3
    ./transform/ModelDslRuleInputDetectionIntegrationSpec.groovy